[jira] [Commented] (HADOOP-18183) s3a audit logs to publish range start/end of GET requests in audit header

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-18183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17628894#comment-17628894 ] 

ASF GitHub Bot commented on HADOOP-18183:
-----------------------------------------

sauraank opened a new pull request, #5110:
URL: https://github.com/apache/hadoop/pull/5110

   
   ### Description of PR
   Added the Range in the referer header for GetObjectRequest. It is of the format "bytes=%d-%d".
   
   ### How was this patch tested?
   Added the unit tests for it. Tested by running the unit tests and integration test on hadoop-aws successfully.
   
   ### For code changes:
   
   - [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
   - [ ] Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`, `NOTICE-binary` files?
   
   




> s3a audit logs to publish range start/end of GET requests in audit header
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-18183
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18183
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 3.3.2
>            Reporter: Steve Loughran
>            Assignee: Ankit Saurabh
>            Priority: Minor
>
> we don't get the range of ranged get requests in s3 server logs, because the AWS s3 log doesn't record that information. we can see it's a partial get from the 206 response, but the length of data retrieved is lost.
> LoggingAuditor.beforeExecution() would need to recognise a ranged GET and determine the extra key-val pairs for range start and end (rs & re?)
> we might need to modify {{HttpReferrerAuditHeader.buildHttpReferrer()}} to take a map of <string, string> so it can dynamically create a header for each request; currently that is not in there.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org