You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/01/27 17:42:24 UTC
[GitHub] [flink] afedulov opened a new pull request #18545: [FLINK-XXXX][connectors] Change scope of connector-base dependency to provided
afedulov opened a new pull request #18545:
URL: https://github.com/apache/flink/pull/18545
DRAFT to check CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18545: [FLINK-XXXX][connectors] Change scope of connector-base dependency to provided
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18545:
URL: https://github.com/apache/flink/pull/18545#issuecomment-1023486118
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30340",
"triggerID" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"triggerType" : "PUSH"
}, {
"hash" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30383",
"triggerID" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"triggerType" : "PUSH"
}, {
"hash" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30415",
"triggerID" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"triggerType" : "PUSH"
}, {
"hash" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1026180779",
"triggerType" : "MANUAL"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1026180779",
"triggerType" : "MANUAL"
}, {
"hash" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* e70afe4023c191016e7cc667403c5fa2501c5d34 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18545: [FLINK-25927][connectors] Make flink-connector-base dependency usage consistent across all connectors
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18545:
URL: https://github.com/apache/flink/pull/18545#issuecomment-1023486118
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30340",
"triggerID" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"triggerType" : "PUSH"
}, {
"hash" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30383",
"triggerID" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"triggerType" : "PUSH"
}, {
"hash" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30415",
"triggerID" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"triggerType" : "PUSH"
}, {
"hash" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564",
"triggerID" : "1026180779",
"triggerType" : "MANUAL"
}, {
"hash" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564",
"triggerID" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1026180779",
"triggerType" : "MANUAL"
}, {
"hash" : "18420c6d816aa7b87d765e08e87710aaa0212abb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30637",
"triggerID" : "18420c6d816aa7b87d765e08e87710aaa0212abb",
"triggerType" : "PUSH"
}, {
"hash" : "2742f93c4bf89dfdb27ac0b965df8bf72d23e8d3",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30640",
"triggerID" : "2742f93c4bf89dfdb27ac0b965df8bf72d23e8d3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e70afe4023c191016e7cc667403c5fa2501c5d34 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564)
* 18420c6d816aa7b87d765e08e87710aaa0212abb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30637)
* 2742f93c4bf89dfdb27ac0b965df8bf72d23e8d3 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30640)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18545: [FLINK-XXXX][connectors] Change scope of connector-base dependency to provided
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18545:
URL: https://github.com/apache/flink/pull/18545#issuecomment-1023486118
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30340",
"triggerID" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"triggerType" : "PUSH"
}, {
"hash" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a5f4b2900aadbaac10ee20d78597fe1457f1ec56 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30340)
* 006e796e482d4f1cb73b6557c4026168a75f20bc UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] afedulov commented on a change in pull request #18545: [FLINK-25927][connectors] Make flink-connector-base dependency usage consistent across all connectors
Posted by GitBox <gi...@apache.org>.
afedulov commented on a change in pull request #18545:
URL: https://github.com/apache/flink/pull/18545#discussion_r799456328
##########
File path: flink-end-to-end-tests/test-scripts/test_quickstarts.sh
##########
@@ -41,7 +41,7 @@ mkdir -p "${TEST_DATA_DIR}"
cd "${TEST_DATA_DIR}"
ARTIFACT_ID=flink-quickstart-${TEST_TYPE}
-ARTIFACT_VERSION=0.1
+ARTIFACT_VERSION=${FLINK_VERSION}
Review comment:
Not sure why @alpreu introduced this change. Reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18545: [FLINK-XXXX][connectors] Change scope of connector-base dependency to provided
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18545:
URL: https://github.com/apache/flink/pull/18545#issuecomment-1023486118
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30340",
"triggerID" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"triggerType" : "PUSH"
}, {
"hash" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30383",
"triggerID" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 006e796e482d4f1cb73b6557c4026168a75f20bc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30383)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18545: [FLINK-XXXX][connectors] Change scope of connector-base dependency to provided
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18545:
URL: https://github.com/apache/flink/pull/18545#issuecomment-1023486118
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30340",
"triggerID" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a5f4b2900aadbaac10ee20d78597fe1457f1ec56 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30340)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on a change in pull request #18545: [FLINK-25927][connectors] Make flink-connector-base dependency usage consistent across all connectors
Posted by GitBox <gi...@apache.org>.
fapaul commented on a change in pull request #18545:
URL: https://github.com/apache/flink/pull/18545#discussion_r797966208
##########
File path: flink-end-to-end-tests/test-scripts/test_quickstarts.sh
##########
@@ -41,7 +41,7 @@ mkdir -p "${TEST_DATA_DIR}"
cd "${TEST_DATA_DIR}"
ARTIFACT_ID=flink-quickstart-${TEST_TYPE}
-ARTIFACT_VERSION=0.1
+ARTIFACT_VERSION=${FLINK_VERSION}
Review comment:
How did this work before?
##########
File path: flink-formats/flink-orc/pom.xml
##########
@@ -55,6 +55,14 @@ under the License.
<optional>true</optional>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-base</artifactId>
+ <version>${project.version}</version>
+ <scope>provided</scope>
+ <optional>true</optional>
Review comment:
I guess the connector-base dependency is optional for all formats since it is probably only required when using a file-based implementation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18545: [FLINK-25927][connectors] Make flink-connector-base dependency usage consistent across all connectors
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18545:
URL: https://github.com/apache/flink/pull/18545#issuecomment-1023486118
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30340",
"triggerID" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"triggerType" : "PUSH"
}, {
"hash" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30383",
"triggerID" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"triggerType" : "PUSH"
}, {
"hash" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30415",
"triggerID" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"triggerType" : "PUSH"
}, {
"hash" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564",
"triggerID" : "1026180779",
"triggerType" : "MANUAL"
}, {
"hash" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564",
"triggerID" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1026180779",
"triggerType" : "MANUAL"
}, {
"hash" : "18420c6d816aa7b87d765e08e87710aaa0212abb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30637",
"triggerID" : "18420c6d816aa7b87d765e08e87710aaa0212abb",
"triggerType" : "PUSH"
}, {
"hash" : "2742f93c4bf89dfdb27ac0b965df8bf72d23e8d3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30640",
"triggerID" : "2742f93c4bf89dfdb27ac0b965df8bf72d23e8d3",
"triggerType" : "PUSH"
}, {
"hash" : "cbe7ec9af0a796017cfb3c3c60e9b743afc27232",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30685",
"triggerID" : "cbe7ec9af0a796017cfb3c3c60e9b743afc27232",
"triggerType" : "PUSH"
}, {
"hash" : "bc640dc36265dc71a529b2cfde577f9bdc0ed3fa",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30696",
"triggerID" : "bc640dc36265dc71a529b2cfde577f9bdc0ed3fa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2742f93c4bf89dfdb27ac0b965df8bf72d23e8d3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30640)
* cbe7ec9af0a796017cfb3c3c60e9b743afc27232 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30685)
* bc640dc36265dc71a529b2cfde577f9bdc0ed3fa Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30696)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18545: [FLINK-25927][connectors] Make flink-connector-base dependency usage consistent across all connectors
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18545:
URL: https://github.com/apache/flink/pull/18545#issuecomment-1023486118
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30340",
"triggerID" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"triggerType" : "PUSH"
}, {
"hash" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30383",
"triggerID" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"triggerType" : "PUSH"
}, {
"hash" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30415",
"triggerID" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"triggerType" : "PUSH"
}, {
"hash" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564",
"triggerID" : "1026180779",
"triggerType" : "MANUAL"
}, {
"hash" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564",
"triggerID" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1026180779",
"triggerType" : "MANUAL"
}, {
"hash" : "18420c6d816aa7b87d765e08e87710aaa0212abb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30637",
"triggerID" : "18420c6d816aa7b87d765e08e87710aaa0212abb",
"triggerType" : "PUSH"
}, {
"hash" : "2742f93c4bf89dfdb27ac0b965df8bf72d23e8d3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30640",
"triggerID" : "2742f93c4bf89dfdb27ac0b965df8bf72d23e8d3",
"triggerType" : "PUSH"
}, {
"hash" : "cbe7ec9af0a796017cfb3c3c60e9b743afc27232",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30685",
"triggerID" : "cbe7ec9af0a796017cfb3c3c60e9b743afc27232",
"triggerType" : "PUSH"
}, {
"hash" : "bc640dc36265dc71a529b2cfde577f9bdc0ed3fa",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bc640dc36265dc71a529b2cfde577f9bdc0ed3fa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2742f93c4bf89dfdb27ac0b965df8bf72d23e8d3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30640)
* cbe7ec9af0a796017cfb3c3c60e9b743afc27232 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30685)
* bc640dc36265dc71a529b2cfde577f9bdc0ed3fa UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18545: [FLINK-25927][connectors] Make flink-connector-base dependency usage consistent across all connectors
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18545:
URL: https://github.com/apache/flink/pull/18545#issuecomment-1023486118
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30340",
"triggerID" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"triggerType" : "PUSH"
}, {
"hash" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30383",
"triggerID" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"triggerType" : "PUSH"
}, {
"hash" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30415",
"triggerID" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"triggerType" : "PUSH"
}, {
"hash" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564",
"triggerID" : "1026180779",
"triggerType" : "MANUAL"
}, {
"hash" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564",
"triggerID" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1026180779",
"triggerType" : "MANUAL"
}, {
"hash" : "18420c6d816aa7b87d765e08e87710aaa0212abb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30637",
"triggerID" : "18420c6d816aa7b87d765e08e87710aaa0212abb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e70afe4023c191016e7cc667403c5fa2501c5d34 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564)
* 18420c6d816aa7b87d765e08e87710aaa0212abb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30637)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18545: [FLINK-XXXX][connectors] Change scope of connector-base dependency to provided
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18545:
URL: https://github.com/apache/flink/pull/18545#issuecomment-1023486118
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30340",
"triggerID" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"triggerType" : "PUSH"
}, {
"hash" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30383",
"triggerID" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"triggerType" : "PUSH"
}, {
"hash" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30415",
"triggerID" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "CANCELED",
"url" : "TBD",
"triggerID" : "1026180779",
"triggerType" : "MANUAL"
}, {
"hash" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564",
"triggerID" : "1026180779",
"triggerType" : "MANUAL"
}, {
"hash" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564",
"triggerID" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* Unknown: [CANCELED](TBD)
* e70afe4023c191016e7cc667403c5fa2501c5d34 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] afedulov commented on a change in pull request #18545: [FLINK-25927][connectors] Make flink-connector-base dependency usage consistent across all connectors
Posted by GitBox <gi...@apache.org>.
afedulov commented on a change in pull request #18545:
URL: https://github.com/apache/flink/pull/18545#discussion_r799456328
##########
File path: flink-end-to-end-tests/test-scripts/test_quickstarts.sh
##########
@@ -41,7 +41,7 @@ mkdir -p "${TEST_DATA_DIR}"
cd "${TEST_DATA_DIR}"
ARTIFACT_ID=flink-quickstart-${TEST_TYPE}
-ARTIFACT_VERSION=0.1
+ARTIFACT_VERSION=${FLINK_VERSION}
Review comment:
Not surer why @alpreu introduced this change. Reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] afedulov commented on a change in pull request #18545: [FLINK-25927][connectors] Make flink-connector-base dependency usage consistent across all connectors
Posted by GitBox <gi...@apache.org>.
afedulov commented on a change in pull request #18545:
URL: https://github.com/apache/flink/pull/18545#discussion_r809198134
##########
File path: flink-end-to-end-tests/test-scripts/test_quickstarts.sh
##########
@@ -41,7 +41,7 @@ mkdir -p "${TEST_DATA_DIR}"
cd "${TEST_DATA_DIR}"
ARTIFACT_ID=flink-quickstart-${TEST_TYPE}
-ARTIFACT_VERSION=0.1
+ARTIFACT_VERSION=${FLINK_VERSION}
Review comment:
@zentol, CI fails with
```
Feb 17 15:37:56 [ERROR] Failed to execute goal on project flink-quickstart-java: Could not resolve dependencies for project org.apache.flink.quickstart:flink-quickstart-java:jar:0.1: Could not find artifact org.apache.flink:flink-connector-base:jar:0.1 in google-maven-central (https://maven-central-eu.storage-download.googleapis.com/maven2/) -> [Help 1]
Feb 17 15:37:56 [ERROR]
Feb 17 15:37:56 [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
Feb 17 15:37:56 [ERROR] Re-run Maven using the -X switch to enable full debug logging.
Feb 17 15:37:56 [ERROR]
Feb 17 15:37:56 [ERROR] For more information about the errors and possible solutions, please read the following articles:
Feb 17 15:37:56 [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
/home/vsts/work/1/s/flink-end-to-end-tests/test-scripts/test_quickstarts.sh: line 82: cd: target: No such file or directory
java.io.FileNotFoundException: flink-quickstart-java-0.1.jar (No such file or directory)
at java.util.zip.ZipFile.open(Native Method)
at java.util.zip.ZipFile.<init>(ZipFile.java:228)
at java.util.zip.ZipFile.<init>(ZipFile.java:157)
at java.util.zip.ZipFile.<init>(ZipFile.java:128)
at sun.tools.jar.Main.list(Main.java:1115)
at sun.tools.jar.Main.run(Main.java:293)
at sun.tools.jar.Main.main(Main.java:1288)
```
Preceeded with
```
Feb 17 15:37:55 [WARNING] The POM for org.apache.flink:flink-connector-base:jar:0.1 is missing, no dependency information available
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18545: [FLINK-25927][connectors] Make flink-connector-base dependency usage consistent across all connectors
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18545:
URL: https://github.com/apache/flink/pull/18545#issuecomment-1023486118
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30340",
"triggerID" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"triggerType" : "PUSH"
}, {
"hash" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30383",
"triggerID" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"triggerType" : "PUSH"
}, {
"hash" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30415",
"triggerID" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"triggerType" : "PUSH"
}, {
"hash" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564",
"triggerID" : "1026180779",
"triggerType" : "MANUAL"
}, {
"hash" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564",
"triggerID" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1026180779",
"triggerType" : "MANUAL"
}, {
"hash" : "18420c6d816aa7b87d765e08e87710aaa0212abb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30637",
"triggerID" : "18420c6d816aa7b87d765e08e87710aaa0212abb",
"triggerType" : "PUSH"
}, {
"hash" : "2742f93c4bf89dfdb27ac0b965df8bf72d23e8d3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30640",
"triggerID" : "2742f93c4bf89dfdb27ac0b965df8bf72d23e8d3",
"triggerType" : "PUSH"
}, {
"hash" : "cbe7ec9af0a796017cfb3c3c60e9b743afc27232",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30685",
"triggerID" : "cbe7ec9af0a796017cfb3c3c60e9b743afc27232",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2742f93c4bf89dfdb27ac0b965df8bf72d23e8d3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30640)
* cbe7ec9af0a796017cfb3c3c60e9b743afc27232 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30685)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18545: [FLINK-25927][connectors] Make flink-connector-base dependency usage consistent across all connectors
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18545:
URL: https://github.com/apache/flink/pull/18545#issuecomment-1023486118
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30340",
"triggerID" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"triggerType" : "PUSH"
}, {
"hash" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30383",
"triggerID" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"triggerType" : "PUSH"
}, {
"hash" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30415",
"triggerID" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"triggerType" : "PUSH"
}, {
"hash" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564",
"triggerID" : "1026180779",
"triggerType" : "MANUAL"
}, {
"hash" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564",
"triggerID" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1026180779",
"triggerType" : "MANUAL"
}, {
"hash" : "18420c6d816aa7b87d765e08e87710aaa0212abb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30637",
"triggerID" : "18420c6d816aa7b87d765e08e87710aaa0212abb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e70afe4023c191016e7cc667403c5fa2501c5d34 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564)
* 18420c6d816aa7b87d765e08e87710aaa0212abb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30637)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18545: [FLINK-25927][connectors] Make flink-connector-base dependency usage consistent across all connectors
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18545:
URL: https://github.com/apache/flink/pull/18545#issuecomment-1023486118
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30340",
"triggerID" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"triggerType" : "PUSH"
}, {
"hash" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30383",
"triggerID" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"triggerType" : "PUSH"
}, {
"hash" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30415",
"triggerID" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"triggerType" : "PUSH"
}, {
"hash" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564",
"triggerID" : "1026180779",
"triggerType" : "MANUAL"
}, {
"hash" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564",
"triggerID" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1026180779",
"triggerType" : "MANUAL"
}, {
"hash" : "18420c6d816aa7b87d765e08e87710aaa0212abb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30637",
"triggerID" : "18420c6d816aa7b87d765e08e87710aaa0212abb",
"triggerType" : "PUSH"
}, {
"hash" : "2742f93c4bf89dfdb27ac0b965df8bf72d23e8d3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30640",
"triggerID" : "2742f93c4bf89dfdb27ac0b965df8bf72d23e8d3",
"triggerType" : "PUSH"
}, {
"hash" : "cbe7ec9af0a796017cfb3c3c60e9b743afc27232",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30685",
"triggerID" : "cbe7ec9af0a796017cfb3c3c60e9b743afc27232",
"triggerType" : "PUSH"
}, {
"hash" : "bc640dc36265dc71a529b2cfde577f9bdc0ed3fa",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30696",
"triggerID" : "bc640dc36265dc71a529b2cfde577f9bdc0ed3fa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bc640dc36265dc71a529b2cfde577f9bdc0ed3fa Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30696)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #18545: [FLINK-25927][connectors] Make flink-connector-base dependency usage consistent across all connectors
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #18545:
URL: https://github.com/apache/flink/pull/18545#discussion_r799343345
##########
File path: flink-end-to-end-tests/test-scripts/test_quickstarts.sh
##########
@@ -41,7 +41,7 @@ mkdir -p "${TEST_DATA_DIR}"
cd "${TEST_DATA_DIR}"
ARTIFACT_ID=flink-quickstart-${TEST_TYPE}
-ARTIFACT_VERSION=0.1
+ARTIFACT_VERSION=${FLINK_VERSION}
Review comment:
As such I don't understand why we're changing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18545: [FLINK-XXXX][connectors] Change scope of connector-base dependency to provided
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18545:
URL: https://github.com/apache/flink/pull/18545#issuecomment-1023486118
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30340",
"triggerID" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a5f4b2900aadbaac10ee20d78597fe1457f1ec56 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30340)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18545: [FLINK-XXXX][connectors] Change scope of connector-base dependency to provided
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18545:
URL: https://github.com/apache/flink/pull/18545#issuecomment-1023487110
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit a5f4b2900aadbaac10ee20d78597fe1457f1ec56 (Thu Jan 27 17:47:58 UTC 2022)
**Warnings:**
* **26 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **Invalid pull request title: No valid Jira ID provided**
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #18545: [FLINK-XXXX][connectors] Change scope of connector-base dependency to provided
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #18545:
URL: https://github.com/apache/flink/pull/18545#issuecomment-1023486118
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a5f4b2900aadbaac10ee20d78597fe1457f1ec56 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] afedulov commented on a change in pull request #18545: [FLINK-25927][connectors] Make flink-connector-base dependency usage consistent across all connectors
Posted by GitBox <gi...@apache.org>.
afedulov commented on a change in pull request #18545:
URL: https://github.com/apache/flink/pull/18545#discussion_r799546896
##########
File path: flink-dist/src/main/assemblies/bin.xml
##########
@@ -108,6 +108,13 @@ under the License.
</file>
<!-- Built-in connectors and formats -->
+ <file>
+ <source>../flink-connectors/flink-connector-base/target/flink-connector-base-${project.version}.jar</source>
Review comment:
Moved to flink-dist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] afedulov commented on pull request #18545: [FLINK-25927][connectors] Make flink-connector-base dependency usage consistent across all connectors
Posted by GitBox <gi...@apache.org>.
afedulov commented on pull request #18545:
URL: https://github.com/apache/flink/pull/18545#issuecomment-1049766538
As outlined [here](https://lists.apache.org/thread/hhjoc9hobs6h5pydr0623no2l36r6n6r), a combined approach of shading+relocation together with packaging `flink-connector-base` into `flink-dist` subsumes work in this PR. The PR with the new approach is: https://github.com/apache/flink/pull/18905`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on pull request #18545: [FLINK-25927][connectors] Make flink-connector-base dependency usage consistent across all connectors
Posted by GitBox <gi...@apache.org>.
fapaul commented on pull request #18545:
URL: https://github.com/apache/flink/pull/18545#issuecomment-1028932831
@zentol can you also have a look at this. The idea behind the PR is rather simple but I would like to get a second opinion not that we miss something simple.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18545: [FLINK-XXXX][connectors] Change scope of connector-base dependency to provided
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18545:
URL: https://github.com/apache/flink/pull/18545#issuecomment-1023486118
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30340",
"triggerID" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"triggerType" : "PUSH"
}, {
"hash" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30383",
"triggerID" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* a5f4b2900aadbaac10ee20d78597fe1457f1ec56 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30340)
* 006e796e482d4f1cb73b6557c4026168a75f20bc Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30383)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] afedulov edited a comment on pull request #18545: [FLINK-25927][connectors] Make flink-connector-base dependency usage consistent across all connectors
Posted by GitBox <gi...@apache.org>.
afedulov edited a comment on pull request #18545:
URL: https://github.com/apache/flink/pull/18545#issuecomment-1049766538
As outlined [here](https://lists.apache.org/thread/hhjoc9hobs6h5pydr0623no2l36r6n6r), a combined approach of shading+relocation together with packaging `flink-connector-base` into `flink-dist` subsumes work in this PR. The PR with the new approach is: https://github.com/apache/flink/pull/18905
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18545: [FLINK-XXXX][connectors] Change scope of connector-base dependency to provided
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18545:
URL: https://github.com/apache/flink/pull/18545#issuecomment-1023486118
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30340",
"triggerID" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"triggerType" : "PUSH"
}, {
"hash" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30383",
"triggerID" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"triggerType" : "PUSH"
}, {
"hash" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30415",
"triggerID" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4ce7d031d7a36e2a96261578ee896fc852bedc03 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30415)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18545: [FLINK-25927][connectors] Make flink-connector-base dependency usage consistent across all connectors
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18545:
URL: https://github.com/apache/flink/pull/18545#issuecomment-1023486118
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30340",
"triggerID" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"triggerType" : "PUSH"
}, {
"hash" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30383",
"triggerID" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"triggerType" : "PUSH"
}, {
"hash" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30415",
"triggerID" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"triggerType" : "PUSH"
}, {
"hash" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564",
"triggerID" : "1026180779",
"triggerType" : "MANUAL"
}, {
"hash" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564",
"triggerID" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1026180779",
"triggerType" : "MANUAL"
}, {
"hash" : "18420c6d816aa7b87d765e08e87710aaa0212abb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30637",
"triggerID" : "18420c6d816aa7b87d765e08e87710aaa0212abb",
"triggerType" : "PUSH"
}, {
"hash" : "2742f93c4bf89dfdb27ac0b965df8bf72d23e8d3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30640",
"triggerID" : "2742f93c4bf89dfdb27ac0b965df8bf72d23e8d3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 18420c6d816aa7b87d765e08e87710aaa0212abb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30637)
* 2742f93c4bf89dfdb27ac0b965df8bf72d23e8d3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30640)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] fapaul commented on pull request #18545: [FLINK-25927][connectors] Make flink-connector-base dependency usage consistent across all connectors
Posted by GitBox <gi...@apache.org>.
fapaul commented on pull request #18545:
URL: https://github.com/apache/flink/pull/18545#issuecomment-1029939470
> I'm not sure I get this change. I thought when the connectors are externalized that would also imply that flink-connector-base is moved.
Do you mean moving `flink-connector-base` into a separate repository or do you mean moving `flink-connector-base` to i.e. `flink-core`?
I think the first option adds too much complexity. I haven't thought about the second option yet but in general, I do not see something immediately that is opposed to it.
The current situation is quite risky because connectors not shading `connector-base` only work as long as the SQL FIle connector is on the classpath because it bundles `connector-base`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18545: [FLINK-25927][connectors] Make flink-connector-base dependency usage consistent across all connectors
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18545:
URL: https://github.com/apache/flink/pull/18545#issuecomment-1023486118
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30340",
"triggerID" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"triggerType" : "PUSH"
}, {
"hash" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30383",
"triggerID" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"triggerType" : "PUSH"
}, {
"hash" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30415",
"triggerID" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"triggerType" : "PUSH"
}, {
"hash" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564",
"triggerID" : "1026180779",
"triggerType" : "MANUAL"
}, {
"hash" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564",
"triggerID" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1026180779",
"triggerType" : "MANUAL"
}, {
"hash" : "18420c6d816aa7b87d765e08e87710aaa0212abb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30637",
"triggerID" : "18420c6d816aa7b87d765e08e87710aaa0212abb",
"triggerType" : "PUSH"
}, {
"hash" : "2742f93c4bf89dfdb27ac0b965df8bf72d23e8d3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30640",
"triggerID" : "2742f93c4bf89dfdb27ac0b965df8bf72d23e8d3",
"triggerType" : "PUSH"
}, {
"hash" : "cbe7ec9af0a796017cfb3c3c60e9b743afc27232",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30685",
"triggerID" : "cbe7ec9af0a796017cfb3c3c60e9b743afc27232",
"triggerType" : "PUSH"
}, {
"hash" : "bc640dc36265dc71a529b2cfde577f9bdc0ed3fa",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30696",
"triggerID" : "bc640dc36265dc71a529b2cfde577f9bdc0ed3fa",
"triggerType" : "PUSH"
}, {
"hash" : "c980367f580fefaa6e1024ece67b46326302ca46",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30777",
"triggerID" : "c980367f580fefaa6e1024ece67b46326302ca46",
"triggerType" : "PUSH"
}, {
"hash" : "40ca1773d5c19b3c12e802cabf25e510eab342c9",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30802",
"triggerID" : "40ca1773d5c19b3c12e802cabf25e510eab342c9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c980367f580fefaa6e1024ece67b46326302ca46 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30777)
* 40ca1773d5c19b3c12e802cabf25e510eab342c9 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30802)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] afedulov commented on a change in pull request #18545: [FLINK-25927][connectors] Make flink-connector-base dependency usage consistent across all connectors
Posted by GitBox <gi...@apache.org>.
afedulov commented on a change in pull request #18545:
URL: https://github.com/apache/flink/pull/18545#discussion_r800066871
##########
File path: flink-formats/flink-orc/pom.xml
##########
@@ -55,6 +55,14 @@ under the License.
<optional>true</optional>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-base</artifactId>
+ <version>${project.version}</version>
+ <scope>provided</scope>
+ <optional>true</optional>
Review comment:
This particular format uses it directly:
https://github.com/apache/flink/blob/c6997c97c575d334679915c328792b8a3067cfb5/flink-formats/flink-orc/src/main/java/org/apache/flink/orc/AbstractOrcFileInputFormat.java#L23
The situation seems to be identical to the file-connector-files dependency in this format, which is declared as provided and optional:
https://github.com/afedulov/flink/blob/40ca1773d5c19b3c12e802cabf25e510eab342c9/flink-formats/flink-orc/pom.xml#L68
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18545: [FLINK-25927][connectors] Make flink-connector-base dependency usage consistent across all connectors
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18545:
URL: https://github.com/apache/flink/pull/18545#issuecomment-1023486118
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30340",
"triggerID" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"triggerType" : "PUSH"
}, {
"hash" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30383",
"triggerID" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"triggerType" : "PUSH"
}, {
"hash" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30415",
"triggerID" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"triggerType" : "PUSH"
}, {
"hash" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564",
"triggerID" : "1026180779",
"triggerType" : "MANUAL"
}, {
"hash" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564",
"triggerID" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1026180779",
"triggerType" : "MANUAL"
}, {
"hash" : "18420c6d816aa7b87d765e08e87710aaa0212abb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30637",
"triggerID" : "18420c6d816aa7b87d765e08e87710aaa0212abb",
"triggerType" : "PUSH"
}, {
"hash" : "2742f93c4bf89dfdb27ac0b965df8bf72d23e8d3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30640",
"triggerID" : "2742f93c4bf89dfdb27ac0b965df8bf72d23e8d3",
"triggerType" : "PUSH"
}, {
"hash" : "cbe7ec9af0a796017cfb3c3c60e9b743afc27232",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30685",
"triggerID" : "cbe7ec9af0a796017cfb3c3c60e9b743afc27232",
"triggerType" : "PUSH"
}, {
"hash" : "bc640dc36265dc71a529b2cfde577f9bdc0ed3fa",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30696",
"triggerID" : "bc640dc36265dc71a529b2cfde577f9bdc0ed3fa",
"triggerType" : "PUSH"
}, {
"hash" : "c980367f580fefaa6e1024ece67b46326302ca46",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30777",
"triggerID" : "c980367f580fefaa6e1024ece67b46326302ca46",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bc640dc36265dc71a529b2cfde577f9bdc0ed3fa Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30696)
* c980367f580fefaa6e1024ece67b46326302ca46 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30777)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18545: [FLINK-25927][connectors] Make flink-connector-base dependency usage consistent across all connectors
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18545:
URL: https://github.com/apache/flink/pull/18545#issuecomment-1023486118
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30340",
"triggerID" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"triggerType" : "PUSH"
}, {
"hash" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30383",
"triggerID" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"triggerType" : "PUSH"
}, {
"hash" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30415",
"triggerID" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"triggerType" : "PUSH"
}, {
"hash" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564",
"triggerID" : "1026180779",
"triggerType" : "MANUAL"
}, {
"hash" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564",
"triggerID" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1026180779",
"triggerType" : "MANUAL"
}, {
"hash" : "18420c6d816aa7b87d765e08e87710aaa0212abb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30637",
"triggerID" : "18420c6d816aa7b87d765e08e87710aaa0212abb",
"triggerType" : "PUSH"
}, {
"hash" : "2742f93c4bf89dfdb27ac0b965df8bf72d23e8d3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30640",
"triggerID" : "2742f93c4bf89dfdb27ac0b965df8bf72d23e8d3",
"triggerType" : "PUSH"
}, {
"hash" : "cbe7ec9af0a796017cfb3c3c60e9b743afc27232",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30685",
"triggerID" : "cbe7ec9af0a796017cfb3c3c60e9b743afc27232",
"triggerType" : "PUSH"
}, {
"hash" : "bc640dc36265dc71a529b2cfde577f9bdc0ed3fa",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30696",
"triggerID" : "bc640dc36265dc71a529b2cfde577f9bdc0ed3fa",
"triggerType" : "PUSH"
}, {
"hash" : "c980367f580fefaa6e1024ece67b46326302ca46",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30777",
"triggerID" : "c980367f580fefaa6e1024ece67b46326302ca46",
"triggerType" : "PUSH"
}, {
"hash" : "40ca1773d5c19b3c12e802cabf25e510eab342c9",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "40ca1773d5c19b3c12e802cabf25e510eab342c9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c980367f580fefaa6e1024ece67b46326302ca46 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30777)
* 40ca1773d5c19b3c12e802cabf25e510eab342c9 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #18545: [FLINK-25927][connectors] Make flink-connector-base dependency usage consistent across all connectors
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #18545:
URL: https://github.com/apache/flink/pull/18545#discussion_r799355513
##########
File path: flink-formats/flink-orc/pom.xml
##########
@@ -55,6 +55,14 @@ under the License.
<optional>true</optional>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-base</artifactId>
+ <version>${project.version}</version>
+ <scope>provided</scope>
+ <optional>true</optional>
Review comment:
Are the formats actually using the flink-connector-base API? If not, then they shouldn't have a dependency on it, as this is covered by the connector.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18545: [FLINK-XXXX][connectors] Change scope of connector-base dependency to provided
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18545:
URL: https://github.com/apache/flink/pull/18545#issuecomment-1023486118
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30340",
"triggerID" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"triggerType" : "PUSH"
}, {
"hash" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30383",
"triggerID" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"triggerType" : "PUSH"
}, {
"hash" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 006e796e482d4f1cb73b6557c4026168a75f20bc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30383)
* 4ce7d031d7a36e2a96261578ee896fc852bedc03 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18545: [FLINK-25927][connectors] Make flink-connector-base dependency usage consistent across all connectors
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18545:
URL: https://github.com/apache/flink/pull/18545#issuecomment-1023486118
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30340",
"triggerID" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"triggerType" : "PUSH"
}, {
"hash" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30383",
"triggerID" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"triggerType" : "PUSH"
}, {
"hash" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30415",
"triggerID" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"triggerType" : "PUSH"
}, {
"hash" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564",
"triggerID" : "1026180779",
"triggerType" : "MANUAL"
}, {
"hash" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564",
"triggerID" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1026180779",
"triggerType" : "MANUAL"
}, {
"hash" : "18420c6d816aa7b87d765e08e87710aaa0212abb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30637",
"triggerID" : "18420c6d816aa7b87d765e08e87710aaa0212abb",
"triggerType" : "PUSH"
}, {
"hash" : "2742f93c4bf89dfdb27ac0b965df8bf72d23e8d3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30640",
"triggerID" : "2742f93c4bf89dfdb27ac0b965df8bf72d23e8d3",
"triggerType" : "PUSH"
}, {
"hash" : "cbe7ec9af0a796017cfb3c3c60e9b743afc27232",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cbe7ec9af0a796017cfb3c3c60e9b743afc27232",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2742f93c4bf89dfdb27ac0b965df8bf72d23e8d3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30640)
* cbe7ec9af0a796017cfb3c3c60e9b743afc27232 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18545: [FLINK-25927][connectors] Make flink-connector-base dependency usage consistent across all connectors
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18545:
URL: https://github.com/apache/flink/pull/18545#issuecomment-1023486118
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30340",
"triggerID" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"triggerType" : "PUSH"
}, {
"hash" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30383",
"triggerID" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"triggerType" : "PUSH"
}, {
"hash" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30415",
"triggerID" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"triggerType" : "PUSH"
}, {
"hash" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564",
"triggerID" : "1026180779",
"triggerType" : "MANUAL"
}, {
"hash" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564",
"triggerID" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1026180779",
"triggerType" : "MANUAL"
}, {
"hash" : "18420c6d816aa7b87d765e08e87710aaa0212abb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30637",
"triggerID" : "18420c6d816aa7b87d765e08e87710aaa0212abb",
"triggerType" : "PUSH"
}, {
"hash" : "2742f93c4bf89dfdb27ac0b965df8bf72d23e8d3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2742f93c4bf89dfdb27ac0b965df8bf72d23e8d3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e70afe4023c191016e7cc667403c5fa2501c5d34 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564)
* 18420c6d816aa7b87d765e08e87710aaa0212abb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30637)
* 2742f93c4bf89dfdb27ac0b965df8bf72d23e8d3 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18545: [FLINK-25927][connectors] Make flink-connector-base dependency usage consistent across all connectors
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18545:
URL: https://github.com/apache/flink/pull/18545#issuecomment-1023486118
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30340",
"triggerID" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"triggerType" : "PUSH"
}, {
"hash" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30383",
"triggerID" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"triggerType" : "PUSH"
}, {
"hash" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30415",
"triggerID" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"triggerType" : "PUSH"
}, {
"hash" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564",
"triggerID" : "1026180779",
"triggerType" : "MANUAL"
}, {
"hash" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564",
"triggerID" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1026180779",
"triggerType" : "MANUAL"
}, {
"hash" : "18420c6d816aa7b87d765e08e87710aaa0212abb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30637",
"triggerID" : "18420c6d816aa7b87d765e08e87710aaa0212abb",
"triggerType" : "PUSH"
}, {
"hash" : "2742f93c4bf89dfdb27ac0b965df8bf72d23e8d3",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30640",
"triggerID" : "2742f93c4bf89dfdb27ac0b965df8bf72d23e8d3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 2742f93c4bf89dfdb27ac0b965df8bf72d23e8d3 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30640)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18545: [FLINK-25927][connectors] Make flink-connector-base dependency usage consistent across all connectors
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18545:
URL: https://github.com/apache/flink/pull/18545#issuecomment-1023486118
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30340",
"triggerID" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"triggerType" : "PUSH"
}, {
"hash" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30383",
"triggerID" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"triggerType" : "PUSH"
}, {
"hash" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30415",
"triggerID" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"triggerType" : "PUSH"
}, {
"hash" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564",
"triggerID" : "1026180779",
"triggerType" : "MANUAL"
}, {
"hash" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564",
"triggerID" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1026180779",
"triggerType" : "MANUAL"
}, {
"hash" : "18420c6d816aa7b87d765e08e87710aaa0212abb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30637",
"triggerID" : "18420c6d816aa7b87d765e08e87710aaa0212abb",
"triggerType" : "PUSH"
}, {
"hash" : "2742f93c4bf89dfdb27ac0b965df8bf72d23e8d3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30640",
"triggerID" : "2742f93c4bf89dfdb27ac0b965df8bf72d23e8d3",
"triggerType" : "PUSH"
}, {
"hash" : "cbe7ec9af0a796017cfb3c3c60e9b743afc27232",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30685",
"triggerID" : "cbe7ec9af0a796017cfb3c3c60e9b743afc27232",
"triggerType" : "PUSH"
}, {
"hash" : "bc640dc36265dc71a529b2cfde577f9bdc0ed3fa",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30696",
"triggerID" : "bc640dc36265dc71a529b2cfde577f9bdc0ed3fa",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cbe7ec9af0a796017cfb3c3c60e9b743afc27232 Azure: [CANCELED](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30685)
* bc640dc36265dc71a529b2cfde577f9bdc0ed3fa Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30696)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18545: [FLINK-25927][connectors] Make flink-connector-base dependency usage consistent across all connectors
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18545:
URL: https://github.com/apache/flink/pull/18545#issuecomment-1023486118
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30340",
"triggerID" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"triggerType" : "PUSH"
}, {
"hash" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30383",
"triggerID" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"triggerType" : "PUSH"
}, {
"hash" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30415",
"triggerID" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"triggerType" : "PUSH"
}, {
"hash" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564",
"triggerID" : "1026180779",
"triggerType" : "MANUAL"
}, {
"hash" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564",
"triggerID" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1026180779",
"triggerType" : "MANUAL"
}, {
"hash" : "18420c6d816aa7b87d765e08e87710aaa0212abb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30637",
"triggerID" : "18420c6d816aa7b87d765e08e87710aaa0212abb",
"triggerType" : "PUSH"
}, {
"hash" : "2742f93c4bf89dfdb27ac0b965df8bf72d23e8d3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30640",
"triggerID" : "2742f93c4bf89dfdb27ac0b965df8bf72d23e8d3",
"triggerType" : "PUSH"
}, {
"hash" : "cbe7ec9af0a796017cfb3c3c60e9b743afc27232",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30685",
"triggerID" : "cbe7ec9af0a796017cfb3c3c60e9b743afc27232",
"triggerType" : "PUSH"
}, {
"hash" : "bc640dc36265dc71a529b2cfde577f9bdc0ed3fa",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30696",
"triggerID" : "bc640dc36265dc71a529b2cfde577f9bdc0ed3fa",
"triggerType" : "PUSH"
}, {
"hash" : "c980367f580fefaa6e1024ece67b46326302ca46",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30777",
"triggerID" : "c980367f580fefaa6e1024ece67b46326302ca46",
"triggerType" : "PUSH"
}, {
"hash" : "40ca1773d5c19b3c12e802cabf25e510eab342c9",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30802",
"triggerID" : "40ca1773d5c19b3c12e802cabf25e510eab342c9",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 40ca1773d5c19b3c12e802cabf25e510eab342c9 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30802)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] afedulov commented on a change in pull request #18545: [FLINK-25927][connectors] Make flink-connector-base dependency usage consistent across all connectors
Posted by GitBox <gi...@apache.org>.
afedulov commented on a change in pull request #18545:
URL: https://github.com/apache/flink/pull/18545#discussion_r809198134
##########
File path: flink-end-to-end-tests/test-scripts/test_quickstarts.sh
##########
@@ -41,7 +41,7 @@ mkdir -p "${TEST_DATA_DIR}"
cd "${TEST_DATA_DIR}"
ARTIFACT_ID=flink-quickstart-${TEST_TYPE}
-ARTIFACT_VERSION=0.1
+ARTIFACT_VERSION=${FLINK_VERSION}
Review comment:
@zentol, CI fails with
```
Feb 17 15:37:56 [ERROR] Failed to execute goal on project flink-quickstart-java: Could not resolve dependencies for project org.apache.flink.quickstart:flink-quickstart-java:jar:0.1: Could not find artifact org.apache.flink:flink-connector-base:jar:0.1 in google-maven-central (https://maven-central-eu.storage-download.googleapis.com/maven2/) -> [Help 1]
Feb 17 15:37:56 [ERROR]
Feb 17 15:37:56 [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
Feb 17 15:37:56 [ERROR] Re-run Maven using the -X switch to enable full debug logging.
Feb 17 15:37:56 [ERROR]
Feb 17 15:37:56 [ERROR] For more information about the errors and possible solutions, please read the following articles:
Feb 17 15:37:56 [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/DependencyResolutionException
/home/vsts/work/1/s/flink-end-to-end-tests/test-scripts/test_quickstarts.sh: line 82: cd: target: No such file or directory
java.io.FileNotFoundException: flink-quickstart-java-0.1.jar (No such file or directory)
at java.util.zip.ZipFile.open(Native Method)
at java.util.zip.ZipFile.<init>(ZipFile.java:228)
at java.util.zip.ZipFile.<init>(ZipFile.java:157)
at java.util.zip.ZipFile.<init>(ZipFile.java:128)
at sun.tools.jar.Main.list(Main.java:1115)
at sun.tools.jar.Main.run(Main.java:293)
at sun.tools.jar.Main.main(Main.java:1288)
```
Preceeded with
```
Feb 17 15:37:55 [WARNING] The POM for org.apache.flink:flink-connector-base:jar:0.1 is missing, no dependency information available
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #18545: [FLINK-25927][connectors] Make flink-connector-base dependency usage consistent across all connectors
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #18545:
URL: https://github.com/apache/flink/pull/18545#discussion_r799342225
##########
File path: flink-end-to-end-tests/test-scripts/test_quickstarts.sh
##########
@@ -41,7 +41,7 @@ mkdir -p "${TEST_DATA_DIR}"
cd "${TEST_DATA_DIR}"
ARTIFACT_ID=flink-quickstart-${TEST_TYPE}
-ARTIFACT_VERSION=0.1
+ARTIFACT_VERSION=${FLINK_VERSION}
Review comment:
ARTIFACT_VERSION is the version of the generated project. The version of the archetype is FLINK_VERSION.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #18545: [FLINK-25927][connectors] Make flink-connector-base dependency usage consistent across all connectors
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #18545:
URL: https://github.com/apache/flink/pull/18545#discussion_r799344280
##########
File path: flink-examples/flink-examples-streaming/pom.xml
##########
@@ -86,6 +86,13 @@ under the License.
<!-- test dependencies -->
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-base</artifactId>
Review comment:
I don't understand why this dependency is necessary. It should be on the classpath in any case because the connectors have a dependency on it. This should also apply to other modules.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18545: [FLINK-XXXX][connectors] Change scope of connector-base dependency to provided
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18545:
URL: https://github.com/apache/flink/pull/18545#issuecomment-1023486118
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30340",
"triggerID" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"triggerType" : "PUSH"
}, {
"hash" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30383",
"triggerID" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"triggerType" : "PUSH"
}, {
"hash" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30415",
"triggerID" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 006e796e482d4f1cb73b6557c4026168a75f20bc Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30383)
* 4ce7d031d7a36e2a96261578ee896fc852bedc03 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30415)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] afedulov closed pull request #18545: [FLINK-25927][connectors] Make flink-connector-base dependency usage consistent across all connectors
Posted by GitBox <gi...@apache.org>.
afedulov closed pull request #18545:
URL: https://github.com/apache/flink/pull/18545
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] afedulov commented on a change in pull request #18545: [FLINK-25927][connectors] Make flink-connector-base dependency usage consistent across all connectors
Posted by GitBox <gi...@apache.org>.
afedulov commented on a change in pull request #18545:
URL: https://github.com/apache/flink/pull/18545#discussion_r808544579
##########
File path: flink-connectors/flink-connector-hive/pom.xml
##########
@@ -549,6 +549,13 @@ under the License.
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-base</artifactId>
Review comment:
I assume so. Without this dependency the test `HiveInputFormatPartitionReaderITCase.testReadMultipleSplits()` fails with:
```
Caused by: java.lang.NoClassDefFoundError: org/apache/flink/connector/base/source/reader/SingleThreadMultiplexSourceReaderBase
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18545: [FLINK-25927][connectors] Make flink-connector-base dependency usage consistent across all connectors
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18545:
URL: https://github.com/apache/flink/pull/18545#issuecomment-1023486118
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30340",
"triggerID" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"triggerType" : "PUSH"
}, {
"hash" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30383",
"triggerID" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"triggerType" : "PUSH"
}, {
"hash" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30415",
"triggerID" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"triggerType" : "PUSH"
}, {
"hash" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564",
"triggerID" : "1026180779",
"triggerType" : "MANUAL"
}, {
"hash" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564",
"triggerID" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1026180779",
"triggerType" : "MANUAL"
}, {
"hash" : "18420c6d816aa7b87d765e08e87710aaa0212abb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30637",
"triggerID" : "18420c6d816aa7b87d765e08e87710aaa0212abb",
"triggerType" : "PUSH"
}, {
"hash" : "2742f93c4bf89dfdb27ac0b965df8bf72d23e8d3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30640",
"triggerID" : "2742f93c4bf89dfdb27ac0b965df8bf72d23e8d3",
"triggerType" : "PUSH"
}, {
"hash" : "cbe7ec9af0a796017cfb3c3c60e9b743afc27232",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30685",
"triggerID" : "cbe7ec9af0a796017cfb3c3c60e9b743afc27232",
"triggerType" : "PUSH"
}, {
"hash" : "bc640dc36265dc71a529b2cfde577f9bdc0ed3fa",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30696",
"triggerID" : "bc640dc36265dc71a529b2cfde577f9bdc0ed3fa",
"triggerType" : "PUSH"
}, {
"hash" : "c980367f580fefaa6e1024ece67b46326302ca46",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30777",
"triggerID" : "c980367f580fefaa6e1024ece67b46326302ca46",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c980367f580fefaa6e1024ece67b46326302ca46 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30777)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18545: [FLINK-25927][connectors] Make flink-connector-base dependency usage consistent across all connectors
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18545:
URL: https://github.com/apache/flink/pull/18545#issuecomment-1023486118
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30340",
"triggerID" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"triggerType" : "PUSH"
}, {
"hash" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30383",
"triggerID" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"triggerType" : "PUSH"
}, {
"hash" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30415",
"triggerID" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"triggerType" : "PUSH"
}, {
"hash" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564",
"triggerID" : "1026180779",
"triggerType" : "MANUAL"
}, {
"hash" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564",
"triggerID" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1026180779",
"triggerType" : "MANUAL"
}, {
"hash" : "18420c6d816aa7b87d765e08e87710aaa0212abb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30637",
"triggerID" : "18420c6d816aa7b87d765e08e87710aaa0212abb",
"triggerType" : "PUSH"
}, {
"hash" : "2742f93c4bf89dfdb27ac0b965df8bf72d23e8d3",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30640",
"triggerID" : "2742f93c4bf89dfdb27ac0b965df8bf72d23e8d3",
"triggerType" : "PUSH"
}, {
"hash" : "cbe7ec9af0a796017cfb3c3c60e9b743afc27232",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30685",
"triggerID" : "cbe7ec9af0a796017cfb3c3c60e9b743afc27232",
"triggerType" : "PUSH"
}, {
"hash" : "bc640dc36265dc71a529b2cfde577f9bdc0ed3fa",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30696",
"triggerID" : "bc640dc36265dc71a529b2cfde577f9bdc0ed3fa",
"triggerType" : "PUSH"
}, {
"hash" : "c980367f580fefaa6e1024ece67b46326302ca46",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c980367f580fefaa6e1024ece67b46326302ca46",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bc640dc36265dc71a529b2cfde577f9bdc0ed3fa Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30696)
* c980367f580fefaa6e1024ece67b46326302ca46 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] afedulov edited a comment on pull request #18545: [FLINK-25927][connectors] Make flink-connector-base dependency usage consistent across all connectors
Posted by GitBox <gi...@apache.org>.
afedulov edited a comment on pull request #18545:
URL: https://github.com/apache/flink/pull/18545#issuecomment-1028964410
@zentol this branch passed CI successfully yesterday [(link)](https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=30637&view=results), I am currently checking why it started to fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] afedulov commented on pull request #18545: [FLINK-25927][connectors] Make flink-connector-base dependency usage consistent across all connectors
Posted by GitBox <gi...@apache.org>.
afedulov commented on pull request #18545:
URL: https://github.com/apache/flink/pull/18545#issuecomment-1028964410
@zentol this branch passed CI successfully yesterday [(link)](https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=30637&view=results), I am currently checking why it fails now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #18545: [FLINK-25927][connectors] Make flink-connector-base dependency usage consistent across all connectors
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #18545:
URL: https://github.com/apache/flink/pull/18545#discussion_r799347081
##########
File path: flink-dist/src/main/assemblies/bin.xml
##########
@@ -108,6 +108,13 @@ under the License.
</file>
<!-- Built-in connectors and formats -->
+ <file>
+ <source>../flink-connectors/flink-connector-base/target/flink-connector-base-${project.version}.jar</source>
Review comment:
This is unnecessary; it could just be included in the flink-dist jar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18545: [FLINK-XXXX][connectors] Change scope of connector-base dependency to provided
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18545:
URL: https://github.com/apache/flink/pull/18545#issuecomment-1023486118
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30340",
"triggerID" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"triggerType" : "PUSH"
}, {
"hash" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30383",
"triggerID" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"triggerType" : "PUSH"
}, {
"hash" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30415",
"triggerID" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"triggerType" : "PUSH"
}, {
"hash" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564",
"triggerID" : "1026180779",
"triggerType" : "MANUAL"
}, {
"hash" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564",
"triggerID" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1026180779",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* e70afe4023c191016e7cc667403c5fa2501c5d34 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] afedulov commented on pull request #18545: [FLINK-XXXX][connectors] Change scope of connector-base dependency to provided
Posted by GitBox <gi...@apache.org>.
afedulov commented on pull request #18545:
URL: https://github.com/apache/flink/pull/18545#issuecomment-1026180779
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18545: [FLINK-25927][connectors] Make flink-connector-base dependency usage consistent across all connectors
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18545:
URL: https://github.com/apache/flink/pull/18545#issuecomment-1023486118
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30340",
"triggerID" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"triggerType" : "PUSH"
}, {
"hash" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30383",
"triggerID" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"triggerType" : "PUSH"
}, {
"hash" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30415",
"triggerID" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"triggerType" : "PUSH"
}, {
"hash" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564",
"triggerID" : "1026180779",
"triggerType" : "MANUAL"
}, {
"hash" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564",
"triggerID" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1026180779",
"triggerType" : "MANUAL"
}, {
"hash" : "18420c6d816aa7b87d765e08e87710aaa0212abb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "18420c6d816aa7b87d765e08e87710aaa0212abb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e70afe4023c191016e7cc667403c5fa2501c5d34 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564)
* 18420c6d816aa7b87d765e08e87710aaa0212abb UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #18545: [FLINK-25927][connectors] Make flink-connector-base dependency usage consistent across all connectors
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #18545:
URL: https://github.com/apache/flink/pull/18545#issuecomment-1023486118
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30340",
"triggerID" : "a5f4b2900aadbaac10ee20d78597fe1457f1ec56",
"triggerType" : "PUSH"
}, {
"hash" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30383",
"triggerID" : "006e796e482d4f1cb73b6557c4026168a75f20bc",
"triggerType" : "PUSH"
}, {
"hash" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30415",
"triggerID" : "4ce7d031d7a36e2a96261578ee896fc852bedc03",
"triggerType" : "PUSH"
}, {
"hash" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564",
"triggerID" : "1026180779",
"triggerType" : "MANUAL"
}, {
"hash" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564",
"triggerID" : "e70afe4023c191016e7cc667403c5fa2501c5d34",
"triggerType" : "PUSH"
}, {
"hash" : "",
"status" : "DELETED",
"url" : "TBD",
"triggerID" : "1026180779",
"triggerType" : "MANUAL"
}, {
"hash" : "18420c6d816aa7b87d765e08e87710aaa0212abb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30637",
"triggerID" : "18420c6d816aa7b87d765e08e87710aaa0212abb",
"triggerType" : "PUSH"
}, {
"hash" : "2742f93c4bf89dfdb27ac0b965df8bf72d23e8d3",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "2742f93c4bf89dfdb27ac0b965df8bf72d23e8d3",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e70afe4023c191016e7cc667403c5fa2501c5d34 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30564)
* 18420c6d816aa7b87d765e08e87710aaa0212abb Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=30637)
* 2742f93c4bf89dfdb27ac0b965df8bf72d23e8d3 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] zentol commented on a change in pull request #18545: [FLINK-25927][connectors] Make flink-connector-base dependency usage consistent across all connectors
Posted by GitBox <gi...@apache.org>.
zentol commented on a change in pull request #18545:
URL: https://github.com/apache/flink/pull/18545#discussion_r800509878
##########
File path: flink-connectors/flink-connector-elasticsearch6/pom.xml
##########
@@ -114,6 +114,13 @@ under the License.
<type>test-jar</type>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-base</artifactId>
Review comment:
same comment as for es7
##########
File path: flink-connectors/flink-connector-hive/pom.xml
##########
@@ -549,6 +549,13 @@ under the License.
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-base</artifactId>
Review comment:
What does the hive connector need it for? because of some format?
##########
File path: flink-formats/flink-orc/pom.xml
##########
@@ -55,6 +55,14 @@ under the License.
<optional>true</optional>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-base</artifactId>
+ <version>${project.version}</version>
+ <scope>provided</scope>
+ <optional>true</optional>
Review comment:
I wouldn't mark it as optional.
##########
File path: flink-quickstart/flink-quickstart-scala/src/main/resources/archetype-resources/pom.xml
##########
@@ -86,6 +86,12 @@ under the License.
</dependency>
-->
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-base</artifactId>
Review comment:
see above
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common-kafka/pom.xml
##########
@@ -157,6 +157,13 @@ under the License.
<version>${project.version}</version>
<type>test-jar</type>
</dependency>
+
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-base</artifactId>
+ <version>${project.version}</version>
+ <scope>test</scope>
Review comment:
should be unnecessary since flink-dist will provide it
##########
File path: flink-end-to-end-tests/flink-confluent-schema-registry/pom.xml
##########
@@ -53,6 +53,11 @@ under the License.
<artifactId>flink-connector-kafka</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-base</artifactId>
Review comment:
This shouldn't be necessary as flink-dist should provide it.
##########
File path: flink-end-to-end-tests/flink-quickstart-test/pom.xml
##########
@@ -37,6 +37,11 @@ under the License.
<artifactId>flink-quickstart-java</artifactId>
<version>${project.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-base</artifactId>
Review comment:
should be unnecessary since flink-dist will provide it
##########
File path: flink-formats/flink-avro/pom.xml
##########
@@ -92,6 +92,13 @@ under the License.
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-base</artifactId>
Review comment:
add comment who needs this (connector-files again?)
##########
File path: flink-connectors/flink-connector-elasticsearch7/pom.xml
##########
@@ -100,6 +100,13 @@ under the License.
<!-- Tests -->
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-base</artifactId>
Review comment:
add a comment that this is required by elasticsearch-base. (as is it could probably be detected as unused)
##########
File path: flink-quickstart/flink-quickstart-java/src/main/resources/archetype-resources/pom.xml
##########
@@ -78,6 +78,12 @@ under the License.
</dependency>
-->
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-base</artifactId>
Review comment:
This should be incorrect; as is it would be bundled in the user-jar.
This also shows the annoying side of this change. If a user wants to run things in the IDE/tests they now have to add another dependency to their poms (which they have no way of figuring out).
##########
File path: flink-formats/flink-json/pom.xml
##########
@@ -77,6 +77,13 @@ under the License.
<!-- test dependencies -->
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-base</artifactId>
Review comment:
same as above
##########
File path: flink-formats/flink-csv/pom.xml
##########
@@ -76,6 +76,12 @@ under the License.
</dependency>
<!-- test dependencies -->
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-connector-base</artifactId>
Review comment:
same comment as for avro
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org