You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by wcl14 <gi...@git.apache.org> on 2016/09/01 01:29:37 UTC
[GitHub] incubator-hawq pull request #880: HAWQ-1037. Modify way to get HDFS port in ...
GitHub user wcl14 opened a pull request:
https://github.com/apache/incubator-hawq/pull/880
HAWQ-1037. Modify way to get HDFS port in TestHawqRegister
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wcl14/incubator-hawq HAWQ-1037
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/880.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #880
----
commit caaace3cb340dbeb41da1eaed02f0aa5152c0b38
Author: Chunling Wang <wa...@126.com>
Date: 2016-08-31T10:19:05Z
HAWQ-1037. Modify way to get HDFS port in TestHawqRegister
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #880: HAWQ-1037. Modify way to get HDFS port in TestHaw...
Posted by wengyanqing <gi...@git.apache.org>.
Github user wengyanqing commented on the issue:
https://github.com/apache/incubator-hawq/pull/880
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #880: HAWQ-1037. Modify way to get HDFS port in TestHaw...
Posted by amyrazz44 <gi...@git.apache.org>.
Github user amyrazz44 commented on the issue:
https://github.com/apache/incubator-hawq/pull/880
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #880: HAWQ-1037. Modify way to get HDFS port in ...
Posted by wcl14 <gi...@git.apache.org>.
Github user wcl14 closed the pull request at:
https://github.com/apache/incubator-hawq/pull/880
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #880: HAWQ-1037. Modify way to get HDFS port in ...
Posted by ictmalili <gi...@git.apache.org>.
Github user ictmalili commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/880#discussion_r77279779
--- Diff: src/test/feature/ManagementTool/test_hawq_register.cpp ---
@@ -3,18 +3,36 @@
#include "lib/command.h"
#include "lib/sql_util.h"
#include "lib/string_util.h"
+#include "lib/hdfs_config.h"
#include "gtest/gtest.h"
using std::string;
using hawq::test::SQLUtility;
using hawq::test::Command;
+using hawq::test::HdfsConfig;
/* This test suite may consume more than 80 seconds. */
class TestHawqRegister : public ::testing::Test {
public:
TestHawqRegister() {}
~TestHawqRegister() {}
+ string getHdfsLocation() {
+ HdfsConfig hc;
+ string hostname = "";
+ int port = 0;
+ if (hc.isHA()) {
+ hc.getActiveNamenode(hostname, port);
--- End diff --
Will this work? Shouldn't pass the pointer? If the params are modified inside function getActiveNamenode, I don't think they will be modified after the function exists. Your thought?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---