You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/05/17 02:32:55 UTC

[GitHub] [spark] zhengruifeng commented on pull request #36547: [SPARK-39197][PYTHON] Implement `skipna` parameter of `GroupBy.all`

zhengruifeng commented on PR #36547:
URL: https://github.com/apache/spark/pull/36547#issuecomment-1128336669

   +1 for what @ueshin @Yikun commented.
   
   > The only potential issue I can imagine, we have to use builtins.set when we want to call the built-in func under the same namespace
   
   we may simply follow this https://github.com/apache/spark/blob/master/python/pyspark/pandas/series.py#L353-L354


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org