You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jena.apache.org by an...@apache.org on 2015/11/14 15:42:19 UTC
[11/13] jena git commit: JENA-624 : Clean warnings
JENA-624 : Clean warnings
Project: http://git-wip-us.apache.org/repos/asf/jena/repo
Commit: http://git-wip-us.apache.org/repos/asf/jena/commit/5b6a5fe8
Tree: http://git-wip-us.apache.org/repos/asf/jena/tree/5b6a5fe8
Diff: http://git-wip-us.apache.org/repos/asf/jena/diff/5b6a5fe8
Branch: refs/heads/master
Commit: 5b6a5fe8280b4e97c14bb40258df7256bb2c56c1
Parents: 519a8df
Author: Andy Seaborne <an...@apache.org>
Authored: Sat Nov 14 12:07:30 2015 +0000
Committer: Andy Seaborne <an...@apache.org>
Committed: Sat Nov 14 12:07:30 2015 +0000
----------------------------------------------------------------------
.../org/apache/jena/sparql/core/mem/DatasetGraphInMemory.java | 4 ++--
.../main/java/org/apache/jena/sparql/core/mem/PMapQuadTable.java | 3 ++-
.../java/org/apache/jena/sparql/core/mem/PMapTripleTable.java | 3 ++-
.../java/org/apache/jena/sparql/core/mem/PMapTupleTable.java | 2 +-
.../sparql/core/journaling/TestListBackedOperationRecord.java | 4 ++--
5 files changed, 9 insertions(+), 7 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jena/blob/5b6a5fe8/jena-arq/src/main/java/org/apache/jena/sparql/core/mem/DatasetGraphInMemory.java
----------------------------------------------------------------------
diff --git a/jena-arq/src/main/java/org/apache/jena/sparql/core/mem/DatasetGraphInMemory.java b/jena-arq/src/main/java/org/apache/jena/sparql/core/mem/DatasetGraphInMemory.java
index 47452ba..d20651f 100644
--- a/jena-arq/src/main/java/org/apache/jena/sparql/core/mem/DatasetGraphInMemory.java
+++ b/jena-arq/src/main/java/org/apache/jena/sparql/core/mem/DatasetGraphInMemory.java
@@ -192,7 +192,7 @@ public class DatasetGraphInMemory extends DatasetGraphTriplesQuads implements Tr
private Iterator<Quad> quadsFinder(final Node g, final Node s, final Node p, final Node o) {
if (isUnionGraph(g)) return findInUnionGraph(s, p, o);
return quadsIndex().find(g, s, p, o).iterator();
- };
+ }
/**
* Union graph is the merge of named graphs.
@@ -203,7 +203,7 @@ public class DatasetGraphInMemory extends DatasetGraphTriplesQuads implements Tr
private Iterator<Quad> triplesFinder(final Node s, final Node p, final Node o) {
return triples2quadsDftGraph(defaultGraph().find(s, p, o).iterator());
- };
+ }
@Override
public void setDefaultGraph(final Graph g) {
http://git-wip-us.apache.org/repos/asf/jena/blob/5b6a5fe8/jena-arq/src/main/java/org/apache/jena/sparql/core/mem/PMapQuadTable.java
----------------------------------------------------------------------
diff --git a/jena-arq/src/main/java/org/apache/jena/sparql/core/mem/PMapQuadTable.java b/jena-arq/src/main/java/org/apache/jena/sparql/core/mem/PMapQuadTable.java
index 28685ee..db2a7a4 100644
--- a/jena-arq/src/main/java/org/apache/jena/sparql/core/mem/PMapQuadTable.java
+++ b/jena-arq/src/main/java/org/apache/jena/sparql/core/mem/PMapQuadTable.java
@@ -69,7 +69,8 @@ public abstract class PMapQuadTable extends PMapTupleTable<FourTupleMap, Quad>im
* @param fourth the value in the fourth slot of the tuple
* @return a <code>Stream</code> of tuples matching the pattern
*/
- protected Stream<Quad> _find(final Node first, final Node second, final Node third, final Node fourth) {
+ @SuppressWarnings("unchecked") // Because of (Stream<Quad>) -- but why is that needed?
+ protected Stream<Quad> _find(final Node first, final Node second, final Node third, final Node fourth) {
debug("Querying on four-tuple pattern: {} {} {} {} .", first, second, third, fourth);
final FourTupleMap fourTuples = local().get();
if (isConcrete(first)) {
http://git-wip-us.apache.org/repos/asf/jena/blob/5b6a5fe8/jena-arq/src/main/java/org/apache/jena/sparql/core/mem/PMapTripleTable.java
----------------------------------------------------------------------
diff --git a/jena-arq/src/main/java/org/apache/jena/sparql/core/mem/PMapTripleTable.java b/jena-arq/src/main/java/org/apache/jena/sparql/core/mem/PMapTripleTable.java
index 916f7de..85460c8 100644
--- a/jena-arq/src/main/java/org/apache/jena/sparql/core/mem/PMapTripleTable.java
+++ b/jena-arq/src/main/java/org/apache/jena/sparql/core/mem/PMapTripleTable.java
@@ -66,7 +66,8 @@ public abstract class PMapTripleTable extends PMapTupleTable<ThreeTupleMap, Trip
* @param third the value in the third slot of the tuple
* @return a <code>Stream</code> of tuples matching the pattern
*/
- public Stream<Triple> _find(final Node first, final Node second, final Node third) {
+ @SuppressWarnings("unchecked") // Because of (Stream<Triple>) -- but why is that needed?
+ public Stream<Triple> _find(final Node first, final Node second, final Node third) {
debug("Querying on three-tuple pattern: {} {} {} .", first, second, third);
final ThreeTupleMap threeTuples = local().get();
if (isConcrete(first)) {
http://git-wip-us.apache.org/repos/asf/jena/blob/5b6a5fe8/jena-arq/src/main/java/org/apache/jena/sparql/core/mem/PMapTupleTable.java
----------------------------------------------------------------------
diff --git a/jena-arq/src/main/java/org/apache/jena/sparql/core/mem/PMapTupleTable.java b/jena-arq/src/main/java/org/apache/jena/sparql/core/mem/PMapTupleTable.java
index db00dbf..e5feb49 100644
--- a/jena-arq/src/main/java/org/apache/jena/sparql/core/mem/PMapTupleTable.java
+++ b/jena-arq/src/main/java/org/apache/jena/sparql/core/mem/PMapTupleTable.java
@@ -66,7 +66,7 @@ public abstract class PMapTupleTable<TupleMapType, TupleType> implements TupleTa
@Override
public boolean isInTransaction() {
return isInTransaction.get();
- };
+ }
protected void isInTransaction(final boolean b) {
isInTransaction.set(b);
http://git-wip-us.apache.org/repos/asf/jena/blob/5b6a5fe8/jena-arq/src/test/java/org/apache/jena/sparql/core/journaling/TestListBackedOperationRecord.java
----------------------------------------------------------------------
diff --git a/jena-arq/src/test/java/org/apache/jena/sparql/core/journaling/TestListBackedOperationRecord.java b/jena-arq/src/test/java/org/apache/jena/sparql/core/journaling/TestListBackedOperationRecord.java
index 25e8f72..d2e9d40 100644
--- a/jena-arq/src/test/java/org/apache/jena/sparql/core/journaling/TestListBackedOperationRecord.java
+++ b/jena-arq/src/test/java/org/apache/jena/sparql/core/journaling/TestListBackedOperationRecord.java
@@ -71,7 +71,7 @@ public class TestListBackedOperationRecord extends Assert {
@Test
public void testConsume() {
- class MarkerException extends RuntimeException {};
+ class MarkerException extends RuntimeException {}
ListBackedOperationRecord<MockOp> testRecord = new ListBackedOperationRecord<>(ops);
testRecord.consume(op -> {}); // /dev/null
assertTrue(ops.isEmpty());
@@ -97,7 +97,7 @@ public class TestListBackedOperationRecord extends Assert {
try {
testRecord.consume(MockOp::inverse);
fail("Should not have been able to consume the last op!");
- } catch (@SuppressWarnings("unused") final MarkerException e) {
+ } catch (MarkerException e) {
// should be one op left
assertEquals(1, ops.size());
// and it should be mockOp3