[jira] [Resolved] (YUNIKORN-2413) Variables that are initialisms or acronyms should have a consistent case

["Wilfred Spiegelenburg (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/YUNIKORN-2413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Wilfred Spiegelenburg resolved YUNIKORN-2413.
---------------------------------------------
    Fix Version/s: 1.5.0
       Resolution: Fixed

Two refactors left for later: function names should be updated:

[{{{}master{}}}/pkg/events/event_ringbuffer.go#L206|https://github.com/apache/yunikorn-core/blob/master/pkg/events/event_ringbuffer.go?rgh-link-date=2024-02-19T17%3A21%3A31Z#L206]
[{{{}master{}}}/pkg/log/logger_test.go#L38|https://github.com/apache/yunikorn-core/blob/master/pkg/log/logger_test.go?rgh-link-date=2024-02-19T17%3A21%3A31Z#L38]

thank you [~priyansh] 

> Variables that are initialisms or acronyms should have a consistent case
> ------------------------------------------------------------------------
>
>                 Key: YUNIKORN-2413
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-2413
>             Project: Apache YuniKorn
>          Issue Type: Improvement
>            Reporter: Ryan Lo
>            Assignee: Priyansh Choudhary
>            Priority: Major
>              Labels: newbie, pull-request-available
>             Fix For: 1.5.0
>
>
> Discussed in YUNIKORN-2405
> We mixed up "Id" and "ID" in our code base, and it's better to standardize the use of acronyms and initialisms according to [this doc.|https://go.dev/wiki/CodeReviewComments#initialisms]
> An example:
> current: allocationId
> taget: allocationID



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org