[GitHub] [incubator-tvm] mwillsey opened a new pull request #6114: [Rust] Clean up conversions between TVM and Rust functions

[GitBox <gi...@apache.org>]

mwillsey opened a new pull request #6114:
URL: https://github.com/apache/incubator-tvm/pull/6114


   This PR cleans up conversions between TVM's `Function` and Rust functions.
   
   The `ToBoxedFn` trait is removed entirely, replaced by standard `From` implementations.
   The `ToFunction` and `Typed` traits have more logic, so they stay, but I've added the following: 
   - Remove some cloning
   - Don't panic if number of args is wrong, return an error
   - Actually drop functions/closures on the rust side
   
   I've also macro-ified some impls to make them easier to maintain, and I've added some tests to the function conversion logic that checks error handling.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] jroesch merged pull request #6114: [Rust] Clean up conversions between TVM and Rust functions

[GitBox <gi...@apache.org>]

jroesch merged pull request #6114:
URL: https://github.com/apache/incubator-tvm/pull/6114


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org