[GitHub] [spark] cloud-fan commented on a change in pull request #30687: [SPARK-33723][SQL] ANSI mode: Casting String to Date should throw exception on parse error

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #30687:
URL: https://github.com/apache/spark/pull/30687#discussion_r539947007



##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
##########
@@ -984,6 +984,30 @@ abstract class AnsiCastSuiteBase extends CastSuiteBase {
     }
   }
 
+  test("ANSI mode: cast string to date with parse error") {
+    val activeConf = conf
+    new ParVector(ALL_TIMEZONES.toVector).foreach { zid =>

Review comment:
       +1




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org