You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by "jay vyas (JIRA)" <ji...@apache.org> on 2014/12/14 04:37:13 UTC
[jira] [Commented] (BIGTOP-1273) BigPetStore: Cleanup formatting.
[ https://issues.apache.org/jira/browse/BIGTOP-1273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14245799#comment-14245799 ]
jay vyas commented on BIGTOP-1273:
----------------------------------
[~rnowling] https://gist.github.com/jayunit100/c926562d09ae00df8fe7 <-- does this look like a reasonable cleanup to the spark data generator?
- uses map operation instead of mutable list
- some comments
- imported JavaConversions_ so that we don't have to write a for loop in scala (which as you mentioned is pretty hard to do :))
> BigPetStore: Cleanup formatting.
> ---------------------------------
>
> Key: BIGTOP-1273
> URL: https://issues.apache.org/jira/browse/BIGTOP-1273
> Project: Bigtop
> Issue Type: Improvement
> Components: blueprints
> Reporter: jay vyas
> Fix For: backlog
>
>
> Lets clean up the formatting according to whats been outlined in BIGTOP-1240.
> - mark non-production code accordingly
> - imrpove any obvious typos etc
> - delete dead code
> - run formatting against
> In the process I think we can put in some light improvement of docs / READMEs where necessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)