You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/23 18:42:40 UTC

[GitHub] [pulsar] michaeljmarshall commented on pull request #12104: [PIP 97] Update Authentication Interfaces to Include Async Authentication Methods

michaeljmarshall commented on pull request #12104:
URL: https://github.com/apache/pulsar/pull/12104#issuecomment-926063477


   > It looks like the method implementation here is still synchronous. Or are you planning to implement asynchronous in another PR?
   
   I address this concern in the PR description. All current implementations of the `AuthenticationProvider` interface should be non-blocking, otherwise they are already blocking IO threads. The default implementation of `authenticateAsync` preserves the current behavior for all implementations. Further, my proposed design expects implementations to manage their own concurrency model. The Javadoc states this design decision.
   
   I will submit subsequent PRs for each of the Pulsar authentication provider implementations to ensure that they remove implementations of the deprecated methods.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org