You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/07/28 08:13:15 UTC

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1121: MINIFICPP-1596 Refactor docker tests by removing unnecessary clusters

lordgamez commented on a change in pull request #1121:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1121#discussion_r678076530



##########
File path: docker/test/integration/features/kafka.feature
##########
@@ -53,7 +53,7 @@ Feature: Sending data to using Kafka streaming platform using PublishKafka
     And the "success" relationship of the GetFile processor is connected to the PublishKafka
     And the "success" relationship of the GetFile processor is connected to the PutFile
 
-    And a kafka broker "broker" is set up in correspondence with the PublishKafka
+    And a kafka broker is set up in correspondence with the PublishKafka

Review comment:
       Awesome catch, thanks! This test wasn't even working properly having wrong properties and succeeding without using the `PublishKafka` processors. Fixed it in 80822158e9be7be0c284436fed00b70b37f0ed54




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org