You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/09/28 13:32:13 UTC
[GitHub] [incubator-devlake] warren830 opened a new pull request, #3230: Feat plugin coding init
warren830 opened a new pull request, #3230:
URL: https://github.com/apache/incubator-devlake/pull/3230
# Summary
add coding plugin
### Does this close any open issues?
Closes xx
### Screenshots
### Other Information
Any other information that is important to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] warren830 merged pull request #3230: Feat plugin coding init
Posted by GitBox <gi...@apache.org>.
warren830 merged PR #3230:
URL: https://github.com/apache/incubator-devlake/pull/3230
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake] warren830 commented on a diff in pull request #3230: Feat plugin coding init
Posted by GitBox <gi...@apache.org>.
warren830 commented on code in PR #3230:
URL: https://github.com/apache/incubator-devlake/pull/3230#discussion_r991918546
##########
plugins/helper/api_collector.go:
##########
@@ -335,6 +337,13 @@ func (collector *ApiCollector) fetchAsync(reqData *RequestData, handler func(int
panic(err)
}
}
+ var reqBody interface{}
+ if collector.args.RequestBody != nil {
+ reqBody = collector.args.RequestBody(reqData)
+ if err != nil {
Review Comment:
haha, my bad, there is no err here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org