You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2019/03/18 16:32:31 UTC

[kudu-CR] [build] Make Gradle download URLs configurable 

Hello Grant Henke,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/12775

to review the following change.


Change subject: [build] Make Gradle download URLs configurable
......................................................................

[build] Make Gradle download URLs configurable

Make the Gradle and Gradle Wrapper download URLs configurable from
gradle.peroperties so it can be changed to a mirror if needed in an
internal network behind a firewall.

Change-Id: I9317d8a84ccf788892163de1d89999e7749fdb34
---
M java/build.gradle
M java/gradle.properties
M java/gradle/wrapper.gradle
3 files changed, 9 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/12775/1
-- 
To view, visit http://gerrit.cloudera.org:8080/12775
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9317d8a84ccf788892163de1d89999e7749fdb34
Gerrit-Change-Number: 12775
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>

[kudu-CR] [build] Make Gradle download URLs configurable

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12775

to look at the new patch set (#3).

Change subject: [build] Make Gradle download URLs configurable
......................................................................

[build] Make Gradle download URLs configurable

Make the Gradle and Gradle Wrapper download URLs configurable from
gradle.peroperties so it can be changed to a mirror if needed in an
internal network behind a firewall.

Change-Id: I9317d8a84ccf788892163de1d89999e7749fdb34
---
M java/build.gradle
M java/gradle.properties
M java/gradle/wrapper.gradle
3 files changed, 14 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/12775/3
-- 
To view, visit http://gerrit.cloudera.org:8080/12775
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9317d8a84ccf788892163de1d89999e7749fdb34
Gerrit-Change-Number: 12775
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [build] Make Gradle download URLs configurable

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/12775 )

Change subject: [build] Make Gradle download URLs configurable
......................................................................


Patch Set 5:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/12775/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/12775/2//COMMIT_MSG@10
PS2, Line 10: hey
> they
Done


http://gerrit.cloudera.org:8080/#/c/12775/2//COMMIT_MSG@10
PS2, Line 10: properties 
> properties
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/12775
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9317d8a84ccf788892163de1d89999e7749fdb34
Gerrit-Change-Number: 12775
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 18 Mar 2019 22:17:47 +0000
Gerrit-HasComments: Yes

[kudu-CR] [build] Make Gradle download URLs configurable

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12775

to look at the new patch set (#4).

Change subject: [build] Make Gradle download URLs configurable
......................................................................

[build] Make Gradle download URLs configurable

Make the Gradle and Gradle Wrapper download URLs configurable from
gradle.peroperties so it can be changed to a mirror if needed in an
internal network behind a firewall.

Change-Id: I9317d8a84ccf788892163de1d89999e7749fdb34
---
M java/build.gradle
M java/gradle.properties
M java/gradle/wrapper.gradle
M java/gradlew
4 files changed, 14 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/12775/4
-- 
To view, visit http://gerrit.cloudera.org:8080/12775
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9317d8a84ccf788892163de1d89999e7749fdb34
Gerrit-Change-Number: 12775
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [build] Make Gradle download URLs configurable

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12775

to look at the new patch set (#5).

Change subject: [build] Make Gradle download URLs configurable
......................................................................

[build] Make Gradle download URLs configurable

Make the Gradle and Gradle Wrapper download URLs configurable from
gradle.properties so they can be changed to a mirror if needed in an
internal network behind a firewall.

Change-Id: I9317d8a84ccf788892163de1d89999e7749fdb34
---
M java/build.gradle
M java/gradle.properties
M java/gradle/wrapper.gradle
M java/gradlew
4 files changed, 14 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/12775/5
-- 
To view, visit http://gerrit.cloudera.org:8080/12775
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9317d8a84ccf788892163de1d89999e7749fdb34
Gerrit-Change-Number: 12775
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [build] Make Gradle download URLs configurable

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12775 )

Change subject: [build] Make Gradle download URLs configurable
......................................................................

[build] Make Gradle download URLs configurable

Make the Gradle and Gradle Wrapper download URLs configurable from
gradle.properties so they can be changed to a mirror if needed in an
internal network behind a firewall.

Change-Id: I9317d8a84ccf788892163de1d89999e7749fdb34
Reviewed-on: http://gerrit.cloudera.org:8080/12775
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Kudu Jenkins
---
M java/build.gradle
M java/gradle.properties
M java/gradle/wrapper.gradle
M java/gradlew
4 files changed, 14 insertions(+), 8 deletions(-)

Approvals:
  Grant Henke: Looks good to me, approved
  Kudu Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/12775
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9317d8a84ccf788892163de1d89999e7749fdb34
Gerrit-Change-Number: 12775
Gerrit-PatchSet: 6
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [build] Make Gradle download URLs configurable

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/12775

to look at the new patch set (#2).

Change subject: [build] Make Gradle download URLs configurable
......................................................................

[build] Make Gradle download URLs configurable

Make the Gradle and Gradle Wrapper download URLs configurable from
gradle.peroperties so it can be changed to a mirror if needed in an
internal network behind a firewall.

Change-Id: I9317d8a84ccf788892163de1d89999e7749fdb34
---
M java/build.gradle
M java/gradle.properties
M java/gradle/wrapper.gradle
3 files changed, 14 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/75/12775/2
-- 
To view, visit http://gerrit.cloudera.org:8080/12775
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9317d8a84ccf788892163de1d89999e7749fdb34
Gerrit-Change-Number: 12775
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)

[kudu-CR] [build] Make Gradle download URLs configurable

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12775 )

Change subject: [build] Make Gradle download URLs configurable
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/12775
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9317d8a84ccf788892163de1d89999e7749fdb34
Gerrit-Change-Number: 12775
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 18 Mar 2019 22:20:48 +0000
Gerrit-HasComments: No

[kudu-CR] [build] Make Gradle download URLs configurable

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12775 )

Change subject: [build] Make Gradle download URLs configurable
......................................................................


Patch Set 2:

(1 comment)

You should run `gradle wrapper` with all your changes and checking the changes to `gradlew` and `gradle-wrapper.properties`.

http://gerrit.cloudera.org:8080/#/c/12775/2/java/gradle/wrapper.gradle
File java/gradle/wrapper.gradle:

http://gerrit.cloudera.org:8080/#/c/12775/2/java/gradle/wrapper.gradle@60
PS2, Line 60:     def wrapperBaseUrl = String.format(gradleWrapperUrl, fullVersion)
I don't think you need the format with the version now. You also don't need to append `/gradle-wrapper.jar` below.



-- 
To view, visit http://gerrit.cloudera.org:8080/12775
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9317d8a84ccf788892163de1d89999e7749fdb34
Gerrit-Change-Number: 12775
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 18 Mar 2019 21:41:59 +0000
Gerrit-HasComments: Yes

[kudu-CR] [build] Make Gradle download URLs configurable

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12775 )

Change subject: [build] Make Gradle download URLs configurable
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/12775/1/java/build.gradle
File java/build.gradle:

http://gerrit.cloudera.org:8080/#/c/12775/1/java/build.gradle@101
PS1, Line 101:   distributionUrl = "${gradleDistUrlBase}/gradle-${versions.gradle}-all.zip"
This line should be added to the wrapper task in wrapper.gradle.


http://gerrit.cloudera.org:8080/#/c/12775/1/java/gradle.properties
File java/gradle.properties:

http://gerrit.cloudera.org:8080/#/c/12775/1/java/gradle.properties@63
PS1, Line 63: gradleWrapperUrl = https://raw.githubusercontent.com/gradle/gradle/v%s/gradle/wrapper
Can you add a comment that these are used in the `gradle wrapper` task to generate `gradlew` and the `wrapper/gradle-wrapper.properties`?


http://gerrit.cloudera.org:8080/#/c/12775/1/java/gradle/wrapper.gradle
File java/gradle/wrapper.gradle:

http://gerrit.cloudera.org:8080/#/c/12775/1/java/gradle/wrapper.gradle@59
PS1, Line 59:     def wrapperBaseUrl = String.format(gradleWrapperUrl, fullVersion)
Interestingly the version of the gradle jar isn't really important. Instead of this, we can put the full url in the properties file. I would use the last major version:
https://raw.githubusercontent.com/gradle/gradle/v5.0.0/gradle/wrapper/gradle-wrapper.jar

Can you also move the comments from this section to the properties file.



-- 
To view, visit http://gerrit.cloudera.org:8080/12775
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9317d8a84ccf788892163de1d89999e7749fdb34
Gerrit-Change-Number: 12775
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 18 Mar 2019 16:41:23 +0000
Gerrit-HasComments: Yes

[kudu-CR] [build] Make Gradle download URLs configurable

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12775 )

Change subject: [build] Make Gradle download URLs configurable
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/12775/2//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/12775/2//COMMIT_MSG@10
PS2, Line 10: peroperties
properties


http://gerrit.cloudera.org:8080/#/c/12775/2//COMMIT_MSG@10
PS2, Line 10: it 
they



-- 
To view, visit http://gerrit.cloudera.org:8080/12775
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9317d8a84ccf788892163de1d89999e7749fdb34
Gerrit-Change-Number: 12775
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 18 Mar 2019 22:13:40 +0000
Gerrit-HasComments: Yes

[kudu-CR] [build] Make Gradle download URLs configurable

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/12775 )

Change subject: [build] Make Gradle download URLs configurable
......................................................................


Patch Set 2:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/12775/1/java/build.gradle
File java/build.gradle:

http://gerrit.cloudera.org:8080/#/c/12775/1/java/build.gradle@101
PS1, Line 101: 
> This line should be added to the wrapper task in wrapper.gradle.
Done


http://gerrit.cloudera.org:8080/#/c/12775/1/java/gradle.properties
File java/gradle.properties:

http://gerrit.cloudera.org:8080/#/c/12775/1/java/gradle.properties@63
PS1, Line 63: # The below parameters are used in the `gradle wrapper` to generate `gradlew`
> Can you add a comment that these are used in the `gradle wrapper` task to g
Done


http://gerrit.cloudera.org:8080/#/c/12775/1/java/gradle/wrapper.gradle
File java/gradle/wrapper.gradle:

http://gerrit.cloudera.org:8080/#/c/12775/1/java/gradle/wrapper.gradle@59
PS1, Line 59:     // fetch the jar.
> Interestingly the version of the gradle jar isn't really important. Instead
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/12775
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9317d8a84ccf788892163de1d89999e7749fdb34
Gerrit-Change-Number: 12775
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 18 Mar 2019 17:57:40 +0000
Gerrit-HasComments: Yes