[GitHub] [spark] Hisoka-X commented on a diff in pull request #41779: [SPARK-44236][SQL] Disable WholeStageCodegen when set `spark.sql.codegen.factoryMode` to NO_CODEGEN

["Hisoka-X (via GitHub)" <gi...@apache.org>]

Hisoka-X commented on code in PR #41779:
URL: https://github.com/apache/spark/pull/41779#discussion_r1246262051


##########
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/plans/PlanTest.scala:
##########
@@ -47,8 +47,7 @@ trait CodegenInterpretedPlanTest extends PlanTest {
     super.test(testName + " (codegen path)", testTags: _*)(
       withSQLConf(SQLConf.CODEGEN_FACTORY_MODE.key -> codegenMode) { testFun })(pos)
     super.test(testName + " (interpreted path)", testTags: _*)(
-      withSQLConf(SQLConf.CODEGEN_FACTORY_MODE.key -> interpretedMode) {
-        withSQLConf(SQLConf.WHOLESTAGE_CODEGEN_ENABLED.key -> "false") { testFun }})(pos)
+      withSQLConf(SQLConf.CODEGEN_FACTORY_MODE.key -> interpretedMode) {{ testFun }})(pos)

Review Comment:
   > Sorry, I didn't get why you reverted https://github.com/apache/spark/pull/41467
   
   If when we support set `spark.sql.codegen.factoryMode` to `NO_CODEGEN` then disable WholeStageCodegen in this PR(just like set WHOLESTAGE_CODEGEN_ENABLED to false). The change seem unnecessary. This idea come from I collect other codegen config mistakes. The `NO_CODEGEN` behavior not right at now.
   
   > why do you need double curly brackets.
   
   My mistake, I will fix it. Thanks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org