You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2017/09/27 21:50:04 UTC
Re: Review Request 62616: Binary packaging for Centos 7.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62616/
-----------------------------------------------------------
(Updated Sept. 27, 2017, 5:50 p.m.)
Review request for mesos, Benno Evers, Till Toenshoff, and Vinod Kone.
Changes
-------
Removed unused build.sh files.
Summary (updated)
-----------------
Binary packaging for Centos 7.
Bugs: MESOS-7982
https://issues.apache.org/jira/browse/MESOS-7982
Repository: mesos
Description (updated)
-------
Binary packaging for Centos 7.
Diffs (updated)
-----
support/packaging/Jenkinsfile PRE-CREATION
support/packaging/centos/6/Dockerfile PRE-CREATION
support/packaging/centos/6/mesos.spec PRE-CREATION
support/packaging/centos/7/Dockerfile PRE-CREATION
support/packaging/centos/7/mesos.spec PRE-CREATION
support/packaging/common/mesos PRE-CREATION
support/packaging/common/mesos-init-wrapper PRE-CREATION
support/packaging/common/mesos-master PRE-CREATION
support/packaging/common/mesos-master.service PRE-CREATION
support/packaging/common/mesos-master.upstart PRE-CREATION
support/packaging/common/mesos-slave PRE-CREATION
support/packaging/common/mesos-slave.service PRE-CREATION
support/packaging/common/mesos-slave.upstart PRE-CREATION
Diff: https://reviews.apache.org/r/62616/diff/2/
Changes: https://reviews.apache.org/r/62616/diff/1-2/
Testing
-------
The scripts have been tested on an internal Jenkins CI. A buildjob on ASF Jenkins CI is available at https://builds.apache.org/job/Mesos/job/Packaging/job/CentosRPMs/.
Thanks,
Kapil Arya
Re: Review Request 62616: Binary packaging for Centos 7.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62616/#review187380
-----------------------------------------------------------
support/packaging/centos/7/mesos.spec
Lines 54 (patched)
<https://reviews.apache.org/r/62616/#comment264348>
Why 2 `enable-optimize` here?
- Jie Yu
On Sept. 27, 2017, 9:50 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62616/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2017, 9:50 p.m.)
>
>
> Review request for mesos, Benno Evers, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7982
> https://issues.apache.org/jira/browse/MESOS-7982
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Binary packaging for Centos 7.
>
>
> Diffs
> -----
>
> support/packaging/Jenkinsfile PRE-CREATION
> support/packaging/centos/6/Dockerfile PRE-CREATION
> support/packaging/centos/6/mesos.spec PRE-CREATION
> support/packaging/centos/7/Dockerfile PRE-CREATION
> support/packaging/centos/7/mesos.spec PRE-CREATION
> support/packaging/common/mesos PRE-CREATION
> support/packaging/common/mesos-init-wrapper PRE-CREATION
> support/packaging/common/mesos-master PRE-CREATION
> support/packaging/common/mesos-master.service PRE-CREATION
> support/packaging/common/mesos-master.upstart PRE-CREATION
> support/packaging/common/mesos-slave PRE-CREATION
> support/packaging/common/mesos-slave.service PRE-CREATION
> support/packaging/common/mesos-slave.upstart PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/62616/diff/2/
>
>
> Testing
> -------
>
> The scripts have been tested on an internal Jenkins CI. A buildjob on ASF Jenkins CI is available at https://builds.apache.org/job/Mesos/job/Packaging/job/CentosRPMs/.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 62616: Binary packaging for Centos 7.
Posted by Jie Yu <yu...@gmail.com>.
> On Oct. 3, 2017, 4:54 p.m., James Peach wrote:
> > support/packaging/centos/6/mesos.spec
> > Lines 56 (patched)
> > <https://reviews.apache.org/r/62616/diff/2/?file=1837906#file1837906line56>
> >
> > ```
> > --enable-hardening \
> > --enable-port-mapping-isolator \
> > --enable-xfs-disk-isolator \
> > ```
I believe we cannot `--enable-port-mapping-isolator` for centos6/7 due to the kernel version requirement and libnl version restriction. We can enable that in Fedora 23 and up, or ubuntu 16 and up.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62616/#review186959
-----------------------------------------------------------
On Sept. 27, 2017, 9:50 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62616/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2017, 9:50 p.m.)
>
>
> Review request for mesos, Benno Evers, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7982
> https://issues.apache.org/jira/browse/MESOS-7982
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Binary packaging for Centos 7.
>
>
> Diffs
> -----
>
> support/packaging/Jenkinsfile PRE-CREATION
> support/packaging/centos/6/Dockerfile PRE-CREATION
> support/packaging/centos/6/mesos.spec PRE-CREATION
> support/packaging/centos/7/Dockerfile PRE-CREATION
> support/packaging/centos/7/mesos.spec PRE-CREATION
> support/packaging/common/mesos PRE-CREATION
> support/packaging/common/mesos-init-wrapper PRE-CREATION
> support/packaging/common/mesos-master PRE-CREATION
> support/packaging/common/mesos-master.service PRE-CREATION
> support/packaging/common/mesos-master.upstart PRE-CREATION
> support/packaging/common/mesos-slave PRE-CREATION
> support/packaging/common/mesos-slave.service PRE-CREATION
> support/packaging/common/mesos-slave.upstart PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/62616/diff/2/
>
>
> Testing
> -------
>
> The scripts have been tested on an internal Jenkins CI. A buildjob on ASF Jenkins CI is available at https://builds.apache.org/job/Mesos/job/Packaging/job/CentosRPMs/.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 62616: Binary packaging for Centos 7.
Posted by Kapil Arya <ka...@mesosphere.io>.
> On Oct. 3, 2017, 12:54 p.m., James Peach wrote:
> > I accidentally made most of my comments on the CentOS6 spec file, but they apply to the CentOS7 one too. I'm not sure how tractable it is to use the same spec file for both platforms, but combining them would be helpful if you can make the RPM conditionals work for you.
> >
> > Finally, since I think this is intended to be a general-purpose package, we should enable all the optional compile-time features to broaden the set of users who can consume these packages.
Thanks for the tips, James! I have now addressed most of your issues and have added some response for the others. Please take a look and let me know if we can make it better.
- Kapil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62616/#review186959
-----------------------------------------------------------
On Oct. 13, 2017, 2:02 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62616/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2017, 2:02 p.m.)
>
>
> Review request for mesos, Benno Evers, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7982
> https://issues.apache.org/jira/browse/MESOS-7982
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Binary packaging for Centos 7.
>
>
> Diffs
> -----
>
> support/packaging/Jenkinsfile PRE-CREATION
> support/packaging/centos/build_rpm.sh PRE-CREATION
> support/packaging/centos/centos6.dockerfile PRE-CREATION
> support/packaging/centos/centos7.dockerfile PRE-CREATION
> support/packaging/centos/mesos.spec PRE-CREATION
> support/packaging/common/mesos PRE-CREATION
> support/packaging/common/mesos-init-wrapper PRE-CREATION
> support/packaging/common/mesos-master PRE-CREATION
> support/packaging/common/mesos-master.service PRE-CREATION
> support/packaging/common/mesos-master.upstart PRE-CREATION
> support/packaging/common/mesos-slave PRE-CREATION
> support/packaging/common/mesos-slave.service PRE-CREATION
> support/packaging/common/mesos-slave.upstart PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/62616/diff/3/
>
>
> Testing
> -------
>
> The scripts have been tested on an internal Jenkins CI. A buildjob on ASF Jenkins CI is available at https://builds.apache.org/job/Mesos/job/Packaging/job/CentosRPMs/.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 62616: Binary packaging for Centos 7.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62616/#review186959
-----------------------------------------------------------
I accidentally made most of my comments on the CentOS6 spec file, but they apply to the CentOS7 one too. I'm not sure how tractable it is to use the same spec file for both platforms, but combining them would be helpful if you can make the RPM conditionals work for you.
Finally, since I think this is intended to be a general-purpose package, we should enable all the optional compile-time features to broaden the set of users who can consume these packages.
support/packaging/centos/6/mesos.spec
Lines 29 (patched)
<https://reviews.apache.org/r/62616/#comment263886>
Also:
``
BuildRequires: elfutils-libelf-devel
BuildRequires: libblkid-devel
BuildRequires: xfsprogs-devel
BuildRequires: cuda-minimal-build-8-0
BuildRequires: kernel-headers
BuildRequires: patch
```
support/packaging/centos/6/mesos.spec
Lines 30 (patched)
<https://reviews.apache.org/r/62616/#comment263889>
I think you need a JDK version here, and probably Maven too if you want the Java build to work.
support/packaging/centos/6/mesos.spec
Lines 33 (patched)
<https://reviews.apache.org/r/62616/#comment263897>
Don't you also need to `BuildRequires` a compiler from devtoolset?
support/packaging/centos/6/mesos.spec
Lines 39 (patched)
<https://reviews.apache.org/r/62616/#comment263899>
Not sure this is a good idea. The `ntp` or `chrony` packages would be an equally good choice.
support/packaging/centos/6/mesos.spec
Lines 51 (patched)
<https://reviews.apache.org/r/62616/#comment263890>
Put one option per line to make future changes more diffable:
```
%configure \
--enable-optimize \
...
```
support/packaging/centos/6/mesos.spec
Lines 56 (patched)
<https://reviews.apache.org/r/62616/#comment263895>
```
--enable-hardening \
--enable-port-mapping-isolator \
--enable-xfs-disk-isolator \
```
support/packaging/centos/6/mesos.spec
Lines 57 (patched)
<https://reviews.apache.org/r/62616/#comment263901>
Enable Python or Java?
support/packaging/centos/7/Dockerfile
Lines 65 (patched)
<https://reviews.apache.org/r/62616/#comment263909>
Don't install these, use [yum-builddep](https://jsmith.fedorapeople.org/drafts/SMG/html/Software_Management_Guide/ch07s05.html) to ensure that you have the `BuildDepends` correct.
support/packaging/common/mesos
Lines 2 (patched)
<https://reviews.apache.org/r/62616/#comment263906>
This seems low. Our busy clusters need at least 16K.
support/packaging/common/mesos-init-wrapper
Lines 5 (patched)
<https://reviews.apache.org/r/62616/#comment263904>
All the `slaves` should be `agents`, right?
- James Peach
On Sept. 27, 2017, 9:50 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62616/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2017, 9:50 p.m.)
>
>
> Review request for mesos, Benno Evers, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7982
> https://issues.apache.org/jira/browse/MESOS-7982
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Binary packaging for Centos 7.
>
>
> Diffs
> -----
>
> support/packaging/Jenkinsfile PRE-CREATION
> support/packaging/centos/6/Dockerfile PRE-CREATION
> support/packaging/centos/6/mesos.spec PRE-CREATION
> support/packaging/centos/7/Dockerfile PRE-CREATION
> support/packaging/centos/7/mesos.spec PRE-CREATION
> support/packaging/common/mesos PRE-CREATION
> support/packaging/common/mesos-init-wrapper PRE-CREATION
> support/packaging/common/mesos-master PRE-CREATION
> support/packaging/common/mesos-master.service PRE-CREATION
> support/packaging/common/mesos-master.upstart PRE-CREATION
> support/packaging/common/mesos-slave PRE-CREATION
> support/packaging/common/mesos-slave.service PRE-CREATION
> support/packaging/common/mesos-slave.upstart PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/62616/diff/2/
>
>
> Testing
> -------
>
> The scripts have been tested on an internal Jenkins CI. A buildjob on ASF Jenkins CI is available at https://builds.apache.org/job/Mesos/job/Packaging/job/CentosRPMs/.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 62616: Binary packaging for Centos 7.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62616/#review186958
-----------------------------------------------------------
Here are some requirements that I would love to achieve as part of this effort:
1. Build rpm on my dev machine
```# support/packaging/centos/7/build_package.sh --output <dest_dir>```
(this is one for each distribution, the output can be either RPM or Deb packages.
2. Build Docker image (for running Mesos) on my dev machine
```
# support/build_docker_image.sh --name <docker_image_name>
# docker run <docker_image_name> mesos-slave [args]
# docker run <docker_image_name> mesos-master [args]
```
If no args, the default
This image should be a minimal docker image (just a yum install). By default, it’ll build from the current head of the repo.
The flow should probably be:
1) Generate RPM in step 1
2) Setup a local yum repo.
3) Run docker build with a minimal Dockerfile (just a yum install).
Publish to docker hub if needed.
3. I want a Docker image for developing Mesos and Mesos plugins
```# support/packaging/centos/7/build_dev_docker_image.sh --name <docker_image_name>```
```
Dev Dockerfile:
FROM <docker_image_name>
RUN make check
```
Reusing the Dockerfile in Step 1. The goal is that developers can use this docker image to build Mesos plugins (e.g., their dockerfile will be based on this docker image).
Publish to docker hub if needed
- Jie Yu
On Sept. 27, 2017, 9:50 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62616/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2017, 9:50 p.m.)
>
>
> Review request for mesos, Benno Evers, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7982
> https://issues.apache.org/jira/browse/MESOS-7982
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Binary packaging for Centos 7.
>
>
> Diffs
> -----
>
> support/packaging/Jenkinsfile PRE-CREATION
> support/packaging/centos/6/Dockerfile PRE-CREATION
> support/packaging/centos/6/mesos.spec PRE-CREATION
> support/packaging/centos/7/Dockerfile PRE-CREATION
> support/packaging/centos/7/mesos.spec PRE-CREATION
> support/packaging/common/mesos PRE-CREATION
> support/packaging/common/mesos-init-wrapper PRE-CREATION
> support/packaging/common/mesos-master PRE-CREATION
> support/packaging/common/mesos-master.service PRE-CREATION
> support/packaging/common/mesos-master.upstart PRE-CREATION
> support/packaging/common/mesos-slave PRE-CREATION
> support/packaging/common/mesos-slave.service PRE-CREATION
> support/packaging/common/mesos-slave.upstart PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/62616/diff/2/
>
>
> Testing
> -------
>
> The scripts have been tested on an internal Jenkins CI. A buildjob on ASF Jenkins CI is available at https://builds.apache.org/job/Mesos/job/Packaging/job/CentosRPMs/.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 62616: Binary packaging for Centos 7.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62616/#review186504
-----------------------------------------------------------
PASS: Mesos patch 62616 was successfully built and tested.
Reviews applied: `['62616']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62616
- Mesos Reviewbot Windows
On Sept. 27, 2017, 9:50 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62616/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2017, 9:50 p.m.)
>
>
> Review request for mesos, Benno Evers, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7982
> https://issues.apache.org/jira/browse/MESOS-7982
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Binary packaging for Centos 7.
>
>
> Diffs
> -----
>
> support/packaging/Jenkinsfile PRE-CREATION
> support/packaging/centos/6/Dockerfile PRE-CREATION
> support/packaging/centos/6/mesos.spec PRE-CREATION
> support/packaging/centos/7/Dockerfile PRE-CREATION
> support/packaging/centos/7/mesos.spec PRE-CREATION
> support/packaging/common/mesos PRE-CREATION
> support/packaging/common/mesos-init-wrapper PRE-CREATION
> support/packaging/common/mesos-master PRE-CREATION
> support/packaging/common/mesos-master.service PRE-CREATION
> support/packaging/common/mesos-master.upstart PRE-CREATION
> support/packaging/common/mesos-slave PRE-CREATION
> support/packaging/common/mesos-slave.service PRE-CREATION
> support/packaging/common/mesos-slave.upstart PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/62616/diff/2/
>
>
> Testing
> -------
>
> The scripts have been tested on an internal Jenkins CI. A buildjob on ASF Jenkins CI is available at https://builds.apache.org/job/Mesos/job/Packaging/job/CentosRPMs/.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 62616: Binary packaging for Centos 7.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62616/#review187379
-----------------------------------------------------------
support/packaging/centos/7/mesos.spec
Lines 104 (patched)
<https://reviews.apache.org/r/62616/#comment264347>
Can we have a separate dev package? The goal is to minimize the size of the Mesos package if it's only intended for running Mesos.
- Jie Yu
On Sept. 27, 2017, 9:50 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62616/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2017, 9:50 p.m.)
>
>
> Review request for mesos, Benno Evers, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7982
> https://issues.apache.org/jira/browse/MESOS-7982
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Binary packaging for Centos 7.
>
>
> Diffs
> -----
>
> support/packaging/Jenkinsfile PRE-CREATION
> support/packaging/centos/6/Dockerfile PRE-CREATION
> support/packaging/centos/6/mesos.spec PRE-CREATION
> support/packaging/centos/7/Dockerfile PRE-CREATION
> support/packaging/centos/7/mesos.spec PRE-CREATION
> support/packaging/common/mesos PRE-CREATION
> support/packaging/common/mesos-init-wrapper PRE-CREATION
> support/packaging/common/mesos-master PRE-CREATION
> support/packaging/common/mesos-master.service PRE-CREATION
> support/packaging/common/mesos-master.upstart PRE-CREATION
> support/packaging/common/mesos-slave PRE-CREATION
> support/packaging/common/mesos-slave.service PRE-CREATION
> support/packaging/common/mesos-slave.upstart PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/62616/diff/2/
>
>
> Testing
> -------
>
> The scripts have been tested on an internal Jenkins CI. A buildjob on ASF Jenkins CI is available at https://builds.apache.org/job/Mesos/job/Packaging/job/CentosRPMs/.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 62616: Binary packaging for Centos 7.
Posted by Kapil Arya <ka...@mesosphere.io>.
> On Oct. 3, 2017, 12:57 p.m., James Peach wrote:
> > support/packaging/centos/7/mesos.spec
> > Lines 33 (patched)
> > <https://reviews.apache.org/r/62616/diff/2/?file=1837908#file1837908line33>
> >
> > Handling the SVN dependency is a bit quirky. If you do what you have done here, you end up building against a more recent libsubversion than the one available in the distribution. Everything will appear to work due to lazy symbol binding, but (I think) that Aurora users will use the registry diff APIs that will trigger binding for the missing symbols.
I have modified it to specify a version. Do you think it's acceptable now?
- Kapil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62616/#review186971
-----------------------------------------------------------
On Oct. 13, 2017, 2:02 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62616/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2017, 2:02 p.m.)
>
>
> Review request for mesos, Benno Evers, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7982
> https://issues.apache.org/jira/browse/MESOS-7982
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Binary packaging for Centos 7.
>
>
> Diffs
> -----
>
> support/packaging/Jenkinsfile PRE-CREATION
> support/packaging/centos/build_rpm.sh PRE-CREATION
> support/packaging/centos/centos6.dockerfile PRE-CREATION
> support/packaging/centos/centos7.dockerfile PRE-CREATION
> support/packaging/centos/mesos.spec PRE-CREATION
> support/packaging/common/mesos PRE-CREATION
> support/packaging/common/mesos-init-wrapper PRE-CREATION
> support/packaging/common/mesos-master PRE-CREATION
> support/packaging/common/mesos-master.service PRE-CREATION
> support/packaging/common/mesos-master.upstart PRE-CREATION
> support/packaging/common/mesos-slave PRE-CREATION
> support/packaging/common/mesos-slave.service PRE-CREATION
> support/packaging/common/mesos-slave.upstart PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/62616/diff/3/
>
>
> Testing
> -------
>
> The scripts have been tested on an internal Jenkins CI. A buildjob on ASF Jenkins CI is available at https://builds.apache.org/job/Mesos/job/Packaging/job/CentosRPMs/.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 62616: Binary packaging for Centos 7.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62616/#review186971
-----------------------------------------------------------
support/packaging/centos/7/mesos.spec
Lines 33 (patched)
<https://reviews.apache.org/r/62616/#comment263919>
Handling the SVN dependency is a bit quirky. If you do what you have done here, you end up building against a more recent libsubversion than the one available in the distribution. Everything will appear to work due to lazy symbol binding, but (I think) that Aurora users will use the registry diff APIs that will trigger binding for the missing symbols.
- James Peach
On Sept. 27, 2017, 9:50 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62616/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2017, 9:50 p.m.)
>
>
> Review request for mesos, Benno Evers, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7982
> https://issues.apache.org/jira/browse/MESOS-7982
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Binary packaging for Centos 7.
>
>
> Diffs
> -----
>
> support/packaging/Jenkinsfile PRE-CREATION
> support/packaging/centos/6/Dockerfile PRE-CREATION
> support/packaging/centos/6/mesos.spec PRE-CREATION
> support/packaging/centos/7/Dockerfile PRE-CREATION
> support/packaging/centos/7/mesos.spec PRE-CREATION
> support/packaging/common/mesos PRE-CREATION
> support/packaging/common/mesos-init-wrapper PRE-CREATION
> support/packaging/common/mesos-master PRE-CREATION
> support/packaging/common/mesos-master.service PRE-CREATION
> support/packaging/common/mesos-master.upstart PRE-CREATION
> support/packaging/common/mesos-slave PRE-CREATION
> support/packaging/common/mesos-slave.service PRE-CREATION
> support/packaging/common/mesos-slave.upstart PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/62616/diff/2/
>
>
> Testing
> -------
>
> The scripts have been tested on an internal Jenkins CI. A buildjob on ASF Jenkins CI is available at https://builds.apache.org/job/Mesos/job/Packaging/job/CentosRPMs/.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 62616: Binary packaging for Centos 7.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62616/#review186623
-----------------------------------------------------------
Patch looks great!
Reviews applied: [62616]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Sept. 27, 2017, 9:50 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62616/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2017, 9:50 p.m.)
>
>
> Review request for mesos, Benno Evers, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7982
> https://issues.apache.org/jira/browse/MESOS-7982
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Binary packaging for Centos 7.
>
>
> Diffs
> -----
>
> support/packaging/Jenkinsfile PRE-CREATION
> support/packaging/centos/6/Dockerfile PRE-CREATION
> support/packaging/centos/6/mesos.spec PRE-CREATION
> support/packaging/centos/7/Dockerfile PRE-CREATION
> support/packaging/centos/7/mesos.spec PRE-CREATION
> support/packaging/common/mesos PRE-CREATION
> support/packaging/common/mesos-init-wrapper PRE-CREATION
> support/packaging/common/mesos-master PRE-CREATION
> support/packaging/common/mesos-master.service PRE-CREATION
> support/packaging/common/mesos-master.upstart PRE-CREATION
> support/packaging/common/mesos-slave PRE-CREATION
> support/packaging/common/mesos-slave.service PRE-CREATION
> support/packaging/common/mesos-slave.upstart PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/62616/diff/2/
>
>
> Testing
> -------
>
> The scripts have been tested on an internal Jenkins CI. A buildjob on ASF Jenkins CI is available at https://builds.apache.org/job/Mesos/job/Packaging/job/CentosRPMs/.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 62616: Binary packaging for Centos 7.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62616/#review189824
-----------------------------------------------------------
FAIL: Failed to apply the current review.
Failed command: `python.exe .\support\apply-reviews.py -n -r 62616`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62616
Relevant logs:
- [apply-review-62616-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62616/logs/apply-review-62616-stdout.log):
```
error: support/packaging/Jenkinsfile: already exists in index
error: support/packaging/centos/build_rpm.sh: already exists in index
error: support/packaging/centos/centos6.dockerfile: already exists in index
error: support/packaging/centos/centos7.dockerfile: already exists in index
error: support/packaging/centos/mesos.spec: already exists in index
error: support/packaging/common/mesos: already exists in index
error: support/packaging/common/mesos-init-wrapper: already exists in index
error: support/packaging/common/mesos-master: already exists in index
error: support/packaging/common/mesos-master.service: already exists in index
error: support/packaging/common/mesos-master.upstart: already exists in index
error: support/packaging/common/mesos-slave: already exists in index
error: support/packaging/common/mesos-slave.service: already exists in index
error: support/packaging/common/mesos-slave.upstart: already exists in index
```
- Mesos Reviewbot Windows
On Oct. 30, 2017, 5:49 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62616/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2017, 5:49 p.m.)
>
>
> Review request for mesos, Benno Evers, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7982
> https://issues.apache.org/jira/browse/MESOS-7982
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Binary packaging for Centos 7.
>
>
> Diffs
> -----
>
> support/packaging/Jenkinsfile PRE-CREATION
> support/packaging/centos/build_rpm.sh PRE-CREATION
> support/packaging/centos/centos6.dockerfile PRE-CREATION
> support/packaging/centos/centos7.dockerfile PRE-CREATION
> support/packaging/centos/mesos.spec PRE-CREATION
> support/packaging/common/mesos PRE-CREATION
> support/packaging/common/mesos-init-wrapper PRE-CREATION
> support/packaging/common/mesos-master PRE-CREATION
> support/packaging/common/mesos-master.service PRE-CREATION
> support/packaging/common/mesos-master.upstart PRE-CREATION
> support/packaging/common/mesos-slave PRE-CREATION
> support/packaging/common/mesos-slave.service PRE-CREATION
> support/packaging/common/mesos-slave.upstart PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/62616/diff/4/
>
>
> Testing
> -------
>
> The scripts have been tested on an internal Jenkins CI. A buildjob on ASF Jenkins CI is available at https://builds.apache.org/job/Mesos/job/Packaging/job/CentosRPMs/.
>
> Building a package locally:
>
> 1. cd <mesos>
> 2. <Optionally build the docker image locally> (Or use mesos/packaging:centos7).
> docker build -t mesos-centos7 -f support/packaging/centos/centos7.dockerfile support/packaging/centos
> 3. mkdir .m2
> 4. docker run -u `id -u':`id -g` -e MESOS_TAG=1.4.0 -e MESOS_RELEASE=1 -v=/etc/passwd:/etc/passwd -v=/etc/group:/etc/group -v=`pwd`/.m2:$HOME/.m2:rw,z -v `pwd`:/mesos:rw,z mesos/packaging:centos7 /mesos/support/packaging/centos/build_rpm
>
> RPMs will be placed inside <mesos>/centos7/rpmbuild/RPMs/x86_64 directory.
>
> If `MESOS_TAG` environment variable is not supplied, it builds the package from the local mesos tree.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 62616: Binary packaging for Centos 7.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62616/
-----------------------------------------------------------
(Updated Oct. 30, 2017, 1:49 p.m.)
Review request for mesos, Benno Evers, Till Toenshoff, and Vinod Kone.
Changes
-------
Replaced `slave` with `agent` in helper files.
Bugs: MESOS-7982
https://issues.apache.org/jira/browse/MESOS-7982
Repository: mesos
Description
-------
Binary packaging for Centos 7.
Diffs (updated)
-----
support/packaging/Jenkinsfile PRE-CREATION
support/packaging/centos/build_rpm.sh PRE-CREATION
support/packaging/centos/centos6.dockerfile PRE-CREATION
support/packaging/centos/centos7.dockerfile PRE-CREATION
support/packaging/centos/mesos.spec PRE-CREATION
support/packaging/common/mesos PRE-CREATION
support/packaging/common/mesos-init-wrapper PRE-CREATION
support/packaging/common/mesos-master PRE-CREATION
support/packaging/common/mesos-master.service PRE-CREATION
support/packaging/common/mesos-master.upstart PRE-CREATION
support/packaging/common/mesos-slave PRE-CREATION
support/packaging/common/mesos-slave.service PRE-CREATION
support/packaging/common/mesos-slave.upstart PRE-CREATION
Diff: https://reviews.apache.org/r/62616/diff/4/
Changes: https://reviews.apache.org/r/62616/diff/3-4/
Testing
-------
The scripts have been tested on an internal Jenkins CI. A buildjob on ASF Jenkins CI is available at https://builds.apache.org/job/Mesos/job/Packaging/job/CentosRPMs/.
Building a package locally:
1. cd <mesos>
2. <Optionally build the docker image locally> (Or use mesos/packaging:centos7).
docker build -t mesos-centos7 -f support/packaging/centos/centos7.dockerfile support/packaging/centos
3. mkdir .m2
4. docker run -u `id -u':`id -g` -e MESOS_TAG=1.4.0 -e MESOS_RELEASE=1 -v=/etc/passwd:/etc/passwd -v=/etc/group:/etc/group -v=`pwd`/.m2:$HOME/.m2:rw,z -v `pwd`:/mesos:rw,z mesos/packaging:centos7 /mesos/support/packaging/centos/build_rpm
RPMs will be placed inside <mesos>/centos7/rpmbuild/RPMs/x86_64 directory.
If `MESOS_TAG` environment variable is not supplied, it builds the package from the local mesos tree.
Thanks,
Kapil Arya
Re: Review Request 62616: Binary packaging for Centos 7.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62616/#review188029
-----------------------------------------------------------
PASS: Mesos patch 62616 was successfully built and tested.
Reviews applied: `['62616']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62616
- Mesos Reviewbot Windows
On Oct. 13, 2017, 6:21 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62616/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2017, 6:21 p.m.)
>
>
> Review request for mesos, Benno Evers, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7982
> https://issues.apache.org/jira/browse/MESOS-7982
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Binary packaging for Centos 7.
>
>
> Diffs
> -----
>
> support/packaging/Jenkinsfile PRE-CREATION
> support/packaging/centos/build_rpm.sh PRE-CREATION
> support/packaging/centos/centos6.dockerfile PRE-CREATION
> support/packaging/centos/centos7.dockerfile PRE-CREATION
> support/packaging/centos/mesos.spec PRE-CREATION
> support/packaging/common/mesos PRE-CREATION
> support/packaging/common/mesos-init-wrapper PRE-CREATION
> support/packaging/common/mesos-master PRE-CREATION
> support/packaging/common/mesos-master.service PRE-CREATION
> support/packaging/common/mesos-master.upstart PRE-CREATION
> support/packaging/common/mesos-slave PRE-CREATION
> support/packaging/common/mesos-slave.service PRE-CREATION
> support/packaging/common/mesos-slave.upstart PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/62616/diff/3/
>
>
> Testing
> -------
>
> The scripts have been tested on an internal Jenkins CI. A buildjob on ASF Jenkins CI is available at https://builds.apache.org/job/Mesos/job/Packaging/job/CentosRPMs/.
>
> Building a package locally:
>
> 1. cd <mesos>
> 2. <Optionally build the docker image locally> (Or use mesos/packaging:centos7).
> docker build -t mesos-centos7 -f support/packaging/centos/centos7.dockerfile support/packaging/centos
> 3. mkdir .m2
> 4. docker run -u `id -u':`id -g` -e MESOS_TAG=1.4.0 -e MESOS_RELEASE=1 -v=/etc/passwd:/etc/passwd -v=/etc/group:/etc/group -v=`pwd`/.m2:$HOME/.m2:rw,z -v `pwd`:/mesos:rw,z mesos/packaging:centos7 /mesos/support/packaging/centos/build_rpm
>
> RPMs will be placed inside <mesos>/centos7/rpmbuild/RPMs/x86_64 directory.
>
> If `MESOS_TAG` environment variable is not supplied, it builds the package from the local mesos tree.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 62616: Binary packaging for Centos 7.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62616/#review189615
-----------------------------------------------------------
Ship it!
This looks really promising. Nice!
- James Peach
On Oct. 13, 2017, 6:21 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62616/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2017, 6:21 p.m.)
>
>
> Review request for mesos, Benno Evers, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7982
> https://issues.apache.org/jira/browse/MESOS-7982
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Binary packaging for Centos 7.
>
>
> Diffs
> -----
>
> support/packaging/Jenkinsfile PRE-CREATION
> support/packaging/centos/build_rpm.sh PRE-CREATION
> support/packaging/centos/centos6.dockerfile PRE-CREATION
> support/packaging/centos/centos7.dockerfile PRE-CREATION
> support/packaging/centos/mesos.spec PRE-CREATION
> support/packaging/common/mesos PRE-CREATION
> support/packaging/common/mesos-init-wrapper PRE-CREATION
> support/packaging/common/mesos-master PRE-CREATION
> support/packaging/common/mesos-master.service PRE-CREATION
> support/packaging/common/mesos-master.upstart PRE-CREATION
> support/packaging/common/mesos-slave PRE-CREATION
> support/packaging/common/mesos-slave.service PRE-CREATION
> support/packaging/common/mesos-slave.upstart PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/62616/diff/3/
>
>
> Testing
> -------
>
> The scripts have been tested on an internal Jenkins CI. A buildjob on ASF Jenkins CI is available at https://builds.apache.org/job/Mesos/job/Packaging/job/CentosRPMs/.
>
> Building a package locally:
>
> 1. cd <mesos>
> 2. <Optionally build the docker image locally> (Or use mesos/packaging:centos7).
> docker build -t mesos-centos7 -f support/packaging/centos/centos7.dockerfile support/packaging/centos
> 3. mkdir .m2
> 4. docker run -u `id -u':`id -g` -e MESOS_TAG=1.4.0 -e MESOS_RELEASE=1 -v=/etc/passwd:/etc/passwd -v=/etc/group:/etc/group -v=`pwd`/.m2:$HOME/.m2:rw,z -v `pwd`:/mesos:rw,z mesos/packaging:centos7 /mesos/support/packaging/centos/build_rpm
>
> RPMs will be placed inside <mesos>/centos7/rpmbuild/RPMs/x86_64 directory.
>
> If `MESOS_TAG` environment variable is not supplied, it builds the package from the local mesos tree.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 62616: Binary packaging for Centos 7.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62616/
-----------------------------------------------------------
(Updated Oct. 13, 2017, 2:21 p.m.)
Review request for mesos, Benno Evers, Till Toenshoff, and Vinod Kone.
Bugs: MESOS-7982
https://issues.apache.org/jira/browse/MESOS-7982
Repository: mesos
Description
-------
Binary packaging for Centos 7.
Diffs
-----
support/packaging/Jenkinsfile PRE-CREATION
support/packaging/centos/build_rpm.sh PRE-CREATION
support/packaging/centos/centos6.dockerfile PRE-CREATION
support/packaging/centos/centos7.dockerfile PRE-CREATION
support/packaging/centos/mesos.spec PRE-CREATION
support/packaging/common/mesos PRE-CREATION
support/packaging/common/mesos-init-wrapper PRE-CREATION
support/packaging/common/mesos-master PRE-CREATION
support/packaging/common/mesos-master.service PRE-CREATION
support/packaging/common/mesos-master.upstart PRE-CREATION
support/packaging/common/mesos-slave PRE-CREATION
support/packaging/common/mesos-slave.service PRE-CREATION
support/packaging/common/mesos-slave.upstart PRE-CREATION
Diff: https://reviews.apache.org/r/62616/diff/3/
Testing (updated)
-------
The scripts have been tested on an internal Jenkins CI. A buildjob on ASF Jenkins CI is available at https://builds.apache.org/job/Mesos/job/Packaging/job/CentosRPMs/.
Building a package locally:
1. cd <mesos>
2. <Optionally build the docker image locally> (Or use mesos/packaging:centos7).
docker build -t mesos-centos7 -f support/packaging/centos/centos7.dockerfile support/packaging/centos
3. mkdir .m2
4. docker run -u `id -u':`id -g` -e MESOS_TAG=1.4.0 -e MESOS_RELEASE=1 -v=/etc/passwd:/etc/passwd -v=/etc/group:/etc/group -v=`pwd`/.m2:$HOME/.m2:rw,z -v `pwd`:/mesos:rw,z mesos/packaging:centos7 /mesos/support/packaging/centos/build_rpm
RPMs will be placed inside <mesos>/centos7/rpmbuild/RPMs/x86_64 directory.
If `MESOS_TAG` environment variable is not supplied, it builds the package from the local mesos tree.
Thanks,
Kapil Arya
Re: Review Request 62616: Binary packaging for Centos 7.
Posted by Kapil Arya <ka...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62616/
-----------------------------------------------------------
(Updated Oct. 13, 2017, 2:02 p.m.)
Review request for mesos, Benno Evers, Till Toenshoff, and Vinod Kone.
Changes
-------
Addressed most of Jie and James's comments.
Bugs: MESOS-7982
https://issues.apache.org/jira/browse/MESOS-7982
Repository: mesos
Description
-------
Binary packaging for Centos 7.
Diffs (updated)
-----
support/packaging/Jenkinsfile PRE-CREATION
support/packaging/centos/build_rpm.sh PRE-CREATION
support/packaging/centos/centos6.dockerfile PRE-CREATION
support/packaging/centos/centos7.dockerfile PRE-CREATION
support/packaging/centos/mesos.spec PRE-CREATION
support/packaging/common/mesos PRE-CREATION
support/packaging/common/mesos-init-wrapper PRE-CREATION
support/packaging/common/mesos-master PRE-CREATION
support/packaging/common/mesos-master.service PRE-CREATION
support/packaging/common/mesos-master.upstart PRE-CREATION
support/packaging/common/mesos-slave PRE-CREATION
support/packaging/common/mesos-slave.service PRE-CREATION
support/packaging/common/mesos-slave.upstart PRE-CREATION
Diff: https://reviews.apache.org/r/62616/diff/3/
Changes: https://reviews.apache.org/r/62616/diff/2-3/
Testing
-------
The scripts have been tested on an internal Jenkins CI. A buildjob on ASF Jenkins CI is available at https://builds.apache.org/job/Mesos/job/Packaging/job/CentosRPMs/.
Thanks,
Kapil Arya
Re: Review Request 62616: Binary packaging for Centos 7.
Posted by Kapil Arya <ka...@mesosphere.io>.
> On Oct. 6, 2017, 2:11 p.m., Benno Evers wrote:
> > support/packaging/common/mesos-master.service
> > Lines 7 (patched)
> > <https://reviews.apache.org/r/62616/diff/2/?file=1837912#file1837912line7>
> >
> > If this is to be common for all packaging, probably it should be `mesos-master.service.in` and use `@BINDIR@` instead of `/usr/bin`. (same comment applies for the other files under `packaging/common/`)
I'm not sure about this. But we can always do it in the second round. I just tried to replicate what we already had for packages generated by Mesosphere.
> On Oct. 6, 2017, 2:11 p.m., Benno Evers wrote:
> > support/packaging/common/mesos-slave
> > Lines 1 (patched)
> > <https://reviews.apache.org/r/62616/diff/2/?file=1837914#file1837914line1>
> >
> > Should this be `ZK` instead of `MASTER`? And do we need a check here if mesos was compiled with support for zookeeper?
I think we are compiling Mesos with ZK support by default.
- Kapil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62616/#review187282
-----------------------------------------------------------
On Oct. 13, 2017, 2:02 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62616/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2017, 2:02 p.m.)
>
>
> Review request for mesos, Benno Evers, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7982
> https://issues.apache.org/jira/browse/MESOS-7982
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Binary packaging for Centos 7.
>
>
> Diffs
> -----
>
> support/packaging/Jenkinsfile PRE-CREATION
> support/packaging/centos/build_rpm.sh PRE-CREATION
> support/packaging/centos/centos6.dockerfile PRE-CREATION
> support/packaging/centos/centos7.dockerfile PRE-CREATION
> support/packaging/centos/mesos.spec PRE-CREATION
> support/packaging/common/mesos PRE-CREATION
> support/packaging/common/mesos-init-wrapper PRE-CREATION
> support/packaging/common/mesos-master PRE-CREATION
> support/packaging/common/mesos-master.service PRE-CREATION
> support/packaging/common/mesos-master.upstart PRE-CREATION
> support/packaging/common/mesos-slave PRE-CREATION
> support/packaging/common/mesos-slave.service PRE-CREATION
> support/packaging/common/mesos-slave.upstart PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/62616/diff/3/
>
>
> Testing
> -------
>
> The scripts have been tested on an internal Jenkins CI. A buildjob on ASF Jenkins CI is available at https://builds.apache.org/job/Mesos/job/Packaging/job/CentosRPMs/.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 62616: Binary packaging for Centos 7.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62616/#review187282
-----------------------------------------------------------
In general, I would like to +1 Jie's comments, it would be really nice to have the ability to create a .deb/.rpm package from a local working directory and to have only very minimal logic in docker, so we don't get into a situation where we effectively depend on docker to build mesos.
support/packaging/centos/6/Dockerfile
Lines 90 (patched)
<https://reviews.apache.org/r/62616/#comment264208>
This seems to install much more than just the `BuildRequires` listed in the spec file below.
support/packaging/centos/6/Dockerfile
Lines 99 (patched)
<https://reviews.apache.org/r/62616/#comment264209>
Do we reuse the generated container anywhere? If not, it doesn't seem like ccache could have any cache hits.
Also, does the yum package automatically set ccache as the default compiler? On debian, some manual work is still required after installing the package to either set up the appropriate symlinks or to manually set `CXX="ccache g++"`
support/packaging/common/mesos-master.service
Lines 7 (patched)
<https://reviews.apache.org/r/62616/#comment264205>
If this is to be common for all packaging, probably it should be `mesos-master.service.in` and use `@BINDIR@` instead of `/usr/bin`. (same comment applies for the other files under `packaging/common/`)
support/packaging/common/mesos-slave
Lines 1 (patched)
<https://reviews.apache.org/r/62616/#comment264207>
Should this be `ZK` instead of `MASTER`? And do we need a check here if mesos was compiled with support for zookeeper?
- Benno Evers
On Sept. 27, 2017, 9:50 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62616/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2017, 9:50 p.m.)
>
>
> Review request for mesos, Benno Evers, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7982
> https://issues.apache.org/jira/browse/MESOS-7982
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Binary packaging for Centos 7.
>
>
> Diffs
> -----
>
> support/packaging/Jenkinsfile PRE-CREATION
> support/packaging/centos/6/Dockerfile PRE-CREATION
> support/packaging/centos/6/mesos.spec PRE-CREATION
> support/packaging/centos/7/Dockerfile PRE-CREATION
> support/packaging/centos/7/mesos.spec PRE-CREATION
> support/packaging/common/mesos PRE-CREATION
> support/packaging/common/mesos-init-wrapper PRE-CREATION
> support/packaging/common/mesos-master PRE-CREATION
> support/packaging/common/mesos-master.service PRE-CREATION
> support/packaging/common/mesos-master.upstart PRE-CREATION
> support/packaging/common/mesos-slave PRE-CREATION
> support/packaging/common/mesos-slave.service PRE-CREATION
> support/packaging/common/mesos-slave.upstart PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/62616/diff/2/
>
>
> Testing
> -------
>
> The scripts have been tested on an internal Jenkins CI. A buildjob on ASF Jenkins CI is available at https://builds.apache.org/job/Mesos/job/Packaging/job/CentosRPMs/.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 62616: Binary packaging for Centos 7.
Posted by Kapil Arya <ka...@mesosphere.io>.
> On Oct. 2, 2017, 1:17 p.m., Jie Yu wrote:
> >
Thanks for the comments, Jie! The updated scripts allow for building from a local tree from a command line. I'd add a README shortly.
> On Oct. 2, 2017, 1:17 p.m., Jie Yu wrote:
> > support/packaging/centos/6/Dockerfile
> > Lines 5 (patched)
> > <https://reviews.apache.org/r/62616/diff/2/?file=1837905#file1837905line5>
> >
> > This is more like dev packages (used for development and building Mesos).
> >
> > I think we probably need to types of Docker images:
> > 1) dev image like you have here
> > 2) images that are used for running Mesos
> >
> > For 2), we don't need to pull in dependencies for building Mesos. We only need the dependencies for running Mesos. And that dependencies will be included automatically by RPM. So the Dockerfile can be as simple as a single yum install.
These docker images are for building rpms only. Once the RPM is there, we can just have a simple docker file that adds the repo and install the rpm package inside it. But I think that is stage 2 and orthogonal to this RR.
- Kapil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62616/#review186855
-----------------------------------------------------------
On Oct. 13, 2017, 2:02 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62616/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2017, 2:02 p.m.)
>
>
> Review request for mesos, Benno Evers, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7982
> https://issues.apache.org/jira/browse/MESOS-7982
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Binary packaging for Centos 7.
>
>
> Diffs
> -----
>
> support/packaging/Jenkinsfile PRE-CREATION
> support/packaging/centos/build_rpm.sh PRE-CREATION
> support/packaging/centos/centos6.dockerfile PRE-CREATION
> support/packaging/centos/centos7.dockerfile PRE-CREATION
> support/packaging/centos/mesos.spec PRE-CREATION
> support/packaging/common/mesos PRE-CREATION
> support/packaging/common/mesos-init-wrapper PRE-CREATION
> support/packaging/common/mesos-master PRE-CREATION
> support/packaging/common/mesos-master.service PRE-CREATION
> support/packaging/common/mesos-master.upstart PRE-CREATION
> support/packaging/common/mesos-slave PRE-CREATION
> support/packaging/common/mesos-slave.service PRE-CREATION
> support/packaging/common/mesos-slave.upstart PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/62616/diff/3/
>
>
> Testing
> -------
>
> The scripts have been tested on an internal Jenkins CI. A buildjob on ASF Jenkins CI is available at https://builds.apache.org/job/Mesos/job/Packaging/job/CentosRPMs/.
>
>
> Thanks,
>
> Kapil Arya
>
>
Re: Review Request 62616: Binary packaging for Centos 7.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62616/#review186855
-----------------------------------------------------------
support/packaging/Jenkinsfile
Lines 26-49 (patched)
<https://reviews.apache.org/r/62616/#comment263696>
Is there a way to have a script in the `support/` directory so that I can build an RPM by just typing `support/packaging/centos7/build_rpm.sh` on my OSX host? And CI script can simply call that.
support/packaging/centos/6/Dockerfile
Lines 5 (patched)
<https://reviews.apache.org/r/62616/#comment263694>
This is more like dev packages (used for development and building Mesos).
I think we probably need to types of Docker images:
1) dev image like you have here
2) images that are used for running Mesos
For 2), we don't need to pull in dependencies for building Mesos. We only need the dependencies for running Mesos. And that dependencies will be included automatically by RPM. So the Dockerfile can be as simple as a single yum install.
support/packaging/centos/6/Dockerfile
Lines 8 (patched)
<https://reviews.apache.org/r/62616/#comment263695>
I think to reduce the size of the Docker image, we should probably have less `RUN` directives because each `RUN` will cause Docker daemon to produce a layer.
- Jie Yu
On Sept. 27, 2017, 9:50 p.m., Kapil Arya wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62616/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2017, 9:50 p.m.)
>
>
> Review request for mesos, Benno Evers, Till Toenshoff, and Vinod Kone.
>
>
> Bugs: MESOS-7982
> https://issues.apache.org/jira/browse/MESOS-7982
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Binary packaging for Centos 7.
>
>
> Diffs
> -----
>
> support/packaging/Jenkinsfile PRE-CREATION
> support/packaging/centos/6/Dockerfile PRE-CREATION
> support/packaging/centos/6/mesos.spec PRE-CREATION
> support/packaging/centos/7/Dockerfile PRE-CREATION
> support/packaging/centos/7/mesos.spec PRE-CREATION
> support/packaging/common/mesos PRE-CREATION
> support/packaging/common/mesos-init-wrapper PRE-CREATION
> support/packaging/common/mesos-master PRE-CREATION
> support/packaging/common/mesos-master.service PRE-CREATION
> support/packaging/common/mesos-master.upstart PRE-CREATION
> support/packaging/common/mesos-slave PRE-CREATION
> support/packaging/common/mesos-slave.service PRE-CREATION
> support/packaging/common/mesos-slave.upstart PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/62616/diff/2/
>
>
> Testing
> -------
>
> The scripts have been tested on an internal Jenkins CI. A buildjob on ASF Jenkins CI is available at https://builds.apache.org/job/Mesos/job/Packaging/job/CentosRPMs/.
>
>
> Thanks,
>
> Kapil Arya
>
>