You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Sushil Mohanty <su...@gmail.com> on 2016/03/10 09:33:55 UTC
Review Request 44612: LENS-975 : Add cube-segmentation specification
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44612/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-975
https://issues.apache.org/jira/browse/LENS-975
Repository: lens
Description
-------
Added cube segmantation specification and metastore CRUD operations.
Diffs
-----
lens-api/src/main/resources/cube-0.1.xsd 0f4dbea
lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 01098c4
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 643bcfe
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 02bbbbd
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegmentation.java PRE-CREATION
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeTableType.java ec1c837
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java ed78d74
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java deb5368
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 65387c6
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java c11fd83
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java a1acd1a
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 6fd19a0
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java e7d545c
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java a541e9b
Diff: https://reviews.apache.org/r/44612/diff/
Testing
-------
Added unit test for cubesegmentation metastore operation. mvn clean install runs fine.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.028s]
[INFO] Lens .............................................. SUCCESS [3.135s]
[INFO] Lens API .......................................... SUCCESS [27.415s]
[INFO] Lens API for server and extensions ................ SUCCESS [20.108s]
[INFO] Lens Cube ......................................... SUCCESS [11:11.002s]
[INFO] Lens DB storage ................................... SUCCESS [19.140s]
[INFO] Lens Query Library ................................ SUCCESS [15.036s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:46.067s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [39.592s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [16.465s]
[INFO] Lens Server ....................................... SUCCESS [16:03.100s]
[INFO] Lens client ....................................... SUCCESS [36.084s]
[INFO] Lens CLI .......................................... SUCCESS [53.148s]
[INFO] Lens Examples ..................................... SUCCESS [12.655s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.747s]
[INFO] Lens Distribution ................................. SUCCESS [9.223s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:20.165s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.773s]
[INFO] Lens Regression ................................... SUCCESS [13.778s]
[INFO] Lens UI ........................................... SUCCESS [28.603s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 36:20.155s
[INFO] Finished at: Thu Mar 10 08:16:00 UTC 2016
[INFO] Final Memory: 210M/2450M
[INFO] ------------------------------------------------------------------------
Thanks,
Sushil Mohanty
Re: Review Request 44612: LENS-975 : Add cube-segmentation
specification
Posted by Sushil Mohanty <su...@gmail.com>.
> On March 11, 2016, 8:09 a.m., Amareshwari Sriramadasu wrote:
> > lens-api/src/main/resources/cube-0.1.xsd, line 1016
> > <https://reviews.apache.org/r/44612/diff/1/?file=1294162#file1294162line1016>
> >
> > Can you update doc mentioning this is a candidate participating in cube segmentation ?
> >
> > Should we call it candidate_cube itself? or something like x_participating_cube or x_part_cube or x_cube_segment ?
Used namne x_cube_segment, seems to be more appropriate with CubeSegmentation.
- Sushil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44612/#review123111
-----------------------------------------------------------
On March 17, 2016, 9:04 a.m., Sushil Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44612/
> -----------------------------------------------------------
>
> (Updated March 17, 2016, 9:04 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-975
> https://issues.apache.org/jira/browse/LENS-975
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added cube segmantation specification and metastore CRUD operations.
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 0f4dbea
> lens-cli/src/main/java/org/apache/lens/cli/commands/IrrationalTableCrudCommand.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/commands/annotations/LensCubeSegmentationCommands.java PRE-CREATION
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeSegmentationCommands.java PRE-CREATION
> lens-cli/src/test/resources/seg1.xml PRE-CREATION
> lens-client/src/main/java/org/apache/lens/client/LensClient.java ea0cd76
> lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java d0f2b57
> lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 01098c4
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 643bcfe
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 02bbbbd
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegmentation.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeTableType.java ec1c837
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java ed78d74
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java deb5368
> lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java 0935509
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 65387c6
> lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java 0c2301b
> lens-examples/src/main/resources/cube-segmentation1.xml PRE-CREATION
> lens-examples/src/test/resources/yaml/cube-segmentation1.yaml PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 1b7d0f9
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java c11fd83
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java a1acd1a
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 6fd19a0
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java e7d545c
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java a541e9b
>
> Diff: https://reviews.apache.org/r/44612/diff/
>
>
> Testing
> -------
>
> Added unit test for cubesegmentation metastore operation. mvn clean install runs fine.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.265s]
> [INFO] Lens .............................................. SUCCESS [4.354s]
> [INFO] Lens API .......................................... SUCCESS [29.857s]
> [INFO] Lens API for server and extensions ................ SUCCESS [22.179s]
> [INFO] Lens Cube ......................................... SUCCESS [11:10.012s]
> [INFO] Lens DB storage ................................... SUCCESS [20.014s]
> [INFO] Lens Query Library ................................ SUCCESS [15.666s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:48.066s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.218s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [15.893s]
> [INFO] Lens Server ....................................... SUCCESS [16:37.655s]
> [INFO] Lens client ....................................... SUCCESS [47.034s]
> [INFO] Lens CLI .......................................... SUCCESS [57.465s]
> [INFO] Lens Examples ..................................... SUCCESS [15.509s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [1.209s]
> [INFO] Lens Distribution ................................. SUCCESS [22.002s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:36.655s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.019s]
> [INFO] Lens Regression ................................... SUCCESS [14.401s]
> [INFO] Lens UI ........................................... SUCCESS [29.585s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 37:49.065s
> [INFO] Finished at: Thu Mar 17 08:51:02 UTC 2016
> [INFO] Final Memory: 173M/2915M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Sushil Mohanty
>
>
Re: Review Request 44612: LENS-975 : Add cube-segmentation
specification
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44612/#review123111
-----------------------------------------------------------
lens-api/src/main/resources/cube-0.1.xsd (line 1016)
<https://reviews.apache.org/r/44612/#comment185264>
Can you update doc mentioning this is a candidate participating in cube segmentation ?
Should we call it candidate_cube itself? or something like x_participating_cube or x_part_cube or x_cube_segment ?
lens-api/src/main/resources/cube-0.1.xsd (line 1031)
<https://reviews.apache.org/r/44612/#comment185265>
Should we make minoccurs to be 2 ?
lens-api/src/main/resources/cube-0.1.xsd (line 1255)
<https://reviews.apache.org/r/44612/#comment185266>
Update doc - it consists of two or more candidate cubes. Be consistent in calling candidate cubes everywhere instead of child cubes.
lens-api/src/main/resources/cube-0.1.xsd (line 1265)
<https://reviews.apache.org/r/44612/#comment185269>
Why is this going in property? It should be defined as first class , which is already done below.
lens-api/src/main/resources/cube-0.1.xsd (line 1270)
<https://reviews.apache.org/r/44612/#comment185270>
let us not mention as in time_range_in clause here. That will confuse people
- Amareshwari Sriramadasu
On March 10, 2016, 8:33 a.m., Sushil Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44612/
> -----------------------------------------------------------
>
> (Updated March 10, 2016, 8:33 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-975
> https://issues.apache.org/jira/browse/LENS-975
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added cube segmantation specification and metastore CRUD operations.
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 0f4dbea
> lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 01098c4
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 643bcfe
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 02bbbbd
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegmentation.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeTableType.java ec1c837
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java ed78d74
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java deb5368
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 65387c6
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java c11fd83
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java a1acd1a
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 6fd19a0
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java e7d545c
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java a541e9b
>
> Diff: https://reviews.apache.org/r/44612/diff/
>
>
> Testing
> -------
>
> Added unit test for cubesegmentation metastore operation. mvn clean install runs fine.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.028s]
> [INFO] Lens .............................................. SUCCESS [3.135s]
> [INFO] Lens API .......................................... SUCCESS [27.415s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.108s]
> [INFO] Lens Cube ......................................... SUCCESS [11:11.002s]
> [INFO] Lens DB storage ................................... SUCCESS [19.140s]
> [INFO] Lens Query Library ................................ SUCCESS [15.036s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:46.067s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [39.592s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [16.465s]
> [INFO] Lens Server ....................................... SUCCESS [16:03.100s]
> [INFO] Lens client ....................................... SUCCESS [36.084s]
> [INFO] Lens CLI .......................................... SUCCESS [53.148s]
> [INFO] Lens Examples ..................................... SUCCESS [12.655s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.747s]
> [INFO] Lens Distribution ................................. SUCCESS [9.223s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:20.165s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.773s]
> [INFO] Lens Regression ................................... SUCCESS [13.778s]
> [INFO] Lens UI ........................................... SUCCESS [28.603s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 36:20.155s
> [INFO] Finished at: Thu Mar 10 08:16:00 UTC 2016
> [INFO] Final Memory: 210M/2450M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Sushil Mohanty
>
>
Re: Review Request 44612: LENS-975 : Add cube-segmentation
specification
Posted by Sushil Mohanty <su...@gmail.com>.
> On March 15, 2016, 11:10 a.m., Puneet Gupta wrote:
> > lens-api/src/main/resources/cube-0.1.xsd, line 1252
> > <https://reviews.apache.org/r/44612/diff/1/?file=1294162#file1294162line1252>
> >
> > One more name suggestion ;-)
> >
> > x_cube_segment or x_virtul_fact
x_cube_segmentaiton 1:n x_cube_segment.
> On March 15, 2016, 11:10 a.m., Puneet Gupta wrote:
> > lens-api/src/main/resources/cube-0.1.xsd, line 1268
> > <https://reviews.apache.org/r/44612/diff/1/?file=1294162#file1294162line1268>
> >
> > should this start time be calculated automatically based on candidate cubes and their facts ?
This property user can set while creating cubesegmentation, same way its done in facts.
- Sushil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44612/#review123632
-----------------------------------------------------------
On March 17, 2016, 9:04 a.m., Sushil Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44612/
> -----------------------------------------------------------
>
> (Updated March 17, 2016, 9:04 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-975
> https://issues.apache.org/jira/browse/LENS-975
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added cube segmantation specification and metastore CRUD operations.
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 0f4dbea
> lens-cli/src/main/java/org/apache/lens/cli/commands/IrrationalTableCrudCommand.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/commands/annotations/LensCubeSegmentationCommands.java PRE-CREATION
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeSegmentationCommands.java PRE-CREATION
> lens-cli/src/test/resources/seg1.xml PRE-CREATION
> lens-client/src/main/java/org/apache/lens/client/LensClient.java ea0cd76
> lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java d0f2b57
> lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 01098c4
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 643bcfe
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 02bbbbd
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegmentation.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeTableType.java ec1c837
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java ed78d74
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java deb5368
> lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java 0935509
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 65387c6
> lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java 0c2301b
> lens-examples/src/main/resources/cube-segmentation1.xml PRE-CREATION
> lens-examples/src/test/resources/yaml/cube-segmentation1.yaml PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 1b7d0f9
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java c11fd83
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java a1acd1a
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 6fd19a0
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java e7d545c
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java a541e9b
>
> Diff: https://reviews.apache.org/r/44612/diff/
>
>
> Testing
> -------
>
> Added unit test for cubesegmentation metastore operation. mvn clean install runs fine.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.265s]
> [INFO] Lens .............................................. SUCCESS [4.354s]
> [INFO] Lens API .......................................... SUCCESS [29.857s]
> [INFO] Lens API for server and extensions ................ SUCCESS [22.179s]
> [INFO] Lens Cube ......................................... SUCCESS [11:10.012s]
> [INFO] Lens DB storage ................................... SUCCESS [20.014s]
> [INFO] Lens Query Library ................................ SUCCESS [15.666s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:48.066s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.218s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [15.893s]
> [INFO] Lens Server ....................................... SUCCESS [16:37.655s]
> [INFO] Lens client ....................................... SUCCESS [47.034s]
> [INFO] Lens CLI .......................................... SUCCESS [57.465s]
> [INFO] Lens Examples ..................................... SUCCESS [15.509s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [1.209s]
> [INFO] Lens Distribution ................................. SUCCESS [22.002s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:36.655s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.019s]
> [INFO] Lens Regression ................................... SUCCESS [14.401s]
> [INFO] Lens UI ........................................... SUCCESS [29.585s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 37:49.065s
> [INFO] Finished at: Thu Mar 17 08:51:02 UTC 2016
> [INFO] Final Memory: 173M/2915M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Sushil Mohanty
>
>
Re: Review Request 44612: LENS-975 : Add cube-segmentation
specification
Posted by Puneet Gupta <pu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44612/#review123632
-----------------------------------------------------------
lens-api/src/main/resources/cube-0.1.xsd (line 1252)
<https://reviews.apache.org/r/44612/#comment185860>
One more name suggestion ;-)
x_cube_segment or x_virtul_fact
lens-api/src/main/resources/cube-0.1.xsd (line 1268)
<https://reviews.apache.org/r/44612/#comment185861>
should this start time be calculated automatically based on candidate cubes and their facts ?
- Puneet Gupta
On March 10, 2016, 8:33 a.m., Sushil Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44612/
> -----------------------------------------------------------
>
> (Updated March 10, 2016, 8:33 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-975
> https://issues.apache.org/jira/browse/LENS-975
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added cube segmantation specification and metastore CRUD operations.
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 0f4dbea
> lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 01098c4
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 643bcfe
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 02bbbbd
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegmentation.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeTableType.java ec1c837
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java ed78d74
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java deb5368
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 65387c6
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java c11fd83
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java a1acd1a
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 6fd19a0
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java e7d545c
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java a541e9b
>
> Diff: https://reviews.apache.org/r/44612/diff/
>
>
> Testing
> -------
>
> Added unit test for cubesegmentation metastore operation. mvn clean install runs fine.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.028s]
> [INFO] Lens .............................................. SUCCESS [3.135s]
> [INFO] Lens API .......................................... SUCCESS [27.415s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.108s]
> [INFO] Lens Cube ......................................... SUCCESS [11:11.002s]
> [INFO] Lens DB storage ................................... SUCCESS [19.140s]
> [INFO] Lens Query Library ................................ SUCCESS [15.036s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:46.067s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [39.592s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [16.465s]
> [INFO] Lens Server ....................................... SUCCESS [16:03.100s]
> [INFO] Lens client ....................................... SUCCESS [36.084s]
> [INFO] Lens CLI .......................................... SUCCESS [53.148s]
> [INFO] Lens Examples ..................................... SUCCESS [12.655s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.747s]
> [INFO] Lens Distribution ................................. SUCCESS [9.223s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:20.165s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.773s]
> [INFO] Lens Regression ................................... SUCCESS [13.778s]
> [INFO] Lens UI ........................................... SUCCESS [28.603s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 36:20.155s
> [INFO] Finished at: Thu Mar 10 08:16:00 UTC 2016
> [INFO] Final Memory: 210M/2450M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Sushil Mohanty
>
>
Re: Review Request 44612: LENS-975 : Add cube-segmentation
specification
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44612/#review125599
-----------------------------------------------------------
Fix it, then Ship it!
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java (line 814)
<https://reviews.apache.org/r/44612/#comment188470>
Javadoc needs update
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java (line 915)
<https://reviews.apache.org/r/44612/#comment188471>
javadoc needs update
- Amareshwari Sriramadasu
On March 26, 2016, 8:55 a.m., Sushil Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44612/
> -----------------------------------------------------------
>
> (Updated March 26, 2016, 8:55 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-975
> https://issues.apache.org/jira/browse/LENS-975
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added cube segmantation specification and metastore CRUD operations.
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 0f4dbea
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseTableCrudCommand.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/commands/annotations/LensCubeSegmentationCommands.java PRE-CREATION
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeSegmentationCommands.java PRE-CREATION
> lens-cli/src/test/resources/seg1.xml PRE-CREATION
> lens-client/src/main/java/org/apache/lens/client/LensClient.java ea0cd76
> lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java d0f2b57
> lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 01098c4
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 643bcfe
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 02bbbbd
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegment.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegmentation.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeTableType.java ec1c837
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java ed78d74
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java deb5368
> lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java 0935509
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 65387c6
> lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java 0c2301b
> lens-examples/src/main/resources/seg1.xml PRE-CREATION
> lens-examples/src/test/resources/yaml/seg1.yaml PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 1b7d0f9
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java c11fd83
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java a1acd1a
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 6fd19a0
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java e7d545c
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java a541e9b
>
> Diff: https://reviews.apache.org/r/44612/diff/
>
>
> Testing
> -------
>
> Added unit test for cubesegmentation metastore operation. mvn clean install runs fine.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.337s]
> [INFO] Lens .............................................. SUCCESS [3.659s]
> [INFO] Lens API .......................................... SUCCESS [30.676s]
> [INFO] Lens API for server and extensions ................ SUCCESS [23.652s]
> [INFO] Lens Cube ......................................... SUCCESS [11:05.515s]
> [INFO] Lens DB storage ................................... SUCCESS [21.178s]
> [INFO] Lens Query Library ................................ SUCCESS [15.627s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:50.611s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [37.258s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [16.010s]
> [INFO] Lens Server ....................................... SUCCESS [16:20.812s]
> [INFO] Lens client ....................................... SUCCESS [35.875s]
> [INFO] Lens CLI .......................................... SUCCESS [53.330s]
> [INFO] Lens Examples ..................................... SUCCESS [13.044s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [1.557s]
> [INFO] Lens Distribution ................................. SUCCESS [9.528s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:22.121s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.779s]
> [INFO] Lens Regression ................................... SUCCESS [16.042s]
> [INFO] Lens UI ........................................... SUCCESS [29.459s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 36:51.163s
> [INFO] Finished at: Sat Mar 26 08:49:16 UTC 2016
> [INFO] Final Memory: 197M/1720M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Sushil Mohanty
>
>
Re: Review Request 44612: LENS-975 : Add cube-segmentation
specification
Posted by Sushil Mohanty <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44612/
-----------------------------------------------------------
(Updated March 26, 2016, 8:55 a.m.)
Review request for lens.
Changes
-------
Addressed review comments. Verified all unit tests.
Bugs: LENS-975
https://issues.apache.org/jira/browse/LENS-975
Repository: lens
Description
-------
Added cube segmantation specification and metastore CRUD operations.
Diffs (updated)
-----
lens-api/src/main/resources/cube-0.1.xsd 0f4dbea
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseTableCrudCommand.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/commands/annotations/LensCubeSegmentationCommands.java PRE-CREATION
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeSegmentationCommands.java PRE-CREATION
lens-cli/src/test/resources/seg1.xml PRE-CREATION
lens-client/src/main/java/org/apache/lens/client/LensClient.java ea0cd76
lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java d0f2b57
lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 01098c4
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 643bcfe
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 02bbbbd
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegment.java PRE-CREATION
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegmentation.java PRE-CREATION
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeTableType.java ec1c837
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java ed78d74
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java deb5368
lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java 0935509
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 65387c6
lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java 0c2301b
lens-examples/src/main/resources/seg1.xml PRE-CREATION
lens-examples/src/test/resources/yaml/seg1.yaml PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 1b7d0f9
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java c11fd83
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java a1acd1a
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 6fd19a0
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java e7d545c
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java a541e9b
Diff: https://reviews.apache.org/r/44612/diff/
Testing (updated)
-------
Added unit test for cubesegmentation metastore operation. mvn clean install runs fine.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.337s]
[INFO] Lens .............................................. SUCCESS [3.659s]
[INFO] Lens API .......................................... SUCCESS [30.676s]
[INFO] Lens API for server and extensions ................ SUCCESS [23.652s]
[INFO] Lens Cube ......................................... SUCCESS [11:05.515s]
[INFO] Lens DB storage ................................... SUCCESS [21.178s]
[INFO] Lens Query Library ................................ SUCCESS [15.627s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:50.611s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [37.258s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [16.010s]
[INFO] Lens Server ....................................... SUCCESS [16:20.812s]
[INFO] Lens client ....................................... SUCCESS [35.875s]
[INFO] Lens CLI .......................................... SUCCESS [53.330s]
[INFO] Lens Examples ..................................... SUCCESS [13.044s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [1.557s]
[INFO] Lens Distribution ................................. SUCCESS [9.528s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:22.121s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.779s]
[INFO] Lens Regression ................................... SUCCESS [16.042s]
[INFO] Lens UI ........................................... SUCCESS [29.459s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 36:51.163s
[INFO] Finished at: Sat Mar 26 08:49:16 UTC 2016
[INFO] Final Memory: 197M/1720M
[INFO] ------------------------------------------------------------------------
Thanks,
Sushil Mohanty
Re: Review Request 44612: LENS-975 : Add cube-segmentation
specification
Posted by Sushil Mohanty <su...@gmail.com>.
> On March 24, 2016, 11:16 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegmentation.java, line 63
> > <https://reviews.apache.org/r/44612/diff/4/?file=1311897#file1311897line63>
> >
> > What is this update for? I see addCubeSegmentProperties is already adding properties
Not required, I added this method to update properties in case of adding, dropping segments. addCubeSegmentProperties method takes care of this now.
- Sushil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44612/#review125240
-----------------------------------------------------------
On March 23, 2016, 3:32 p.m., Sushil Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44612/
> -----------------------------------------------------------
>
> (Updated March 23, 2016, 3:32 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-975
> https://issues.apache.org/jira/browse/LENS-975
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added cube segmantation specification and metastore CRUD operations.
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 0f4dbea
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseTableCrudCommand.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/commands/annotations/LensCubeSegmentationCommands.java PRE-CREATION
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeSegmentationCommands.java PRE-CREATION
> lens-cli/src/test/resources/seg1.xml PRE-CREATION
> lens-client/src/main/java/org/apache/lens/client/LensClient.java ea0cd76
> lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java d0f2b57
> lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 01098c4
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 643bcfe
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 02bbbbd
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegment.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegmentation.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeTableType.java ec1c837
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java ed78d74
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java deb5368
> lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java 0935509
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 65387c6
> lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java 0c2301b
> lens-examples/src/main/resources/seg1.xml PRE-CREATION
> lens-examples/src/test/resources/yaml/seg1.yaml PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 1b7d0f9
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java c11fd83
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java a1acd1a
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 6fd19a0
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java e7d545c
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java a541e9b
>
> Diff: https://reviews.apache.org/r/44612/diff/
>
>
> Testing
> -------
>
> Added unit test for cubesegmentation metastore operation. mvn clean install runs fine.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.832s]
> [INFO] Lens .............................................. SUCCESS [2.986s]
> [INFO] Lens API .......................................... SUCCESS [29.786s]
> [INFO] Lens API for server and extensions ................ SUCCESS [19.855s]
> [INFO] Lens Cube ......................................... SUCCESS [11:11.234s]
> [INFO] Lens DB storage ................................... SUCCESS [19.346s]
> [INFO] Lens Query Library ................................ SUCCESS [14.612s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:54.155s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [37.385s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [16.973s]
> [INFO] Lens Server ....................................... SUCCESS [16:20.530s]
> [INFO] Lens client ....................................... SUCCESS [37.472s]
> [INFO] Lens CLI .......................................... SUCCESS [53.129s]
> [INFO] Lens Examples ..................................... SUCCESS [12.618s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [1.706s]
> [INFO] Lens Distribution ................................. SUCCESS [9.672s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.894s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.837s]
> [INFO] Lens Regression ................................... SUCCESS [14.615s]
> [INFO] Lens UI ........................................... SUCCESS [29.106s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 36:51.827s
> [INFO] Finished at: Wed Mar 23 15:31:55 UTC 2016
> [INFO] Final Memory: 194M/1485M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Sushil Mohanty
>
>
Re: Review Request 44612: LENS-975 : Add cube-segmentation
specification
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44612/#review125240
-----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegment.java (line 25)
<https://reviews.apache.org/r/44612/#comment188032>
Can you implement Named?
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegmentation.java (line 63)
<https://reviews.apache.org/r/44612/#comment188033>
What is this update for? I see addCubeSegmentProperties is already adding properties
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegmentation.java (line 90)
<https://reviews.apache.org/r/44612/#comment188034>
You can use MetastoreUtil.addNameStrings, once CubeSegment implements Named
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegmentation.java (line 103)
<https://reviews.apache.org/r/44612/#comment188035>
Similarly call MetastoreUtil.getNamedStringValue
- Amareshwari Sriramadasu
On March 23, 2016, 3:32 p.m., Sushil Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44612/
> -----------------------------------------------------------
>
> (Updated March 23, 2016, 3:32 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-975
> https://issues.apache.org/jira/browse/LENS-975
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added cube segmantation specification and metastore CRUD operations.
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 0f4dbea
> lens-cli/src/main/java/org/apache/lens/cli/commands/BaseTableCrudCommand.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/commands/annotations/LensCubeSegmentationCommands.java PRE-CREATION
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeSegmentationCommands.java PRE-CREATION
> lens-cli/src/test/resources/seg1.xml PRE-CREATION
> lens-client/src/main/java/org/apache/lens/client/LensClient.java ea0cd76
> lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java d0f2b57
> lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 01098c4
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 643bcfe
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 02bbbbd
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegment.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegmentation.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeTableType.java ec1c837
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java ed78d74
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java deb5368
> lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java 0935509
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 65387c6
> lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java 0c2301b
> lens-examples/src/main/resources/seg1.xml PRE-CREATION
> lens-examples/src/test/resources/yaml/seg1.yaml PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 1b7d0f9
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java c11fd83
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java a1acd1a
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 6fd19a0
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java e7d545c
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java a541e9b
>
> Diff: https://reviews.apache.org/r/44612/diff/
>
>
> Testing
> -------
>
> Added unit test for cubesegmentation metastore operation. mvn clean install runs fine.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.832s]
> [INFO] Lens .............................................. SUCCESS [2.986s]
> [INFO] Lens API .......................................... SUCCESS [29.786s]
> [INFO] Lens API for server and extensions ................ SUCCESS [19.855s]
> [INFO] Lens Cube ......................................... SUCCESS [11:11.234s]
> [INFO] Lens DB storage ................................... SUCCESS [19.346s]
> [INFO] Lens Query Library ................................ SUCCESS [14.612s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:54.155s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [37.385s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [16.973s]
> [INFO] Lens Server ....................................... SUCCESS [16:20.530s]
> [INFO] Lens client ....................................... SUCCESS [37.472s]
> [INFO] Lens CLI .......................................... SUCCESS [53.129s]
> [INFO] Lens Examples ..................................... SUCCESS [12.618s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [1.706s]
> [INFO] Lens Distribution ................................. SUCCESS [9.672s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:21.894s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.837s]
> [INFO] Lens Regression ................................... SUCCESS [14.615s]
> [INFO] Lens UI ........................................... SUCCESS [29.106s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 36:51.827s
> [INFO] Finished at: Wed Mar 23 15:31:55 UTC 2016
> [INFO] Final Memory: 194M/1485M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Sushil Mohanty
>
>
Re: Review Request 44612: LENS-975 : Add cube-segmentation
specification
Posted by Sushil Mohanty <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44612/
-----------------------------------------------------------
(Updated March 23, 2016, 3:32 p.m.)
Review request for lens.
Changes
-------
updated test result.
Bugs: LENS-975
https://issues.apache.org/jira/browse/LENS-975
Repository: lens
Description
-------
Added cube segmantation specification and metastore CRUD operations.
Diffs
-----
lens-api/src/main/resources/cube-0.1.xsd 0f4dbea
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseTableCrudCommand.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/commands/annotations/LensCubeSegmentationCommands.java PRE-CREATION
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeSegmentationCommands.java PRE-CREATION
lens-cli/src/test/resources/seg1.xml PRE-CREATION
lens-client/src/main/java/org/apache/lens/client/LensClient.java ea0cd76
lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java d0f2b57
lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 01098c4
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 643bcfe
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 02bbbbd
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegment.java PRE-CREATION
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegmentation.java PRE-CREATION
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeTableType.java ec1c837
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java ed78d74
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java deb5368
lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java 0935509
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 65387c6
lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java 0c2301b
lens-examples/src/main/resources/seg1.xml PRE-CREATION
lens-examples/src/test/resources/yaml/seg1.yaml PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 1b7d0f9
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java c11fd83
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java a1acd1a
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 6fd19a0
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java e7d545c
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java a541e9b
Diff: https://reviews.apache.org/r/44612/diff/
Testing (updated)
-------
Added unit test for cubesegmentation metastore operation. mvn clean install runs fine.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [1.832s]
[INFO] Lens .............................................. SUCCESS [2.986s]
[INFO] Lens API .......................................... SUCCESS [29.786s]
[INFO] Lens API for server and extensions ................ SUCCESS [19.855s]
[INFO] Lens Cube ......................................... SUCCESS [11:11.234s]
[INFO] Lens DB storage ................................... SUCCESS [19.346s]
[INFO] Lens Query Library ................................ SUCCESS [14.612s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:54.155s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [37.385s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [16.973s]
[INFO] Lens Server ....................................... SUCCESS [16:20.530s]
[INFO] Lens client ....................................... SUCCESS [37.472s]
[INFO] Lens CLI .......................................... SUCCESS [53.129s]
[INFO] Lens Examples ..................................... SUCCESS [12.618s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [1.706s]
[INFO] Lens Distribution ................................. SUCCESS [9.672s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:21.894s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.837s]
[INFO] Lens Regression ................................... SUCCESS [14.615s]
[INFO] Lens UI ........................................... SUCCESS [29.106s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 36:51.827s
[INFO] Finished at: Wed Mar 23 15:31:55 UTC 2016
[INFO] Final Memory: 194M/1485M
[INFO] ------------------------------------------------------------------------
Thanks,
Sushil Mohanty
Re: Review Request 44612: LENS-975 : Add cube-segmentation
specification
Posted by Sushil Mohanty <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44612/
-----------------------------------------------------------
(Updated March 23, 2016, 1:52 p.m.)
Review request for lens.
Changes
-------
Addressed review comments.
Will update test result shortly.
Bugs: LENS-975
https://issues.apache.org/jira/browse/LENS-975
Repository: lens
Description
-------
Added cube segmantation specification and metastore CRUD operations.
Diffs (updated)
-----
lens-api/src/main/resources/cube-0.1.xsd 0f4dbea
lens-cli/src/main/java/org/apache/lens/cli/commands/BaseTableCrudCommand.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/commands/annotations/LensCubeSegmentationCommands.java PRE-CREATION
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeSegmentationCommands.java PRE-CREATION
lens-cli/src/test/resources/seg1.xml PRE-CREATION
lens-client/src/main/java/org/apache/lens/client/LensClient.java ea0cd76
lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java d0f2b57
lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 01098c4
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 643bcfe
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 02bbbbd
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegment.java PRE-CREATION
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegmentation.java PRE-CREATION
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeTableType.java ec1c837
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java ed78d74
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java deb5368
lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java 0935509
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 65387c6
lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java 0c2301b
lens-examples/src/main/resources/seg1.xml PRE-CREATION
lens-examples/src/test/resources/yaml/seg1.yaml PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 1b7d0f9
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java c11fd83
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java a1acd1a
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 6fd19a0
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java e7d545c
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java a541e9b
Diff: https://reviews.apache.org/r/44612/diff/
Testing
-------
Added unit test for cubesegmentation metastore operation. mvn clean install runs fine.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.210s]
[INFO] Lens .............................................. SUCCESS [3.229s]
[INFO] Lens API .......................................... SUCCESS [28.902s]
[INFO] Lens API for server and extensions ................ SUCCESS [20.780s]
[INFO] Lens Cube ......................................... SUCCESS [11:18.929s]
[INFO] Lens DB storage ................................... SUCCESS [19.804s]
[INFO] Lens Query Library ................................ SUCCESS [15.394s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:49.339s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [37.632s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [21.508s]
[INFO] Lens Server ....................................... SUCCESS [17:04.269s]
[INFO] Lens client ....................................... SUCCESS [39.871s]
[INFO] Lens CLI .......................................... SUCCESS [57.974s]
[INFO] Lens Examples ..................................... SUCCESS [12.472s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [1.738s]
[INFO] Lens Distribution ................................. SUCCESS [11.260s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:27.726s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.879s]
[INFO] Lens Regression ................................... SUCCESS [16.056s]
[INFO] Lens UI ........................................... SUCCESS [28.700s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 38:00.676s
[INFO] Finished at: Fri Mar 18 11:10:09 UTC 2016
[INFO] Final Memory: 195M/1539M
[INFO] ------------------------------------------------------------------------
Thanks,
Sushil Mohanty
Re: Review Request 44612: LENS-975 : Add cube-segmentation
specification
Posted by Sushil Mohanty <su...@gmail.com>.
> On March 19, 2016, 2:20 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java, line 719
> > <https://reviews.apache.org/r/44612/diff/3/?file=1305155#file1305155line719>
> >
> > Skip properties check should be in this method.
added.
> On March 19, 2016, 2:20 a.m., Amareshwari Sriramadasu wrote:
> > lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java, line 685
> > <https://reviews.apache.org/r/44612/diff/3/?file=1305155#file1305155line685>
> >
> > Instead with should check - ! (prop.toLowerCase().startsWith(MetastoreUtil.SEGMENTATION_PREFIX)
changed to !(prop.toLowerCase().startsWith(MetastoreConstants.SEGMENTATION_KEY_PFX))
> On March 19, 2016, 2:20 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegmentation.java, line 33
> > <https://reviews.apache.org/r/44612/diff/3/?file=1305143#file1305143line33>
> >
> > Properties of the cubeSegments are not stored here?
Moved this to new class.
- Sushil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44612/#review124358
-----------------------------------------------------------
On March 18, 2016, 11:12 a.m., Sushil Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44612/
> -----------------------------------------------------------
>
> (Updated March 18, 2016, 11:12 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-975
> https://issues.apache.org/jira/browse/LENS-975
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added cube segmantation specification and metastore CRUD operations.
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 0f4dbea
> lens-cli/src/main/java/org/apache/lens/cli/commands/IrrationalTableCrudCommand.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/commands/annotations/LensCubeSegmentationCommands.java PRE-CREATION
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeSegmentationCommands.java PRE-CREATION
> lens-cli/src/test/resources/seg1.xml PRE-CREATION
> lens-client/src/main/java/org/apache/lens/client/LensClient.java ea0cd76
> lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java d0f2b57
> lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 01098c4
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 643bcfe
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 02bbbbd
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegmentation.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeTableType.java ec1c837
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java ed78d74
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java deb5368
> lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java 0935509
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 65387c6
> lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java 0c2301b
> lens-examples/src/main/resources/cube-segmentation1.xml PRE-CREATION
> lens-examples/src/test/resources/yaml/cube-segmentation1.yaml PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 1b7d0f9
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java c11fd83
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java a1acd1a
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 6fd19a0
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java e7d545c
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java a541e9b
>
> Diff: https://reviews.apache.org/r/44612/diff/
>
>
> Testing
> -------
>
> Added unit test for cubesegmentation metastore operation. mvn clean install runs fine.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.210s]
> [INFO] Lens .............................................. SUCCESS [3.229s]
> [INFO] Lens API .......................................... SUCCESS [28.902s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.780s]
> [INFO] Lens Cube ......................................... SUCCESS [11:18.929s]
> [INFO] Lens DB storage ................................... SUCCESS [19.804s]
> [INFO] Lens Query Library ................................ SUCCESS [15.394s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:49.339s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [37.632s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [21.508s]
> [INFO] Lens Server ....................................... SUCCESS [17:04.269s]
> [INFO] Lens client ....................................... SUCCESS [39.871s]
> [INFO] Lens CLI .......................................... SUCCESS [57.974s]
> [INFO] Lens Examples ..................................... SUCCESS [12.472s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [1.738s]
> [INFO] Lens Distribution ................................. SUCCESS [11.260s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:27.726s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.879s]
> [INFO] Lens Regression ................................... SUCCESS [16.056s]
> [INFO] Lens UI ........................................... SUCCESS [28.700s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 38:00.676s
> [INFO] Finished at: Fri Mar 18 11:10:09 UTC 2016
> [INFO] Final Memory: 195M/1539M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Sushil Mohanty
>
>
Re: Review Request 44612: LENS-975 : Add cube-segmentation
specification
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44612/#review124358
-----------------------------------------------------------
lens-api/src/main/resources/cube-0.1.xsd (line 1026)
<https://reviews.apache.org/r/44612/#comment186858>
Should say different in underlying cube? instead of cubes?
lens-cli/src/main/java/org/apache/lens/cli/commands/IrrationalTableCrudCommand.java (line 26)
<https://reviews.apache.org/r/44612/#comment186860>
Irrational looks more a negative word. Do you want to call it Base or Generic ?
lens-cli/src/test/resources/seg1.xml (line 31)
<https://reviews.apache.org/r/44612/#comment186863>
Property should be lens.metastore.cube.column.mapping
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegmentation.java (line 33)
<https://reviews.apache.org/r/44612/#comment186864>
Properties of the cubeSegments are not stored here?
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java (line 64)
<https://reviews.apache.org/r/44612/#comment186865>
Not documented in xsd?
lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java (line 169)
<https://reviews.apache.org/r/44612/#comment186868>
Empty method? Can you add example creation?
lens-examples/src/main/resources/cube-segmentation1.xml (line 30)
<https://reviews.apache.org/r/44612/#comment186870>
Property should lens.metastore.cube.column.mapping.
lens-examples/src/main/resources/cube-segmentation1.xml (line 35)
<https://reviews.apache.org/r/44612/#comment186872>
Can you give separate for propeties for each segment ?
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java (line 675)
<https://reviews.apache.org/r/44612/#comment186877>
Can we rename method - cubeSegmentationFromXCubeSegmentation ?
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java (line 685)
<https://reviews.apache.org/r/44612/#comment186874>
Instead with should check - ! (prop.toLowerCase().startsWith(MetastoreUtil.SEGMENTATION_PREFIX)
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java (line 711)
<https://reviews.apache.org/r/44612/#comment186876>
Can we name method xcubeSegmenationFromCubeSegmentation?
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java (line 719)
<https://reviews.apache.org/r/44612/#comment186875>
Skip properties check should be in this method.
- Amareshwari Sriramadasu
On March 18, 2016, 11:12 a.m., Sushil Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44612/
> -----------------------------------------------------------
>
> (Updated March 18, 2016, 11:12 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-975
> https://issues.apache.org/jira/browse/LENS-975
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added cube segmantation specification and metastore CRUD operations.
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 0f4dbea
> lens-cli/src/main/java/org/apache/lens/cli/commands/IrrationalTableCrudCommand.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/commands/annotations/LensCubeSegmentationCommands.java PRE-CREATION
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeSegmentationCommands.java PRE-CREATION
> lens-cli/src/test/resources/seg1.xml PRE-CREATION
> lens-client/src/main/java/org/apache/lens/client/LensClient.java ea0cd76
> lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java d0f2b57
> lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 01098c4
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 643bcfe
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 02bbbbd
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegmentation.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeTableType.java ec1c837
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java ed78d74
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java deb5368
> lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java 0935509
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 65387c6
> lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java 0c2301b
> lens-examples/src/main/resources/cube-segmentation1.xml PRE-CREATION
> lens-examples/src/test/resources/yaml/cube-segmentation1.yaml PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 1b7d0f9
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java c11fd83
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java a1acd1a
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 6fd19a0
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java e7d545c
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java a541e9b
>
> Diff: https://reviews.apache.org/r/44612/diff/
>
>
> Testing
> -------
>
> Added unit test for cubesegmentation metastore operation. mvn clean install runs fine.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.210s]
> [INFO] Lens .............................................. SUCCESS [3.229s]
> [INFO] Lens API .......................................... SUCCESS [28.902s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.780s]
> [INFO] Lens Cube ......................................... SUCCESS [11:18.929s]
> [INFO] Lens DB storage ................................... SUCCESS [19.804s]
> [INFO] Lens Query Library ................................ SUCCESS [15.394s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:49.339s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [37.632s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [21.508s]
> [INFO] Lens Server ....................................... SUCCESS [17:04.269s]
> [INFO] Lens client ....................................... SUCCESS [39.871s]
> [INFO] Lens CLI .......................................... SUCCESS [57.974s]
> [INFO] Lens Examples ..................................... SUCCESS [12.472s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [1.738s]
> [INFO] Lens Distribution ................................. SUCCESS [11.260s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:27.726s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.879s]
> [INFO] Lens Regression ................................... SUCCESS [16.056s]
> [INFO] Lens UI ........................................... SUCCESS [28.700s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 38:00.676s
> [INFO] Finished at: Fri Mar 18 11:10:09 UTC 2016
> [INFO] Final Memory: 195M/1539M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Sushil Mohanty
>
>
Re: Review Request 44612: LENS-975 : Add cube-segmentation
specification
Posted by Sushil Mohanty <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44612/
-----------------------------------------------------------
(Updated March 18, 2016, 11:12 a.m.)
Review request for lens.
Changes
-------
Addressed missing review comment and fixed typo. vertified all test cases.
Bugs: LENS-975
https://issues.apache.org/jira/browse/LENS-975
Repository: lens
Description
-------
Added cube segmantation specification and metastore CRUD operations.
Diffs (updated)
-----
lens-api/src/main/resources/cube-0.1.xsd 0f4dbea
lens-cli/src/main/java/org/apache/lens/cli/commands/IrrationalTableCrudCommand.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/commands/annotations/LensCubeSegmentationCommands.java PRE-CREATION
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeSegmentationCommands.java PRE-CREATION
lens-cli/src/test/resources/seg1.xml PRE-CREATION
lens-client/src/main/java/org/apache/lens/client/LensClient.java ea0cd76
lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java d0f2b57
lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 01098c4
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 643bcfe
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 02bbbbd
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegmentation.java PRE-CREATION
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeTableType.java ec1c837
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java ed78d74
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java deb5368
lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java 0935509
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 65387c6
lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java 0c2301b
lens-examples/src/main/resources/cube-segmentation1.xml PRE-CREATION
lens-examples/src/test/resources/yaml/cube-segmentation1.yaml PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 1b7d0f9
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java c11fd83
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java a1acd1a
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 6fd19a0
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java e7d545c
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java a541e9b
Diff: https://reviews.apache.org/r/44612/diff/
Testing (updated)
-------
Added unit test for cubesegmentation metastore operation. mvn clean install runs fine.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.210s]
[INFO] Lens .............................................. SUCCESS [3.229s]
[INFO] Lens API .......................................... SUCCESS [28.902s]
[INFO] Lens API for server and extensions ................ SUCCESS [20.780s]
[INFO] Lens Cube ......................................... SUCCESS [11:18.929s]
[INFO] Lens DB storage ................................... SUCCESS [19.804s]
[INFO] Lens Query Library ................................ SUCCESS [15.394s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:49.339s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [37.632s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [21.508s]
[INFO] Lens Server ....................................... SUCCESS [17:04.269s]
[INFO] Lens client ....................................... SUCCESS [39.871s]
[INFO] Lens CLI .......................................... SUCCESS [57.974s]
[INFO] Lens Examples ..................................... SUCCESS [12.472s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [1.738s]
[INFO] Lens Distribution ................................. SUCCESS [11.260s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:27.726s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [1.879s]
[INFO] Lens Regression ................................... SUCCESS [16.056s]
[INFO] Lens UI ........................................... SUCCESS [28.700s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 38:00.676s
[INFO] Finished at: Fri Mar 18 11:10:09 UTC 2016
[INFO] Final Memory: 195M/1539M
[INFO] ------------------------------------------------------------------------
Thanks,
Sushil Mohanty
Re: Review Request 44612: LENS-975 : Add cube-segmentation
specification
Posted by Sushil Mohanty <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44612/
-----------------------------------------------------------
(Updated March 17, 2016, 9:04 a.m.)
Review request for lens.
Changes
-------
- Addressed revirew comments.
- lens-cli CRUD implementations and added unit tests.
- Added new segment property lens.metastore.cube.column.mapping.
Bugs: LENS-975
https://issues.apache.org/jira/browse/LENS-975
Repository: lens
Description
-------
Added cube segmantation specification and metastore CRUD operations.
Diffs (updated)
-----
lens-api/src/main/resources/cube-0.1.xsd 0f4dbea
lens-cli/src/main/java/org/apache/lens/cli/commands/IrrationalTableCrudCommand.java PRE-CREATION
lens-cli/src/main/java/org/apache/lens/cli/commands/annotations/LensCubeSegmentationCommands.java PRE-CREATION
lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeSegmentationCommands.java PRE-CREATION
lens-cli/src/test/resources/seg1.xml PRE-CREATION
lens-client/src/main/java/org/apache/lens/client/LensClient.java ea0cd76
lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java d0f2b57
lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 01098c4
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 643bcfe
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 02bbbbd
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegmentation.java PRE-CREATION
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeTableType.java ec1c837
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java ed78d74
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java deb5368
lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java 0935509
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 65387c6
lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java 0c2301b
lens-examples/src/main/resources/cube-segmentation1.xml PRE-CREATION
lens-examples/src/test/resources/yaml/cube-segmentation1.yaml PRE-CREATION
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 1b7d0f9
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java c11fd83
lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java a1acd1a
lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 6fd19a0
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java e7d545c
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java a541e9b
Diff: https://reviews.apache.org/r/44612/diff/
Testing (updated)
-------
Added unit test for cubesegmentation metastore operation. mvn clean install runs fine.
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.265s]
[INFO] Lens .............................................. SUCCESS [4.354s]
[INFO] Lens API .......................................... SUCCESS [29.857s]
[INFO] Lens API for server and extensions ................ SUCCESS [22.179s]
[INFO] Lens Cube ......................................... SUCCESS [11:10.012s]
[INFO] Lens DB storage ................................... SUCCESS [20.014s]
[INFO] Lens Query Library ................................ SUCCESS [15.666s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:48.066s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [36.218s]
[INFO] Lens Elastic Search Driver ........................ SUCCESS [15.893s]
[INFO] Lens Server ....................................... SUCCESS [16:37.655s]
[INFO] Lens client ....................................... SUCCESS [47.034s]
[INFO] Lens CLI .......................................... SUCCESS [57.465s]
[INFO] Lens Examples ..................................... SUCCESS [15.509s]
[INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [1.209s]
[INFO] Lens Distribution ................................. SUCCESS [22.002s]
[INFO] Lens ML Lib ....................................... SUCCESS [1:36.655s]
[INFO] Lens ML Ext Distribution .......................... SUCCESS [2.019s]
[INFO] Lens Regression ................................... SUCCESS [14.401s]
[INFO] Lens UI ........................................... SUCCESS [29.585s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 37:49.065s
[INFO] Finished at: Thu Mar 17 08:51:02 UTC 2016
[INFO] Final Memory: 173M/2915M
[INFO] ------------------------------------------------------------------------
Thanks,
Sushil Mohanty
Re: Review Request 44612: LENS-975 : Add cube-segmentation
specification
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44612/#review123112
-----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java (line 86)
<https://reviews.apache.org/r/44612/#comment185273>
Map defined twice?
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java (line 2321)
<https://reviews.apache.org/r/44612/#comment185274>
alter should just take new CubeSegmentation definition and update it, instead of candidate-cubes
lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java (line 60)
<https://reviews.apache.org/r/44612/#comment185276>
Can we put cube.segmentation.internal. as the prefix and skip these properties when we are returning them to user ?
lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java (line 575)
<https://reviews.apache.org/r/44612/#comment185277>
Please add oneliner for each method, describing what is each method doing ?
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java (line 157)
<https://reviews.apache.org/r/44612/#comment185279>
Can we ignore cascade option instead of exception? I dont think we need to cascade anything from segmentation.
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java (line 852)
<https://reviews.apache.org/r/44612/#comment185280>
We need to consistent on the resource name. I see it is cubesegmentations here and segmentations in some other places.
lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java (line 880)
<https://reviews.apache.org/r/44612/#comment185281>
We need not have a cascade option here.
- Amareshwari Sriramadasu
On March 10, 2016, 8:33 a.m., Sushil Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44612/
> -----------------------------------------------------------
>
> (Updated March 10, 2016, 8:33 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-975
> https://issues.apache.org/jira/browse/LENS-975
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added cube segmantation specification and metastore CRUD operations.
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 0f4dbea
> lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 01098c4
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 643bcfe
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 02bbbbd
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegmentation.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeTableType.java ec1c837
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java ed78d74
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java deb5368
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 65387c6
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java c11fd83
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java a1acd1a
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 6fd19a0
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java e7d545c
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java a541e9b
>
> Diff: https://reviews.apache.org/r/44612/diff/
>
>
> Testing
> -------
>
> Added unit test for cubesegmentation metastore operation. mvn clean install runs fine.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.028s]
> [INFO] Lens .............................................. SUCCESS [3.135s]
> [INFO] Lens API .......................................... SUCCESS [27.415s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.108s]
> [INFO] Lens Cube ......................................... SUCCESS [11:11.002s]
> [INFO] Lens DB storage ................................... SUCCESS [19.140s]
> [INFO] Lens Query Library ................................ SUCCESS [15.036s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:46.067s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [39.592s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [16.465s]
> [INFO] Lens Server ....................................... SUCCESS [16:03.100s]
> [INFO] Lens client ....................................... SUCCESS [36.084s]
> [INFO] Lens CLI .......................................... SUCCESS [53.148s]
> [INFO] Lens Examples ..................................... SUCCESS [12.655s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.747s]
> [INFO] Lens Distribution ................................. SUCCESS [9.223s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:20.165s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.773s]
> [INFO] Lens Regression ................................... SUCCESS [13.778s]
> [INFO] Lens UI ........................................... SUCCESS [28.603s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 36:20.155s
> [INFO] Finished at: Thu Mar 10 08:16:00 UTC 2016
> [INFO] Final Memory: 210M/2450M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Sushil Mohanty
>
>
Re: Review Request 44612: LENS-975 : Add cube-segmentation
specification
Posted by Sushil Mohanty <su...@gmail.com>.
> On March 11, 2016, 8:11 a.m., Rajat Khandelwal wrote:
> > lens-api/src/main/resources/cube-0.1.xsd, lines 1013-1275
> > <https://reviews.apache.org/r/44612/diff/1/?file=1294162#file1294162line1013>
> >
> > The `toString` needs to be checked. Can you add new test cases in `lens-examples/src/main/resources` and `lens-examples/src/test/resources/yaml`?
added.
> On March 11, 2016, 8:11 a.m., Rajat Khandelwal wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java, line 803
> > <https://reviews.apache.org/r/44612/diff/1/?file=1294165#file1294165line803>
> >
> > Can the argument be `CubeSegmentation` instead of `AbstractCubeTable`?
Yes it can be. Cube fact is using AbstractCubeTable. Missed in the current patch, will take care in the next patch.
> On March 11, 2016, 8:11 a.m., Rajat Khandelwal wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegmentation.java, line 40
> > <https://reviews.apache.org/r/44612/diff/1/?file=1294166#file1294166line40>
> >
> > Do we need a dummy column?
Yes we need this for the super constructor, AbstractCubeTable does the same.
> On March 11, 2016, 8:11 a.m., Rajat Khandelwal wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegmentation.java, lines 136-158
> > <https://reviews.apache.org/r/44612/diff/1/?file=1294166#file1294166line136>
> >
> > Should these be part of `AbstractCubeTable`? Since it seems now most of the entities have start-end times.
Moving these methods to AbstractCubeTable need implementation in all its clildren i.e storage, dimension, derived_cube which might not be relevant to them. Should we add one more abstraction in between AbstractCubeTable and CubeFactTable/CubeSegmentation? In this case the property names are different.
- Sushil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44612/#review123110
-----------------------------------------------------------
On March 17, 2016, 9:04 a.m., Sushil Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44612/
> -----------------------------------------------------------
>
> (Updated March 17, 2016, 9:04 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-975
> https://issues.apache.org/jira/browse/LENS-975
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added cube segmantation specification and metastore CRUD operations.
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 0f4dbea
> lens-cli/src/main/java/org/apache/lens/cli/commands/IrrationalTableCrudCommand.java PRE-CREATION
> lens-cli/src/main/java/org/apache/lens/cli/commands/annotations/LensCubeSegmentationCommands.java PRE-CREATION
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeSegmentationCommands.java PRE-CREATION
> lens-cli/src/test/resources/seg1.xml PRE-CREATION
> lens-client/src/main/java/org/apache/lens/client/LensClient.java ea0cd76
> lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java d0f2b57
> lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 01098c4
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 643bcfe
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 02bbbbd
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegmentation.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeTableType.java ec1c837
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java ed78d74
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java deb5368
> lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java 0935509
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 65387c6
> lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java 0c2301b
> lens-examples/src/main/resources/cube-segmentation1.xml PRE-CREATION
> lens-examples/src/test/resources/yaml/cube-segmentation1.yaml PRE-CREATION
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 1b7d0f9
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java c11fd83
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java a1acd1a
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 6fd19a0
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java e7d545c
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java a541e9b
>
> Diff: https://reviews.apache.org/r/44612/diff/
>
>
> Testing
> -------
>
> Added unit test for cubesegmentation metastore operation. mvn clean install runs fine.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.265s]
> [INFO] Lens .............................................. SUCCESS [4.354s]
> [INFO] Lens API .......................................... SUCCESS [29.857s]
> [INFO] Lens API for server and extensions ................ SUCCESS [22.179s]
> [INFO] Lens Cube ......................................... SUCCESS [11:10.012s]
> [INFO] Lens DB storage ................................... SUCCESS [20.014s]
> [INFO] Lens Query Library ................................ SUCCESS [15.666s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:48.066s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.218s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [15.893s]
> [INFO] Lens Server ....................................... SUCCESS [16:37.655s]
> [INFO] Lens client ....................................... SUCCESS [47.034s]
> [INFO] Lens CLI .......................................... SUCCESS [57.465s]
> [INFO] Lens Examples ..................................... SUCCESS [15.509s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [1.209s]
> [INFO] Lens Distribution ................................. SUCCESS [22.002s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:36.655s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.019s]
> [INFO] Lens Regression ................................... SUCCESS [14.401s]
> [INFO] Lens UI ........................................... SUCCESS [29.585s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 37:49.065s
> [INFO] Finished at: Thu Mar 17 08:51:02 UTC 2016
> [INFO] Final Memory: 173M/2915M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Sushil Mohanty
>
>
Re: Review Request 44612: LENS-975 : Add cube-segmentation
specification
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44612/#review123110
-----------------------------------------------------------
lens-api/src/main/resources/cube-0.1.xsd (lines 1013 - 1275)
<https://reviews.apache.org/r/44612/#comment185262>
The `toString` needs to be checked. Can you add new test cases in `lens-examples/src/main/resources` and `lens-examples/src/test/resources/yaml`?
lens-api/src/main/resources/cube-0.1.xsd (line 1291)
<https://reviews.apache.org/r/44612/#comment185261>
fact has `cube_name` field for this purpose. Can we name this to `cube_name` too?
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java (line 803)
<https://reviews.apache.org/r/44612/#comment185263>
Can the argument be `CubeSegmentation` instead of `AbstractCubeTable`?
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegmentation.java (line 40)
<https://reviews.apache.org/r/44612/#comment185267>
Do we need a dummy column?
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegmentation.java (line 85)
<https://reviews.apache.org/r/44612/#comment185268>
Shall we take care of the case when comma list of cubes is a string larger than 4000?
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegmentation.java (lines 136 - 158)
<https://reviews.apache.org/r/44612/#comment185271>
Should these be part of `AbstractCubeTable`? Since it seems now most of the entities have start-end times.
- Rajat Khandelwal
On March 10, 2016, 2:03 p.m., Sushil Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44612/
> -----------------------------------------------------------
>
> (Updated March 10, 2016, 2:03 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-975
> https://issues.apache.org/jira/browse/LENS-975
>
>
> Repository: lens
>
>
> Description
> -------
>
> Added cube segmantation specification and metastore CRUD operations.
>
>
> Diffs
> -----
>
> lens-api/src/main/resources/cube-0.1.xsd 0f4dbea
> lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java 01098c4
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java 643bcfe
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 02bbbbd
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegmentation.java PRE-CREATION
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeTableType.java ec1c837
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java ed78d74
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java deb5368
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 65387c6
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java c11fd83
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java a1acd1a
> lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 6fd19a0
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java e7d545c
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java a541e9b
>
> Diff: https://reviews.apache.org/r/44612/diff/
>
>
> Testing
> -------
>
> Added unit test for cubesegmentation metastore operation. mvn clean install runs fine.
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.028s]
> [INFO] Lens .............................................. SUCCESS [3.135s]
> [INFO] Lens API .......................................... SUCCESS [27.415s]
> [INFO] Lens API for server and extensions ................ SUCCESS [20.108s]
> [INFO] Lens Cube ......................................... SUCCESS [11:11.002s]
> [INFO] Lens DB storage ................................... SUCCESS [19.140s]
> [INFO] Lens Query Library ................................ SUCCESS [15.036s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:46.067s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [39.592s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [16.465s]
> [INFO] Lens Server ....................................... SUCCESS [16:03.100s]
> [INFO] Lens client ....................................... SUCCESS [36.084s]
> [INFO] Lens CLI .......................................... SUCCESS [53.148s]
> [INFO] Lens Examples ..................................... SUCCESS [12.655s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.747s]
> [INFO] Lens Distribution ................................. SUCCESS [9.223s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:20.165s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.773s]
> [INFO] Lens Regression ................................... SUCCESS [13.778s]
> [INFO] Lens UI ........................................... SUCCESS [28.603s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 36:20.155s
> [INFO] Finished at: Thu Mar 10 08:16:00 UTC 2016
> [INFO] Final Memory: 210M/2450M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Sushil Mohanty
>
>