You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@wicket.apache.org by GitBox <gi...@apache.org> on 2022/04/24 18:08:26 UTC

[GitHub] [wicket] astange1 commented on pull request #513: More efficient hashcode computations

astange1 commented on PR #513:
URL: https://github.com/apache/wicket/pull/513#issuecomment-1107890271

   Hello, I believe I have made all the code formatting chnages that were requested.  I also made an additional update to the hashcode computation for a ResourceReference class, which should result in improved JMH performance.   
   
   @theigl   The remaining memory allocation in the posted JMH results should be resolved now.   Can you kindly re-run the results with this updated code to confirm?    My JMH setup is running on a custom JDK19 build, and it would be a pain for me to set up here for Wicket.
   
   FYI.  Wicket-utils has an Objects.hashCode() implementation that should be removed in favor of using the one in the JDK.   It is used by the Model class. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org