You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tomee.apache.org by tv...@apache.org on 2013/12/05 01:30:40 UTC
svn commit: r1547974 - in
/tomee/tomee/trunk/container/openejb-core/src/main: config/
java/org/apache/openejb/ java/org/apache/openejb/assembler/classic/
java/org/apache/openejb/async/ java/org/apache/openejb/cdi/
java/org/apache/openejb/classloader/ j...
Author: tveronezi
Date: Thu Dec 5 00:30:39 2013
New Revision: 1547974
URL: http://svn.apache.org/r1547974
Log:
https://issues.apache.org/jira/browse/OPENEJB-2060
Modified:
tomee/tomee/trunk/container/openejb-core/src/main/config/checkstyle.xml
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/OpenEjbContainer.java
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/async/AsynchronousPool.java
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/cdi/OWBContextThreadListener.java
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/cdi/OpenEJBLifecycle.java
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/cdi/OptimizedLoaderService.java
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/cdi/RequestScopedThreadContextListener.java
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/classloader/ClassLoaderConfigurer.java
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/FinderFactory.java
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/PersistenceContextAnnFactory.java
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/sys/SaxAppCtxConfig.java
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/UnauthenticatedPrincipal.java
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/cmp/cmp2/Cmp2Generator.java
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/ivm/IntraVmCopyMonitor.java
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/managed/ManagedContainer.java
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/managed/SimpleCache.java
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/security/jaas/ScriptLoginModule.java
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/security/jaas/ServiceProviderLoginModule.java
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/stateful/SimpleCache.java
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/stateful/StatefulContainer.java
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/stateless/StatelessInstanceManager.java
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/transaction/EjbTransactionUtil.java
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/transaction/SimpleWorkManager.java
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/JaxWsUtils.java
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/monitoring/DynamicMBeanWrapper.java
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/monitoring/LocalMBeanServer.java
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/resource/TransactionManagerWrapper.java
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/resource/quartz/QuartzResourceAdapter.java
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/Contexts.java
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/Debug.java
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/Duration.java
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/HexConverter.java
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/Index.java
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/JndiTreeBrowser.java
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/OpenEjbVersion.java
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/PerformanceTimer.java
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/Pool.java
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/SafeToolkit.java
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/SimpleJSonParser.java
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/URLs.java
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/helper/CommandHelper.java
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/proxy/DynamicProxyImplFactory.java
tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/proxy/ProxyEJB.java
Modified: tomee/tomee/trunk/container/openejb-core/src/main/config/checkstyle.xml
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/config/checkstyle.xml?rev=1547974&r1=1547973&r2=1547974&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/config/checkstyle.xml (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/config/checkstyle.xml Thu Dec 5 00:30:39 2013
@@ -133,7 +133,7 @@
<!-- Checks for class design -->
<!-- See http://checkstyle.sf.net/config_design.html -->
- <!--<module name="FinalClass"/>-->
+ <module name="FinalClass"/>
<!--<module name="HideUtilityClassConstructor"/>-->
<!--<module name="InterfaceIsType"/>-->
<!--<module name="VisibilityModifier">-->
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/OpenEjbContainer.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/OpenEjbContainer.java?rev=1547974&r1=1547973&r2=1547974&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/OpenEjbContainer.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/OpenEjbContainer.java Thu Dec 5 00:30:39 2013
@@ -91,7 +91,7 @@ import static org.apache.openejb.cdi.Sco
/**
* @version $Rev$ $Date$
*/
-public class OpenEjbContainer extends EJBContainer {
+public final class OpenEjbContainer extends EJBContainer {
static {
// if tomee embedded was ran we'll lost log otherwise
final String logManger = System.getProperty("java.util.logging.manager");
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java?rev=1547974&r1=1547973&r2=1547974&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/assembler/classic/Assembler.java Thu Dec 5 00:30:39 2013
@@ -2701,7 +2701,7 @@ public class Assembler extends Assembler
}
}
- private static class DestroyingResource {
+ private static final class DestroyingResource {
private final String name;
private final String clazz;
private final Object instance;
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/async/AsynchronousPool.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/async/AsynchronousPool.java?rev=1547974&r1=1547973&r2=1547974&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/async/AsynchronousPool.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/async/AsynchronousPool.java Thu Dec 5 00:30:39 2013
@@ -91,7 +91,7 @@ public class AsynchronousPool {
}
}
- private class AsynchronousCall implements Callable<Object> {
+ private final class AsynchronousCall implements Callable<Object> {
private final Callable<Object> callable;
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/cdi/OWBContextThreadListener.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/cdi/OWBContextThreadListener.java?rev=1547974&r1=1547973&r2=1547974&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/cdi/OWBContextThreadListener.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/cdi/OWBContextThreadListener.java Thu Dec 5 00:30:39 2013
@@ -43,7 +43,6 @@ public class OWBContextThreadListener im
AppContext appContext = moduleContext.getAppContext();
WebBeansContext owbContext = appContext.getWebBeansContext();
if (owbContext == null) {
-// throw new IllegalStateException("WebBeansContext not initialized in appContext " + appContext);
return;
}
Object oldOWBContext = singletonService.contextEntered(owbContext);
@@ -58,7 +57,7 @@ public class OWBContextThreadListener im
singletonService.contextExited(oldOWBContext.getContext());
}
- private static class OWBContextHolder {
+ private static final class OWBContextHolder {
private final Object context;
private OWBContextHolder(Object context) {
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/cdi/OpenEJBLifecycle.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/cdi/OpenEJBLifecycle.java?rev=1547974&r1=1547973&r2=1547974&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/cdi/OpenEJBLifecycle.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/cdi/OpenEJBLifecycle.java Thu Dec 5 00:30:39 2013
@@ -363,7 +363,7 @@ public class OpenEJBLifecycle implements
* clears unused conversations.
*
*/
- private static class ConversationCleaner implements Runnable
+ private static final class ConversationCleaner implements Runnable
{
private final WebBeansContext webBeansContext;
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/cdi/OptimizedLoaderService.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/cdi/OptimizedLoaderService.java?rev=1547974&r1=1547973&r2=1547974&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/cdi/OptimizedLoaderService.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/cdi/OptimizedLoaderService.java Thu Dec 5 00:30:39 2013
@@ -119,7 +119,7 @@ public class OptimizedLoaderService impl
return list;
}
- private static class ClassLoaderAwareHandler implements InvocationHandler {
+ private static final class ClassLoaderAwareHandler implements InvocationHandler {
private final Object delegate;
private final ClassLoader loader;
private final String toString;
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/cdi/RequestScopedThreadContextListener.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/cdi/RequestScopedThreadContextListener.java?rev=1547974&r1=1547973&r2=1547974&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/cdi/RequestScopedThreadContextListener.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/cdi/RequestScopedThreadContextListener.java Thu Dec 5 00:30:39 2013
@@ -62,7 +62,7 @@ public class RequestScopedThreadContextL
destroyContext.contextsService.endContext(RequestScoped.class, null);
}
- private static class DestroyContext {
+ private static final class DestroyContext {
private final ContextsService contextsService;
private final ThreadContext threadContext;
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/classloader/ClassLoaderConfigurer.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/classloader/ClassLoaderConfigurer.java?rev=1547974&r1=1547973&r2=1547974&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/classloader/ClassLoaderConfigurer.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/classloader/ClassLoaderConfigurer.java Thu Dec 5 00:30:39 2013
@@ -25,7 +25,7 @@ public interface ClassLoaderConfigurer {
URL[] additionalURLs();
boolean accept(final URL url);
- class Helper {
+ final class Helper {
private Helper() {
// no-op
}
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/FinderFactory.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/FinderFactory.java?rev=1547974&r1=1547973&r2=1547974&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/FinderFactory.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/FinderFactory.java Thu Dec 5 00:30:39 2013
@@ -116,7 +116,7 @@ public class FinderFactory {
return new AnnotationFinder(archive);
}
- public static class DebugArchive implements Archive {
+ public static final class DebugArchive implements Archive {
private final Archive archive;
private DebugArchive(Archive archive) {
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/PersistenceContextAnnFactory.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/PersistenceContextAnnFactory.java?rev=1547974&r1=1547973&r2=1547974&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/PersistenceContextAnnFactory.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/PersistenceContextAnnFactory.java Thu Dec 5 00:30:39 2013
@@ -151,7 +151,7 @@ public class PersistenceContextAnnFactor
}
}
- private static class PersistenceContextReader extends EmptyVisitor {
+ private static final class PersistenceContextReader extends EmptyVisitor {
private String className;
private String currentName;
private final Map<String, AsmPersistenceContext> contexts;
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/sys/SaxAppCtxConfig.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/sys/SaxAppCtxConfig.java?rev=1547974&r1=1547973&r2=1547974&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/sys/SaxAppCtxConfig.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/config/sys/SaxAppCtxConfig.java Thu Dec 5 00:30:39 2013
@@ -157,7 +157,7 @@ public class SaxAppCtxConfig {
}
}
- private class Configuration extends Content {
+ private final class Configuration extends Content {
private final Properties properties;
private final String prefix;
@@ -188,7 +188,7 @@ public class SaxAppCtxConfig {
}
}
- private class MultipleConfiguration extends Content {
+ private final class MultipleConfiguration extends Content {
private final Collection<Properties> properties;
private final String prefix;
@@ -273,7 +273,7 @@ public class SaxAppCtxConfig {
private class ModuleContext extends DefaultHandler {
protected final String id;
- private ModuleContext(final String id) {
+ ModuleContext(final String id) {
this.id = id;
}
@@ -302,7 +302,7 @@ public class SaxAppCtxConfig {
}
}
- private class WebAppContext extends ModuleContext {
+ private final class WebAppContext extends ModuleContext {
private WebAppContext(final String id) {
super(id);
}
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/UnauthenticatedPrincipal.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/UnauthenticatedPrincipal.java?rev=1547974&r1=1547973&r2=1547974&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/UnauthenticatedPrincipal.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/UnauthenticatedPrincipal.java Thu Dec 5 00:30:39 2013
@@ -21,7 +21,7 @@ import java.security.Principal;
/**
* @version $Rev$ $Date$
*/
-public class UnauthenticatedPrincipal implements Principal {
+public final class UnauthenticatedPrincipal implements Principal {
public static final UnauthenticatedPrincipal INSTANCE = new UnauthenticatedPrincipal();
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/cmp/cmp2/Cmp2Generator.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/cmp/cmp2/Cmp2Generator.java?rev=1547974&r1=1547973&r2=1547974&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/cmp/cmp2/Cmp2Generator.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/cmp/cmp2/Cmp2Generator.java Thu Dec 5 00:30:39 2013
@@ -1098,7 +1098,7 @@ public class Cmp2Generator implements Op
* Helper class to handle common type conversions
* in generated code.
*/
- private static class Convert {
+ private static final class Convert {
/**
* Generate code to performing boxing of primitive types
* into a wrapper class instance.
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/ivm/IntraVmCopyMonitor.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/ivm/IntraVmCopyMonitor.java?rev=1547974&r1=1547973&r2=1547974&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/ivm/IntraVmCopyMonitor.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/ivm/IntraVmCopyMonitor.java Thu Dec 5 00:30:39 2013
@@ -16,7 +16,7 @@
*/
package org.apache.openejb.core.ivm;
-public class IntraVmCopyMonitor {
+public final class IntraVmCopyMonitor {
public static enum State {
NONE, COPY(true), CLASSLOADER_COPY(true), PASSIVATION;
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/managed/ManagedContainer.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/managed/ManagedContainer.java?rev=1547974&r1=1547973&r2=1547974&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/managed/ManagedContainer.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/managed/ManagedContainer.java Thu Dec 5 00:30:39 2013
@@ -859,7 +859,7 @@ public class ManagedContainer implements
* <p/>
* This class also is responsible for calling releaseInstance after the transaction completes.
*/
- private class SessionSynchronizationCoordinator implements TransactionSynchronization {
+ private final class SessionSynchronizationCoordinator implements TransactionSynchronization {
private final Map<Object, Synchronization> registry = new HashMap<Object, Synchronization>();
private final TransactionPolicy txPolicy;
@@ -1095,7 +1095,7 @@ public class ManagedContainer implements
}
}
- private static class Data {
+ private static final class Data {
private final Index<Method, MethodType> methodIndex;
private final List<ObjectName> jmxNames = new ArrayList<ObjectName>();
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/managed/SimpleCache.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/managed/SimpleCache.java?rev=1547974&r1=1547973&r2=1547974&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/managed/SimpleCache.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/managed/SimpleCache.java Thu Dec 5 00:30:39 2013
@@ -479,7 +479,7 @@ public class SimpleCache<K, V> implement
AVAILABLE, CHECKED_OUT, PASSIVATED, REMOVED
}
- private class Entry {
+ private final class Entry {
private final K key;
private final V value;
private final ReentrantLock lock = new ReentrantLock();
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/security/jaas/ScriptLoginModule.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/security/jaas/ScriptLoginModule.java?rev=1547974&r1=1547973&r2=1547974&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/security/jaas/ScriptLoginModule.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/security/jaas/ScriptLoginModule.java Thu Dec 5 00:30:39 2013
@@ -58,7 +58,7 @@ public class ScriptLoginModule implement
private UserData userData;
- private class UserData {
+ private final class UserData {
public final String user;
public final String pass;
public final Set<String> groups = new HashSet<String>();
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/security/jaas/ServiceProviderLoginModule.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/security/jaas/ServiceProviderLoginModule.java?rev=1547974&r1=1547973&r2=1547974&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/security/jaas/ServiceProviderLoginModule.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/security/jaas/ServiceProviderLoginModule.java Thu Dec 5 00:30:39 2013
@@ -49,7 +49,7 @@ public class ServiceProviderLoginModule
private UserData userData;
- private class UserData {
+ private final class UserData {
public final String user;
public final String pass;
public final Set<String> groups = new HashSet<String>();
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/stateful/SimpleCache.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/stateful/SimpleCache.java?rev=1547974&r1=1547973&r2=1547974&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/stateful/SimpleCache.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/stateful/SimpleCache.java Thu Dec 5 00:30:39 2013
@@ -562,7 +562,7 @@ public class SimpleCache<K, V> implement
AVAILABLE, CHECKED_OUT, PASSIVATED, REMOVED
}
- private class Entry {
+ private final class Entry {
private final K key;
private final V value;
private final ReentrantLock lock = new ReentrantLock();
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/stateful/StatefulContainer.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/stateful/StatefulContainer.java?rev=1547974&r1=1547973&r2=1547974&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/stateful/StatefulContainer.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/stateful/StatefulContainer.java Thu Dec 5 00:30:39 2013
@@ -963,7 +963,7 @@ public class StatefulContainer implement
* <p/>
* This class also is responsible for calling releaseInstance after the transaction completes.
*/
- private class SessionSynchronizationCoordinator implements TransactionSynchronization {
+ private final class SessionSynchronizationCoordinator implements TransactionSynchronization {
private final Map<Object, Synchronization> registry = new HashMap<Object, Synchronization>();
private final TransactionPolicy txPolicy;
@@ -1199,7 +1199,7 @@ public class StatefulContainer implement
}
}
- private static class Data {
+ private static final class Data {
private final Index<Method, MethodType> methodIndex;
private final List<ObjectName> jmxNames = new ArrayList<ObjectName>();
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/stateless/StatelessInstanceManager.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/stateless/StatelessInstanceManager.java?rev=1547974&r1=1547973&r2=1547974&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/stateless/StatelessInstanceManager.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/stateless/StatelessInstanceManager.java Thu Dec 5 00:30:39 2013
@@ -123,7 +123,7 @@ public class StatelessInstanceManager {
});
}
- private class StatelessSupplier implements Pool.Supplier<Instance> {
+ private final class StatelessSupplier implements Pool.Supplier<Instance> {
private final BeanContext beanContext;
private StatelessSupplier(final BeanContext beanContext) {
@@ -494,7 +494,7 @@ public class StatelessInstanceManager {
}
}
- private class InstanceCreatorRunnable implements Runnable {
+ private final class InstanceCreatorRunnable implements Runnable {
private long maxAge;
private long iteration;
private double maxAgeOffset;
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/transaction/EjbTransactionUtil.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/transaction/EjbTransactionUtil.java?rev=1547974&r1=1547973&r2=1547974&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/transaction/EjbTransactionUtil.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/transaction/EjbTransactionUtil.java Thu Dec 5 00:30:39 2013
@@ -159,7 +159,7 @@ public final class EjbTransactionUtil {
private EjbTransactionUtil() {
}
- private static class CallerTransactionEnvironment {
+ private static final class CallerTransactionEnvironment {
private final TransactionPolicy oldTxPolicy;
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/transaction/SimpleWorkManager.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/transaction/SimpleWorkManager.java?rev=1547974&r1=1547973&r2=1547974&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/transaction/SimpleWorkManager.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/transaction/SimpleWorkManager.java Thu Dec 5 00:30:39 2013
@@ -203,7 +203,7 @@ public class SimpleWorkManager implement
}
}
- private static class LoggingWorkListener extends WorkAdapter {
+ private static final class LoggingWorkListener extends WorkAdapter {
private final WorkType workType;
private LoggingWorkListener(WorkType workType) {
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/JaxWsUtils.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/JaxWsUtils.java?rev=1547974&r1=1547973&r2=1547974&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/JaxWsUtils.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/core/webservices/JaxWsUtils.java Thu Dec 5 00:30:39 2013
@@ -28,7 +28,7 @@ import java.util.HashMap;
import java.util.Map;
import java.util.StringTokenizer;
-public class JaxWsUtils {
+public final class JaxWsUtils {
private static final Map<String, String> BINDING_MAP = new HashMap<String, String>();
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/monitoring/DynamicMBeanWrapper.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/monitoring/DynamicMBeanWrapper.java?rev=1547974&r1=1547973&r2=1547974&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/monitoring/DynamicMBeanWrapper.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/monitoring/DynamicMBeanWrapper.java Thu Dec 5 00:30:39 2013
@@ -463,7 +463,7 @@ public class DynamicMBeanWrapper impleme
}
}
- private static class CacheInfo {
+ private static final class CacheInfo {
public final MBeanInfo mBeanInfo;
public final Map<String, Method> getters;
public final Map<String, Method> setters;
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/monitoring/LocalMBeanServer.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/monitoring/LocalMBeanServer.java?rev=1547974&r1=1547973&r2=1547974&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/monitoring/LocalMBeanServer.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/monitoring/LocalMBeanServer.java Thu Dec 5 00:30:39 2013
@@ -56,7 +56,7 @@ import java.lang.management.ManagementFa
import java.util.Properties;
import java.util.Set;
-public class LocalMBeanServer implements MBeanServer {
+public final class LocalMBeanServer implements MBeanServer {
private static final Logger LOGGER = Logger.getInstance(LogCategory.OPENEJB, LocalMBeanServer.class);
public static final String OPENEJB_JMX_ACTIVE = "openejb.jmx.active";
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/resource/TransactionManagerWrapper.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/resource/TransactionManagerWrapper.java?rev=1547974&r1=1547973&r2=1547974&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/resource/TransactionManagerWrapper.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/resource/TransactionManagerWrapper.java Thu Dec 5 00:30:39 2013
@@ -84,7 +84,7 @@ public class TransactionManagerWrapper i
return new TransactionWrapper(delegate.suspend(), name, xaResourceWrapper);
}
- private static class TransactionWrapper implements Transaction {
+ private static final class TransactionWrapper implements Transaction {
private final Transaction transaction;
private final String name;
private final XAResourceWrapper xaResourceWrapper;
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/resource/quartz/QuartzResourceAdapter.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/resource/quartz/QuartzResourceAdapter.java?rev=1547974&r1=1547973&r2=1547974&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/resource/quartz/QuartzResourceAdapter.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/resource/quartz/QuartzResourceAdapter.java Thu Dec 5 00:30:39 2013
@@ -347,7 +347,7 @@ public class QuartzResourceAdapter imple
* This is standard OpenEJB practice for all "public storage" maps as it prevents
* outside code from becoming dependent on or tampering with the private data.
*/
- private static class Data {
+ private static final class Data {
private final Job job;
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/Contexts.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/Contexts.java?rev=1547974&r1=1547973&r2=1547974&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/Contexts.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/Contexts.java Thu Dec 5 00:30:39 2013
@@ -20,7 +20,7 @@ package org.apache.openejb.util;
import javax.naming.Context;
import javax.naming.NamingException;
-public class Contexts {
+public final class Contexts {
private Contexts() {
// no-op
}
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/Debug.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/Debug.java?rev=1547974&r1=1547973&r2=1547974&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/Debug.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/Debug.java Thu Dec 5 00:30:39 2013
@@ -116,7 +116,7 @@ public class Debug {
private final List<Event> events = new ArrayList<Event>();
- private static class Event {
+ private static final class Event {
private final long time = System.currentTimeMillis();
private final List<StackTraceElement> elements;
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/Duration.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/Duration.java?rev=1547974&r1=1547973&r2=1547974&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/Duration.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/Duration.java Thu Dec 5 00:30:39 2013
@@ -114,20 +114,7 @@ public class Duration {
this.unit = unit;
}
-// public boolean equals(Object o) {
-// if (this == o) return true;
-// if (o == null || getClass() != o.getClass()) return false;
-//
-// final Duration duration = (Duration) o;
-//
-// if (time != duration.time) return false;
-// if (unit != duration.unit) return false;
-//
-// return true;
-// }
-
- //
- private static class Normalize {
+ private static final class Normalize {
private long a;
private long b;
private TimeUnit base;
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/HexConverter.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/HexConverter.java?rev=1547974&r1=1547973&r2=1547974&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/HexConverter.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/HexConverter.java Thu Dec 5 00:30:39 2013
@@ -16,7 +16,7 @@
*/
package org.apache.openejb.util;
-public class HexConverter {
+public final class HexConverter {
private HexConverter() {
// Disallow instantiation
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/Index.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/Index.java?rev=1547974&r1=1547973&r2=1547974&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/Index.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/Index.java Thu Dec 5 00:30:39 2013
@@ -171,7 +171,7 @@ public class Index<K,V> extends Abstract
return values;
}
- private static class IndexEntry<K,V> implements Map.Entry<K,V> {
+ private static final class IndexEntry<K,V> implements Map.Entry<K,V> {
private final K key;
private V value;
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/JndiTreeBrowser.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/JndiTreeBrowser.java?rev=1547974&r1=1547973&r2=1547974&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/JndiTreeBrowser.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/JndiTreeBrowser.java Thu Dec 5 00:30:39 2013
@@ -22,7 +22,7 @@ import javax.naming.InitialContext;
import javax.naming.NamingEnumeration;
import javax.naming.NamingException;
-public class JndiTreeBrowser {
+public final class JndiTreeBrowser {
private static final String ROOT = "";
private Context context;
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/OpenEjbVersion.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/OpenEjbVersion.java?rev=1547974&r1=1547973&r2=1547974&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/OpenEjbVersion.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/OpenEjbVersion.java Thu Dec 5 00:30:39 2013
@@ -25,7 +25,7 @@ import java.util.Properties;
/**
* @version $Rev$ $Date$
*/
-public class OpenEjbVersion {
+public final class OpenEjbVersion {
private final String copyright;//Copyright 1999-X (C) Apache OpenEJB Project, All Rights Reserved.
private final String url; //http://openejb.apache.org
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/PerformanceTimer.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/PerformanceTimer.java?rev=1547974&r1=1547973&r2=1547974&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/PerformanceTimer.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/PerformanceTimer.java Thu Dec 5 00:30:39 2013
@@ -47,7 +47,7 @@ public class PerformanceTimer {
private final Event previous;
private final String description;
- private Event(final Event previous, final String description) {
+ Event(final Event previous, final String description) {
this.previous = previous;
this.description = description;
}
@@ -61,7 +61,7 @@ public class PerformanceTimer {
}
}
- private class Start extends Event {
+ private final class Start extends Event {
private Start() {
super(null, "start");
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/Pool.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/Pool.java?rev=1547974&r1=1547973&r2=1547974&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/Pool.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/Pool.java Thu Dec 5 00:30:39 2013
@@ -439,7 +439,7 @@ public class Pool<T> {
return TimeUnit.MILLISECONDS.convert(System.nanoTime(), TimeUnit.NANOSECONDS);
}
- public class Entry {
+ public final class Entry {
private final long created;
private long used;
private final int version;
@@ -711,7 +711,7 @@ public class Pool<T> {
FULL, IDLE, AGED, FLUSHED, GC
}
- private class Expired {
+ private final class Expired {
private final Entry entry;
private final AtomicBoolean discarded = new AtomicBoolean();
private final Event event;
@@ -744,7 +744,7 @@ public class Pool<T> {
}
}
- private class Replace implements Runnable {
+ private final class Replace implements Runnable {
private final Entry expired;
private final long offset;
@@ -784,7 +784,7 @@ public class Pool<T> {
}
}
- private class Discard implements Runnable {
+ private final class Discard implements Runnable {
private final T expired;
private final Event event;
@@ -922,7 +922,7 @@ public class Pool<T> {
@SuppressWarnings("PMD.UnusedPrivateField")
@Managed
- private class Stats {
+ private final class Stats {
@Managed
private final org.apache.openejb.monitoring.Event sweeps = new org.apache.openejb.monitoring.Event();
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/SafeToolkit.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/SafeToolkit.java?rev=1547974&r1=1547973&r2=1547974&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/SafeToolkit.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/SafeToolkit.java Thu Dec 5 00:30:39 2013
@@ -22,7 +22,7 @@ import java.net.URL;
import java.net.URLClassLoader;
import java.util.HashMap;
-public class SafeToolkit {
+public final class SafeToolkit {
public static final Messages messages = new Messages("org.apache.openejb.util.resources");
public static final HashMap codebases = new HashMap();
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/SimpleJSonParser.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/SimpleJSonParser.java?rev=1547974&r1=1547973&r2=1547974&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/SimpleJSonParser.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/SimpleJSonParser.java Thu Dec 5 00:30:39 2013
@@ -24,7 +24,7 @@ import java.util.HashMap;
import java.util.Map;
// only maps json objects, doesn't handle array, number, true/false/null
-public class SimpleJSonParser {
+public final class SimpleJSonParser {
public static Object read(final InputStream is) throws IOException {
Map<String, Object> json = null;
Collection<Object> array = null;
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/URLs.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/URLs.java?rev=1547974&r1=1547973&r2=1547974&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/URLs.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/URLs.java Thu Dec 5 00:30:39 2013
@@ -30,7 +30,7 @@ import java.net.URL;
/**
* @version $Rev$ $Date$
*/
-public class URLs {
+public final class URLs {
public static File toFile(final URL url) {
return Files.toFile(url);
}
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/helper/CommandHelper.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/helper/CommandHelper.java?rev=1547974&r1=1547973&r2=1547974&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/helper/CommandHelper.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/helper/CommandHelper.java Thu Dec 5 00:30:39 2013
@@ -25,7 +25,7 @@ import org.apache.openejb.table.Lines;
import java.util.Arrays;
-public class CommandHelper {
+public final class CommandHelper {
private CommandHelper() {
// no-op
}
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/proxy/DynamicProxyImplFactory.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/proxy/DynamicProxyImplFactory.java?rev=1547974&r1=1547973&r2=1547974&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/proxy/DynamicProxyImplFactory.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/proxy/DynamicProxyImplFactory.java Thu Dec 5 00:30:39 2013
@@ -73,7 +73,7 @@ public class DynamicProxyImplFactory {
return null;
}
- private static class Handler implements InvocationHandler {
+ private static final class Handler implements InvocationHandler {
private InvocationHandler handler;
private Handler(InvocationHandler handler) {
Modified: tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/proxy/ProxyEJB.java
URL: http://svn.apache.org/viewvc/tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/proxy/ProxyEJB.java?rev=1547974&r1=1547973&r2=1547974&view=diff
==============================================================================
--- tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/proxy/ProxyEJB.java (original)
+++ tomee/tomee/trunk/container/openejb-core/src/main/java/org/apache/openejb/util/proxy/ProxyEJB.java Thu Dec 5 00:30:39 2013
@@ -25,7 +25,7 @@ import java.lang.ref.WeakReference;
import java.lang.reflect.Method;
import java.lang.reflect.Proxy;
-public class ProxyEJB {
+public final class ProxyEJB {
private ProxyEJB() {
// no-op
}