You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "stoty (via GitHub)" <gi...@apache.org> on 2024/10/21 15:37:04 UTC
[PR] PHOENIX-7440 TableSnapshotReadsMapReduceIT fails with HBase 2.6.1 [phoenix]
stoty opened a new pull request, #2014:
URL: https://github.com/apache/phoenix/pull/2014
This makes sure that we order both the mapreduce and direct query results when comparing them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7440 TableSnapshotReadsMapReduceIT fails with HBase 2.6.1 [phoenix]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on code in PR #2014:
URL: https://github.com/apache/phoenix/pull/2014#discussion_r1809059353
##########
phoenix-core/src/it/java/org/apache/phoenix/end2end/TableSnapshotReadsMapReduceIT.java:
##########
@@ -302,12 +316,12 @@ private void configureJob(Job job, String tableName, String inputQuery, String c
private void upsertData(Connection conn, String stockTableName) throws SQLException {
PreparedStatement stmt = conn.prepareStatement(String.format(UPSERT, stockTableName));
- upsertData(stmt, "AAPL", 2009, new Double[]{85.88, 91.04, 88.5, 90.3});
- upsertData(stmt, "AAPL", 2008, new Double[]{75.88, 81.04, 78.5, 80.3});
+ upsertRecord(stmt, "AAPL", 2009, new Double[]{85.88, 91.04, 88.5, 90.3});
+ upsertRecord(stmt, "AAPL", 2008, new Double[]{75.88, 81.04, 78.5, 80.3});
conn.commit();
}
- private void upsertData(PreparedStatement stmt, String name, int year, Double[] data) throws SQLException {
+ private void upsertRecord(PreparedStatement stmt, String name, int year, Double[] data) throws SQLException {
Review Comment:
This is just a readability improvment to fix the abuse of overloading.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] PHOENIX-7440 TableSnapshotReadsMapReduceIT fails with HBase 2.6.1 [phoenix]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty merged PR #2014:
URL: https://github.com/apache/phoenix/pull/2014
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org