[PR] Jakarta support [freemarker]

["kelemen (via GitHub)" <gi...@apache.org>]

kelemen opened a new pull request, #104:
URL: https://github.com/apache/freemarker/pull/104

   Added new generated sources created from `freemarker-javax-servlet` where javax references are replaced with jakarta references. Tests are also copied (with similar adjustments).
   
   The main remaining question is `freemarker.cache.WebappTemplateLoader`. For now, I have left it in the same package renamed to `JakartaWebappTemplateLoader`. There are two reasons for this:
   
   - `freemarker.cache` is a split package, and it is awkward to deal with this, if we move this class to a new package.
   - This class refers to package private classes and methods from `freemarker.cache` (`URLTemplateSource` and `TemplateLoaderUtils`), and making them public is an obvious detriment.
   
   That said, I do have a variant of this change where I moved this class into another package (in my local copy), so moving to a new package is definitely doable, if the used classes (and their methods) are made public.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@freemarker.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Jakarta support [freemarker]

["kelemen (via GitHub)" <gi...@apache.org>]

kelemen commented on PR #104:
URL: https://github.com/apache/freemarker/pull/104#issuecomment-1872587569

   Ok, I have pushed the variant moving it to another package.
   
   I have made the least amount of changes to the two classes necessary. I'm assuming that if you want to make some adjustments to them you will do that after merging this PR (e.g.: making `URLTemplateSource` final).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@freemarker.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] FREEMARKER-218: Jakarta support [freemarker]

["ddekany (via GitHub)" <gi...@apache.org>]

ddekany merged PR #104:
URL: https://github.com/apache/freemarker/pull/104


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@freemarker.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Jakarta support [freemarker]

["ddekany (via GitHub)" <gi...@apache.org>]

ddekany commented on PR #104:
URL: https://github.com/apache/freemarker/pull/104#issuecomment-1872582160

   My preference is to copy `freemarker.cache.WebappTemplateLoader` into `freemarker.ext.jakarta.servlet.WebappTemplateLoader`, and make `URLTemplateSource` (and most of its methods) and `TemplateLoaderUtils` public. (These are very old classes, and it's not likely that we will want to change then in an incompatible way, so we might as well let others use them for their own `TemplateLoader`-s.) My reason is exactly to move away from the split-package style. One day the whole javax.serlvet support will be removed, and only jakarta.servlet will remain, and at that point we will delete `freemarker.cache.WebappTemplateLoader`, and then the whole servlet support can be separated without spit-package issues.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@freemarker.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org