[GitHub] [incubator-tvm] tqchen commented on a change in pull request #4790: Fast exponent

[GitBox <gi...@apache.org>]

tqchen commented on a change in pull request #4790: Fast exponent
URL: https://github.com/apache/incubator-tvm/pull/4790#discussion_r373583565
 
 

 ##########
 File path: topi/include/topi/elemwise.h
 ##########
 @@ -360,5 +359,71 @@ inline Tensor full_like(const Tensor& x,
   }, name, tag);
 }
 
+ /*
+ * \brief Fast exponential function implementation from Eigen
+ * https://github.com/eigenteam/eigen-git-mirror/blob/master/Eigen/src/Core/arch/Default/GenericPacketMathFunctions.h#L183
 
 Review comment:
   The code in the main repo need to be licensed under ASv2.
   
   If the code comes from a difference license, We will need to put the code in the thirdparty and specify the license clearly. If we reference an existing algorithm and is implemented from scratch. It is better to declare ASv2
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services