You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by "Jarek Jarcec Cecho (JIRA)" <ji...@apache.org> on 2015/07/25 18:30:05 UTC

[jira] [Comment Edited] (SQOOP-2430) Sqoop2: Precommit: Add test coverage reports

    [ https://issues.apache.org/jira/browse/SQOOP-2430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14641715#comment-14641715 ] 

Jarek Jarcec Cecho edited comment on SQOOP-2430 at 7/25/15 4:29 PM:
--------------------------------------------------------------------

I'm attaching patch that adds the cobertura call and compares results with a base (which is a [separate Jenkins job|https://builds.apache.org/job/Sqoop2-cobertura/]). The patch is based on top of SQOOP-2429 and SQOOP-2428, so it won't apply cleanly before those two gets committed.

Example output can be seen [here|https://issues.apache.org/jira/browse/SQOOP-1781?focusedCommentId=14641712&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14641712].


was (Author: jarcec):
I'm attaching patch that adds the cobertura call and compares results with a base (which is a [separate Jenkins job|https://builds.apache.org/job/Sqoop2-cobertura/]). The patch is based on top of SQOOP-2429 and SQOOP-2428, so it won't apply cleanly before those two gets committed.

> Sqoop2: Precommit: Add test coverage reports
> --------------------------------------------
>
>                 Key: SQOOP-2430
>                 URL: https://issues.apache.org/jira/browse/SQOOP-2430
>             Project: Sqoop
>          Issue Type: Sub-task
>            Reporter: Jarek Jarcec Cecho
>            Assignee: Jarek Jarcec Cecho
>             Fix For: 1.99.7
>
>         Attachments: SQOOP-2430.patch
>
>
> I know that reporting test coverage is not the best metric, but I think that it would be useful to have a check in precommit hook that would warn us if the submitted patch has significantly decreased test coverage (from whatever reason).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)