[GitHub] merlimat commented on issue #1292: Avoid acquiring closeLock.readLock() on every add/read operation

[GitBox <gi...@apache.org>]

merlimat commented on issue #1292: Avoid acquiring closeLock.readLock() on every add/read operation
URL: https://github.com/apache/bookkeeper/pull/1292#issuecomment-375913623
 
 
   > If I remembered correctly, the lock is prevent client try to obtain a connect when closing.
   
   Yes, though I think we should be able to do : 
    * Mark client as "closed" - no new connections will be attempted
    * Close all active connections
   
   This should not require the RW lock 
   
   > However if my understanding is wrong, you might also want to remove the read write lock variable, since we don't really need a rw lock after your change. 
   
   There is still the check when creating the PCBC pool. So it will check for it before creating a new connection, but not each time when using an existing connection.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services