You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pig.apache.org by "Arun C Murthy (JIRA)" <ji...@apache.org> on 2008/01/26 04:05:34 UTC
[jira] Created: (PIG-78) src/org/apache/pig/builtin/PigStorage.java
doesn't compile
src/org/apache/pig/builtin/PigStorage.java doesn't compile
----------------------------------------------------------
Key: PIG-78
URL: https://issues.apache.org/jira/browse/PIG-78
Project: Pig
Issue Type: Bug
Reporter: Arun C Murthy
Fix For: 0.1.0
{noformat}
compile:
[echo] *** Building Main Sources ***
[javac] Compiling 6 source files to /Users/arunc/dev/java/pig/trunk/dist
[javac] /Users/arunc/dev/java/pig/trunk/src/org/apache/pig/builtin/PigStorage.java:85: cannot find symbol
[javac] symbol : method getBytes(java.nio.charset.Charset)
[javac] location: class java.lang.String
[javac] os.write((f.toDelimitedString(this.fieldDel) + (char)this.recordDel).getBytes(utf8));
[javac] ^
{noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (PIG-78)
src/org/apache/pig/builtin/PigStorage.java doesn't compile
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-78?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olga Natkovich resolved PIG-78.
-------------------------------
Resolution: Fixed
patch committed
> src/org/apache/pig/builtin/PigStorage.java doesn't compile
> ----------------------------------------------------------
>
> Key: PIG-78
> URL: https://issues.apache.org/jira/browse/PIG-78
> Project: Pig
> Issue Type: Bug
> Reporter: Arun C Murthy
> Fix For: 0.1.0
>
> Attachments: PIG-78_0_20080125.patch
>
>
> {noformat}
> compile:
> [echo] *** Building Main Sources ***
> [javac] Compiling 6 source files to /Users/arunc/dev/java/pig/trunk/dist
> [javac] /Users/arunc/dev/java/pig/trunk/src/org/apache/pig/builtin/PigStorage.java:85: cannot find symbol
> [javac] symbol : method getBytes(java.nio.charset.Charset)
> [javac] location: class java.lang.String
> [javac] os.write((f.toDelimitedString(this.fieldDel) + (char)this.recordDel).getBytes(utf8));
> [javac] ^
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-78)
src/org/apache/pig/builtin/PigStorage.java doesn't compile
Posted by "Sam Pullara (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12562811#action_12562811 ]
Sam Pullara commented on PIG-78:
--------------------------------
I've been automatically building if anyone wants to track it as well:
http://bamboo.javarants.com/browse/PIG-DEF
> src/org/apache/pig/builtin/PigStorage.java doesn't compile
> ----------------------------------------------------------
>
> Key: PIG-78
> URL: https://issues.apache.org/jira/browse/PIG-78
> Project: Pig
> Issue Type: Bug
> Reporter: Arun C Murthy
> Fix For: 0.1.0
>
> Attachments: PIG-78_0_20080125.patch
>
>
> {noformat}
> compile:
> [echo] *** Building Main Sources ***
> [javac] Compiling 6 source files to /Users/arunc/dev/java/pig/trunk/dist
> [javac] /Users/arunc/dev/java/pig/trunk/src/org/apache/pig/builtin/PigStorage.java:85: cannot find symbol
> [javac] symbol : method getBytes(java.nio.charset.Charset)
> [javac] location: class java.lang.String
> [javac] os.write((f.toDelimitedString(this.fieldDel) + (char)this.recordDel).getBytes(utf8));
> [javac] ^
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-78)
src/org/apache/pig/builtin/PigStorage.java doesn't compile
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12563195#action_12563195 ]
Arun C Murthy commented on PIG-78:
----------------------------------
I can't speak for Pig, but we decided to punt on 1.6 for Hadoop since it wasn't available for Mac yet.
This was a month or two ago... YMMV.
> src/org/apache/pig/builtin/PigStorage.java doesn't compile
> ----------------------------------------------------------
>
> Key: PIG-78
> URL: https://issues.apache.org/jira/browse/PIG-78
> Project: Pig
> Issue Type: Bug
> Reporter: Arun C Murthy
> Fix For: 0.1.0
>
> Attachments: PIG-78_0_20080125.patch
>
>
> {noformat}
> compile:
> [echo] *** Building Main Sources ***
> [javac] Compiling 6 source files to /Users/arunc/dev/java/pig/trunk/dist
> [javac] /Users/arunc/dev/java/pig/trunk/src/org/apache/pig/builtin/PigStorage.java:85: cannot find symbol
> [javac] symbol : method getBytes(java.nio.charset.Charset)
> [javac] location: class java.lang.String
> [javac] os.write((f.toDelimitedString(this.fieldDel) + (char)this.recordDel).getBytes(utf8));
> [javac] ^
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-78)
src/org/apache/pig/builtin/PigStorage.java doesn't compile
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12563221#action_12563221 ]
Olga Natkovich commented on PIG-78:
-----------------------------------
The main reason we went back to Java 1.5 was the fact that 1.6 was not available for mac. if this issie is resolved I think we should move to Java 6 especially that it promises better performance for code on critical path.
> src/org/apache/pig/builtin/PigStorage.java doesn't compile
> ----------------------------------------------------------
>
> Key: PIG-78
> URL: https://issues.apache.org/jira/browse/PIG-78
> Project: Pig
> Issue Type: Bug
> Reporter: Arun C Murthy
> Fix For: 0.1.0
>
> Attachments: PIG-78_0_20080125.patch
>
>
> {noformat}
> compile:
> [echo] *** Building Main Sources ***
> [javac] Compiling 6 source files to /Users/arunc/dev/java/pig/trunk/dist
> [javac] /Users/arunc/dev/java/pig/trunk/src/org/apache/pig/builtin/PigStorage.java:85: cannot find symbol
> [javac] symbol : method getBytes(java.nio.charset.Charset)
> [javac] location: class java.lang.String
> [javac] os.write((f.toDelimitedString(this.fieldDel) + (char)this.recordDel).getBytes(utf8));
> [javac] ^
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-78)
src/org/apache/pig/builtin/PigStorage.java doesn't compile
Posted by "Charlie Groves (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12563206#action_12563206 ]
Charlie Groves commented on PIG-78:
-----------------------------------
It's not builtin, but I've been using [SoyLatte|http://landonf.bikemonkey.org/static/soylatte/] for command line Java 6 stuff on the Mac for a couple months. It's worked perfectly for all of the stuff I've done. I don't know if the getBytes(Charset) method is enough to require Java 6, but it isn't impossible to run it on the Mac.
> src/org/apache/pig/builtin/PigStorage.java doesn't compile
> ----------------------------------------------------------
>
> Key: PIG-78
> URL: https://issues.apache.org/jira/browse/PIG-78
> Project: Pig
> Issue Type: Bug
> Reporter: Arun C Murthy
> Fix For: 0.1.0
>
> Attachments: PIG-78_0_20080125.patch
>
>
> {noformat}
> compile:
> [echo] *** Building Main Sources ***
> [javac] Compiling 6 source files to /Users/arunc/dev/java/pig/trunk/dist
> [javac] /Users/arunc/dev/java/pig/trunk/src/org/apache/pig/builtin/PigStorage.java:85: cannot find symbol
> [javac] symbol : method getBytes(java.nio.charset.Charset)
> [javac] location: class java.lang.String
> [javac] os.write((f.toDelimitedString(this.fieldDel) + (char)this.recordDel).getBytes(utf8));
> [javac] ^
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-78)
src/org/apache/pig/builtin/PigStorage.java doesn't compile
Posted by "Ted Dunning (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12563225#action_12563225 ]
Ted Dunning commented on PIG-78:
--------------------------------
I checked last week and 1.6 was not generally available.
If you compile with 1.6 with a 1.5 target and then run on 1.6 you should get all the performance you would have had if you compiled with a 1.6 target. The only difference is that I will be able to compile the code on my mac.
The 1.6 features that were at issue were trivial and had 1.5 equivalents. There is no penalty for staying 1.5 compatible and some localized benefit.
> src/org/apache/pig/builtin/PigStorage.java doesn't compile
> ----------------------------------------------------------
>
> Key: PIG-78
> URL: https://issues.apache.org/jira/browse/PIG-78
> Project: Pig
> Issue Type: Bug
> Reporter: Arun C Murthy
> Fix For: 0.1.0
>
> Attachments: PIG-78_0_20080125.patch
>
>
> {noformat}
> compile:
> [echo] *** Building Main Sources ***
> [javac] Compiling 6 source files to /Users/arunc/dev/java/pig/trunk/dist
> [javac] /Users/arunc/dev/java/pig/trunk/src/org/apache/pig/builtin/PigStorage.java:85: cannot find symbol
> [javac] symbol : method getBytes(java.nio.charset.Charset)
> [javac] location: class java.lang.String
> [javac] os.write((f.toDelimitedString(this.fieldDel) + (char)this.recordDel).getBytes(utf8));
> [javac] ^
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (PIG-78) src/org/apache/pig/builtin/PigStorage.java
doesn't compile
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-78?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy updated PIG-78:
-----------------------------
Attachment: PIG-78_0_20080125.patch
Straight-forward fix to a typo (... I believe):
{noformat}
- os.write((f.toDelimitedString(this.fieldDel) + (char)this.recordDel).getBytes(utf8));
+ os.write((f.toDelimitedString(this.fieldDel) + (char)this.recordDel).getBytes("utf8"));
{noformat}
> src/org/apache/pig/builtin/PigStorage.java doesn't compile
> ----------------------------------------------------------
>
> Key: PIG-78
> URL: https://issues.apache.org/jira/browse/PIG-78
> Project: Pig
> Issue Type: Bug
> Reporter: Arun C Murthy
> Fix For: 0.1.0
>
> Attachments: PIG-78_0_20080125.patch
>
>
> {noformat}
> compile:
> [echo] *** Building Main Sources ***
> [javac] Compiling 6 source files to /Users/arunc/dev/java/pig/trunk/dist
> [javac] /Users/arunc/dev/java/pig/trunk/src/org/apache/pig/builtin/PigStorage.java:85: cannot find symbol
> [javac] symbol : method getBytes(java.nio.charset.Charset)
> [javac] location: class java.lang.String
> [javac] os.write((f.toDelimitedString(this.fieldDel) + (char)this.recordDel).getBytes(utf8));
> [javac] ^
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-78)
src/org/apache/pig/builtin/PigStorage.java doesn't compile
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12563230#action_12563230 ]
Arun C Murthy commented on PIG-78:
----------------------------------
My apologies for starting a (religious?) debate, but I have to agree with Ted.
I'm happy to switch over my Mac whenever I can, but I'm not sure I want to try SoyLatte and such others since this is an 'official' matter... I'd appreciate if I could keep it so and develop on it.
> src/org/apache/pig/builtin/PigStorage.java doesn't compile
> ----------------------------------------------------------
>
> Key: PIG-78
> URL: https://issues.apache.org/jira/browse/PIG-78
> Project: Pig
> Issue Type: Bug
> Reporter: Arun C Murthy
> Fix For: 0.1.0
>
> Attachments: PIG-78_0_20080125.patch
>
>
> {noformat}
> compile:
> [echo] *** Building Main Sources ***
> [javac] Compiling 6 source files to /Users/arunc/dev/java/pig/trunk/dist
> [javac] /Users/arunc/dev/java/pig/trunk/src/org/apache/pig/builtin/PigStorage.java:85: cannot find symbol
> [javac] symbol : method getBytes(java.nio.charset.Charset)
> [javac] location: class java.lang.String
> [javac] os.write((f.toDelimitedString(this.fieldDel) + (char)this.recordDel).getBytes(utf8));
> [javac] ^
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-78)
src/org/apache/pig/builtin/PigStorage.java doesn't compile
Posted by "Olga Natkovich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12563364#action_12563364 ]
Olga Natkovich commented on PIG-78:
-----------------------------------
I ran performance tests on the modified code and the number look very similar to the current version. I am +1 on the change proposed by Arun. If I don't hear any objections by tomorrow, I am planning to commit the patch.
> src/org/apache/pig/builtin/PigStorage.java doesn't compile
> ----------------------------------------------------------
>
> Key: PIG-78
> URL: https://issues.apache.org/jira/browse/PIG-78
> Project: Pig
> Issue Type: Bug
> Reporter: Arun C Murthy
> Fix For: 0.1.0
>
> Attachments: PIG-78_0_20080125.patch
>
>
> {noformat}
> compile:
> [echo] *** Building Main Sources ***
> [javac] Compiling 6 source files to /Users/arunc/dev/java/pig/trunk/dist
> [javac] /Users/arunc/dev/java/pig/trunk/src/org/apache/pig/builtin/PigStorage.java:85: cannot find symbol
> [javac] symbol : method getBytes(java.nio.charset.Charset)
> [javac] location: class java.lang.String
> [javac] os.write((f.toDelimitedString(this.fieldDel) + (char)this.recordDel).getBytes(utf8));
> [javac] ^
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-78)
src/org/apache/pig/builtin/PigStorage.java doesn't compile
Posted by "Benjamin Francisoud (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12563144#action_12563144 ]
Benjamin Francisoud commented on PIG-78:
----------------------------------------
+1 for the fix.
The compilation was ok for me ?! but I my job were failing with:
{noformat}
Error message from task (reduce) tip_xxxx java.lang.RuntimeException: getBytes
at org.apache.pig.builtin.PigStorage.putNext(PigStorage:85)
at org.apache.pig.impl.mapreduceExec.PigOutputFormat$PigRecordWriter.write(PigOutputFormat:103)
at org.apache.hadoop.mapred.ReduceTask$2.collect(ReduceTask:309)
at org.apache.pig.impl.mapreduceExec.PigMapReduce$ReduceDataOutputCollector.add(PigMapReduce:338)
{noformat}
after the fix no such problem anymore.
> src/org/apache/pig/builtin/PigStorage.java doesn't compile
> ----------------------------------------------------------
>
> Key: PIG-78
> URL: https://issues.apache.org/jira/browse/PIG-78
> Project: Pig
> Issue Type: Bug
> Reporter: Arun C Murthy
> Fix For: 0.1.0
>
> Attachments: PIG-78_0_20080125.patch
>
>
> {noformat}
> compile:
> [echo] *** Building Main Sources ***
> [javac] Compiling 6 source files to /Users/arunc/dev/java/pig/trunk/dist
> [javac] /Users/arunc/dev/java/pig/trunk/src/org/apache/pig/builtin/PigStorage.java:85: cannot find symbol
> [javac] symbol : method getBytes(java.nio.charset.Charset)
> [javac] location: class java.lang.String
> [javac] os.write((f.toDelimitedString(this.fieldDel) + (char)this.recordDel).getBytes(utf8));
> [javac] ^
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-78)
src/org/apache/pig/builtin/PigStorage.java doesn't compile
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12562807#action_12562807 ]
Arun C Murthy commented on PIG-78:
----------------------------------
This is in trunk:
{noformat}
$ svn up
At revision 615427.
{noformat}
> src/org/apache/pig/builtin/PigStorage.java doesn't compile
> ----------------------------------------------------------
>
> Key: PIG-78
> URL: https://issues.apache.org/jira/browse/PIG-78
> Project: Pig
> Issue Type: Bug
> Reporter: Arun C Murthy
> Fix For: 0.1.0
>
>
> {noformat}
> compile:
> [echo] *** Building Main Sources ***
> [javac] Compiling 6 source files to /Users/arunc/dev/java/pig/trunk/dist
> [javac] /Users/arunc/dev/java/pig/trunk/src/org/apache/pig/builtin/PigStorage.java:85: cannot find symbol
> [javac] symbol : method getBytes(java.nio.charset.Charset)
> [javac] location: class java.lang.String
> [javac] os.write((f.toDelimitedString(this.fieldDel) + (char)this.recordDel).getBytes(utf8));
> [javac] ^
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (PIG-78)
src/org/apache/pig/builtin/PigStorage.java doesn't compile
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIG-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12563175#action_12563175 ]
Benjamin Reed commented on PIG-78:
----------------------------------
String.getBytes(Charset) is a 1.6 API. If we use String.getBytes(String), there is going to be some extra overhead on each Tuple read.
Do we require 1.6? And if we don't, do we know when we will?
> src/org/apache/pig/builtin/PigStorage.java doesn't compile
> ----------------------------------------------------------
>
> Key: PIG-78
> URL: https://issues.apache.org/jira/browse/PIG-78
> Project: Pig
> Issue Type: Bug
> Reporter: Arun C Murthy
> Fix For: 0.1.0
>
> Attachments: PIG-78_0_20080125.patch
>
>
> {noformat}
> compile:
> [echo] *** Building Main Sources ***
> [javac] Compiling 6 source files to /Users/arunc/dev/java/pig/trunk/dist
> [javac] /Users/arunc/dev/java/pig/trunk/src/org/apache/pig/builtin/PigStorage.java:85: cannot find symbol
> [javac] symbol : method getBytes(java.nio.charset.Charset)
> [javac] location: class java.lang.String
> [javac] os.write((f.toDelimitedString(this.fieldDel) + (char)this.recordDel).getBytes(utf8));
> [javac] ^
> {noformat}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.