[GitHub] [incubator-pinot] mcvsubbu commented on pull request #6710: Add a trailer section to data table and measure data table serialization cost on server

[GitBox <gi...@apache.org>]

mcvsubbu commented on pull request #6710:
URL: https://github.com/apache/incubator-pinot/pull/6710#issuecomment-806292277


   > Since we are adding a new data table version, please use this opportunity to address the TODOs within the `DataTableBuilder`.
   > For the `TrailerKeys` enum, let's put an id for each key instead of using the ordinal of the enum. This way it is much easier to manage as long as we don't reuse the ids. Also suggest renaming it to `MetadataKeys`
   
   By "Id" do you mean strings? Why is that any more advantages than adding an enum? In fact, enum is better since we can declare all enums in one place and add whatever comments there to not remove an enum


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org