You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2021/12/21 12:52:50 UTC

svn commit: r1896244 - /pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateSignature.java

Author: tilman
Date: Tue Dec 21 12:52:50 2021
New Revision: 1896244

URL: http://svn.apache.org/viewvc?rev=1896244&view=rev
Log:
PDFBOX-4892: avoid memory leaks

Modified:
    pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateSignature.java

Modified: pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateSignature.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateSignature.java?rev=1896244&r1=1896243&r2=1896244&view=diff
==============================================================================
--- pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateSignature.java (original)
+++ pdfbox/trunk/examples/src/main/java/org/apache/pdfbox/examples/signature/CreateSignature.java Tue Dec 21 12:52:50 2021
@@ -21,6 +21,7 @@ import java.io.FileInputStream;
 import java.io.FileNotFoundException;
 import java.io.FileOutputStream;
 import java.io.IOException;
+import java.io.InputStream;
 import java.io.OutputStream;
 import java.security.GeneralSecurityException;
 import java.security.KeyStore;
@@ -193,7 +194,10 @@ public class CreateSignature extends Cre
         // load the keystore
         KeyStore keystore = KeyStore.getInstance("PKCS12");
         char[] password = args[1].toCharArray(); // TODO use Java 6 java.io.Console.readPassword
-        keystore.load(new FileInputStream(args[0]), password);
+        try (InputStream is = new FileInputStream(args[0]))
+        {
+            keystore.load(is, password);
+        }
         // TODO alias command line argument
 
         // sign PDF