You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by "Matthieu Baechler (JIRA)" <se...@james.apache.org> on 2016/07/25 16:12:20 UTC
[jira] [Commented] (JAMES-1808) if (character > 128) should be
changed to if (character >= 128)
[ https://issues.apache.org/jira/browse/JAMES-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15392185#comment-15392185 ]
Matthieu Baechler commented on JAMES-1808:
------------------------------------------
Thank you very much for you report. Do you have a failing test case for that ? (MPT test, unit test, or even a copy/paste of an imap session)
> if (character > 128) should be changed to if (character >= 128)
> ---------------------------------------------------------------
>
> Key: JAMES-1808
> URL: https://issues.apache.org/jira/browse/JAMES-1808
> Project: James Server
> Issue Type: Bug
> Components: IMAPServer
> Affects Versions: 3.0.0-beta5
> Reporter: Paul Lee
> Priority: Minor
> Fix For: 3.0.0-beta5
>
>
> There is a conditional code block as follows in the class 'ImapResponseComposerImpl' of the package 'org.apache.james.imap.encode.base' in the 'protocols-imap' project.
> // 7-bit ASCII only
> if (character > 128) {
> buffer.write(BYTE_QUESTION);
> } else {
> buffer.write((byte) character);
> }
> An equals(=) sign should be included in the conditional since the range of US-ASCII is from 0 to 127(not including 128).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org