[jira] [Comment Edited] (MSHADE-382) Add an option to skip execution

["Andres Almiray (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MSHADE-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324049#comment-17324049 ] 

Andres Almiray edited comment on MSHADE-382 at 4/16/21, 8:03 PM:
-----------------------------------------------------------------

The reasoning behind this property is this:

A project (under my control) consumes a parent pom (outside of my control) where the shade plugin is defined, configured, and applied. This means my project has no say in this regard. The parent project also adds more behavior and dependencies that I really need thus starting from scratch without the parent pom does not look so good, specially if newer versions update the behavior.

If I sever my project from the parent and copy the behavior from the parent I have effectively forked the parent and now have to keep the parent in sync with upstream.

The alternative to keep the parent in place and skip shading on the child is to explicitly define the shade plugin and try to come with a configuration that can cover the use case that I need. This is code under my control.

The better alternative is to convince the team in the upstream parent to change the shading configuration so that it becomes optional or its added via profiles. That can take more time to be realized, if at all. If they change their parent pom then I can update my pom. If they do not then I'm still stuck. This property lets me unstuck myself by as long as the updated shade-plugin version is set in <pluginManagement>


was (Author: aalmiray):
The reasoning behind this property is this:

A project (under my control) consumes a parent pom (outside of my control) where the shade plugin is defined, configured, and applied. This means my project has no say in this regard. The parent project also adds more behavior and dependencies that I really need thus starting from scratch without the parent pom does not look so good, specially if newer versions update the behavior.

If I sever my project from the parent and copy the behavior from the parent I have effectively forked the parent and now have to keep the parent in sync with upstream.

The alternative to keep the parent in place and skip shading on the child is to explicitly define the shade plugin and try to come with a configuration that can cover the use case that I need. This is code under my control.

The better alternative is to convince the team in the upstream parent to put the change the shading configuration so that it becomes optional or its added via profiles. That can take more time to be realized.

> Add an option to skip execution
> -------------------------------
>
>                 Key: MSHADE-382
>                 URL: https://issues.apache.org/jira/browse/MSHADE-382
>             Project: Maven Shade Plugin
>          Issue Type: Improvement
>    Affects Versions: 3.2.4
>            Reporter: Andres Almiray
>            Priority: Major
>
> It'd be great to have a property for skipping execution, such as `maven.shade.skip`. Useful when a parent has setup shading but a child would like to skip it for example.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)