You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "HyukjinKwon (via GitHub)" <gi...@apache.org> on 2023/12/04 10:26:12 UTC
Re: [PR] [SPARK-46237][SQL][TESTS] Make `HiveDDLSuite` independently testable [spark]
HyukjinKwon commented on code in PR #44153:
URL: https://github.com/apache/spark/pull/44153#discussion_r1413660735
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala:
##########
@@ -3270,7 +3270,10 @@ class HiveDDLSuite
val jarName = "TestUDTF.jar"
val jar = spark.asInstanceOf[TestHiveSparkSession].getHiveFile(jarName).toURI.toString
spark.sparkContext.allAddedJars.keys.find(_.contains(jarName))
- .foreach(spark.sparkContext.addedJars("default").remove)
+ .foreach(k => spark.sparkContext.addedJars.get("default") match {
Review Comment:
The change seems fine. Can we do as below though?
```scala
foreach(k => spark.sparkContext.addedJars.get("default").foreach(_.remove(k)))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org