[jira] [Commented] (FLINK-8212) Pull EnvironmentInformation out of TaskManagerServices

["mingleizhang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-8212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16359833#comment-16359833 ] 

mingleizhang commented on FLINK-8212:
-------------------------------------

Hi, [~till.rohrmann] I have a question. If we do not use {{EnvironmentInformation}} to get {{getSizeOfFreeHeapMemoryWithDefrag}} and {{getMaxJvmHeapMemory}}. Is there another way to get those two guys information ? Thanks.

> Pull EnvironmentInformation out of TaskManagerServices
> ------------------------------------------------------
>
>                 Key: FLINK-8212
>                 URL: https://issues.apache.org/jira/browse/FLINK-8212
>             Project: Flink
>          Issue Type: Improvement
>          Components: Local Runtime, Network
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Priority: Major
>             Fix For: 1.5.0
>
>
> We should pull the {{EnvironmentInformation}} out of the {{TaskManagerServices}} where it is used to get access to the memory settings of the executing JVM. This unnecessarily couples the former with the latter and makes testing extremely hard (one has to use {{PowerMockRunner}} and mock the static {{EnvironmentInformation}}).
> When addressing this issue, then we should also refactor {{NetworkBufferCalculationTest}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)