You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/08/31 22:59:02 UTC
[GitHub] [superset] codyml opened a new pull request, #21282: fix(dashboard): Fix scrolling on "View as table" modal
codyml opened a new pull request, #21282:
URL: https://github.com/apache/superset/pull/21282
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
In the "View as table" modal, accessed by clicking the three dots on a dashboard chart, results scroll behind/with the header and pagination. This PR fixes layout so header and pagination stay in place, for both the single-query and multi-query version of the modal.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
**Before, single query:**
https://user-images.githubusercontent.com/13007381/187799270-c658c2e5-4ba7-435e-8279-2c10ed616bf3.mov
**Before, multiple query:**
https://user-images.githubusercontent.com/13007381/187799307-0ad0440e-2993-4d34-8958-881d455e74ed.mov
**After, single query:**
https://user-images.githubusercontent.com/13007381/187799322-76b48225-fcce-44e7-88c2-eca51e8fc0a3.mov
**After, multiple query:**
https://user-images.githubusercontent.com/13007381/187799329-6129328f-756f-4677-acf2-8723e77edebd.mov
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
- Open the "View as table" modal for single- and multiple-query charts and ensure scrolling works as expected.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codyml commented on pull request #21282: fix(dashboard): Fix scrolling on "View as table" modal
Posted by GitBox <gi...@apache.org>.
codyml commented on PR #21282:
URL: https://github.com/apache/superset/pull/21282#issuecomment-1235951751
> @codyml in the video "After, single query" I can see that the results are showing up behind the upper part of the header when scrolling. Is that something that we can get fixed on this PR?
Oops yes!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on pull request #21282: fix(dashboard): Fix scrolling on "View as table" modal
Posted by GitBox <gi...@apache.org>.
geido commented on PR #21282:
URL: https://github.com/apache/superset/pull/21282#issuecomment-1234148194
@codyml in the video "After, single query" I can see that the results are showing up behind the upper part of the header when scrolling. Is that something that we can get fixed on this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codyml commented on pull request #21282: fix(dashboard): Fix scrolling on "View as table" modal
Posted by GitBox <gi...@apache.org>.
codyml commented on PR #21282:
URL: https://github.com/apache/superset/pull/21282#issuecomment-1235974028
> @codyml in the video "After, single query" I can see that the results are showing up behind the upper part of the header when scrolling. Is that something that we can get fixed on this PR?
@geido Hmm, so I looked at this in my local dev env and I think it might just be a scaling effect caused by me having my Chrome viewport set to 75% when I recorded those videos. When I set it to 100% it doesn't happen. Would you mind spinning up an ephemeral env and letting me know if you see it happening there at normal resolution?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #21282: fix(dashboard): Fix scrolling on "View as table" modal
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #21282:
URL: https://github.com/apache/superset/pull/21282#issuecomment-1233558176
# [Codecov](https://codecov.io/gh/apache/superset/pull/21282?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21282](https://codecov.io/gh/apache/superset/pull/21282?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5815427) into [master](https://codecov.io/gh/apache/superset/commit/9c4ae2ab7e323a71f44507259c9058faecdd725d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9c4ae2a) will **decrease** coverage by `0.00%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #21282 +/- ##
==========================================
- Coverage 66.44% 66.44% -0.01%
==========================================
Files 1784 1784
Lines 68234 68233 -1
Branches 7265 7263 -2
==========================================
- Hits 45341 45338 -3
- Misses 21024 21026 +2
Partials 1869 1869
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `52.49% <100.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/21282?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...taTablesPane/components/ResultsPaneOnDashboard.tsx](https://codecov.io/gh/apache/superset/pull/21282/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS9jb21wb25lbnRzL1Jlc3VsdHNQYW5lT25EYXNoYm9hcmQudHN4) | `100.00% <100.00%> (ø)` | |
| [...rontend/src/components/ErrorMessage/ErrorAlert.tsx](https://codecov.io/gh/apache/superset/pull/21282/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0Vycm9yQWxlcnQudHN4) | `89.47% <0.00%> (-0.78%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/superset/pull/21282/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `61.05% <0.00%> (-0.33%)` | :arrow_down: |
| [...c/views/CRUD/data/database/DatabaseModal/index.tsx](https://codecov.io/gh/apache/superset/pull/21282/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsL2luZGV4LnRzeA==) | `32.03% <0.00%> (-0.17%)` | :arrow_down: |
| [...d/src/SqlLab/components/SaveDatasetModal/index.tsx](https://codecov.io/gh/apache/superset/pull/21282/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NhdmVEYXRhc2V0TW9kYWwvaW5kZXgudHN4) | `52.87% <0.00%> (ø)` | |
| [...onents/ErrorMessage/ErrorMessageWithStackTrace.tsx](https://codecov.io/gh/apache/superset/pull/21282/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0Vycm9yTWVzc2FnZVdpdGhTdGFja1RyYWNlLnRzeA==) | `60.00% <0.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codyml commented on pull request #21282: fix(dashboard): Fix scrolling on "View as table" modal
Posted by GitBox <gi...@apache.org>.
codyml commented on PR #21282:
URL: https://github.com/apache/superset/pull/21282#issuecomment-1233522910
@kasiazjc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #21282: fix(dashboard): Fix scrolling on "View as table" modal
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #21282:
URL: https://github.com/apache/superset/pull/21282#issuecomment-1236002714
@zhaoyongjie Ephemeral environment spinning up at http://34.217.133.154:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on pull request #21282: fix(dashboard): Fix scrolling on "View as table" modal
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on PR #21282:
URL: https://github.com/apache/superset/pull/21282#issuecomment-1236001865
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a diff in pull request #21282: fix(dashboard): Fix scrolling on "View as table" modal
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on code in PR #21282:
URL: https://github.com/apache/superset/pull/21282#discussion_r960385110
##########
superset-frontend/src/explore/components/DataTablesPane/components/ResultsPaneOnDashboard.tsx:
##########
@@ -17,7 +17,7 @@
* under the License.
*/
import React from 'react';
-import { t } from '@superset-ui/core';
+import { t, css } from '@superset-ui/core';
Review Comment:
@codyml Thanks for the fixing, there is a simple pattern for wrapping an existing components.
```typescript
import { styled } from '@superset-ui/core';
const Wrapper = styled.div`
display: flex;
flex-direction: column;
height: 100%;
.ant-tabs {
height: 100%;
}
.ant-tabs-content {
height: 100%;
}
.ant-tabs-tabpane {
display: flex;
flex-direction: column;
}
.table-condensed {
overflow: auto;
}
`;
....
....
return <Wrapper>{resultsPanes[0]}</Wrapper>;
....
....
<Wrapper><Tabs fullWidth={false}> {panes} </Tabs></Wrapper>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a diff in pull request #21282: fix(dashboard): Fix scrolling on "View as table" modal
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on code in PR #21282:
URL: https://github.com/apache/superset/pull/21282#discussion_r960385110
##########
superset-frontend/src/explore/components/DataTablesPane/components/ResultsPaneOnDashboard.tsx:
##########
@@ -17,7 +17,7 @@
* under the License.
*/
import React from 'react';
-import { t } from '@superset-ui/core';
+import { t, css } from '@superset-ui/core';
Review Comment:
@codyml Thanks for the fixing, there is a simple pattern for wrapping the existing components.
```typescript
import { styled } from '@superset-ui/core';
const Wrapper = styled.div`
display: flex;
flex-direction: column;
height: 100%;
.ant-tabs {
height: 100%;
}
.ant-tabs-content {
height: 100%;
}
.ant-tabs-tabpane {
display: flex;
flex-direction: column;
}
.table-condensed {
overflow: auto;
}
`;
....
....
return <Wrapper>{resultsPanes[0]}</Wrapper>;
....
....
<Wrapper><Tabs fullWidth={false}> {panes} </Tabs></Wrapper>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie merged pull request #21282: fix(dashboard): Fix scrolling on "View as table" modal
Posted by GitBox <gi...@apache.org>.
zhaoyongjie merged PR #21282:
URL: https://github.com/apache/superset/pull/21282
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #21282: fix(dashboard): Fix scrolling on "View as table" modal
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #21282:
URL: https://github.com/apache/superset/pull/21282#issuecomment-1238833952
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on a diff in pull request #21282: fix(dashboard): Fix scrolling on "View as table" modal
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on code in PR #21282:
URL: https://github.com/apache/superset/pull/21282#discussion_r960385110
##########
superset-frontend/src/explore/components/DataTablesPane/components/ResultsPaneOnDashboard.tsx:
##########
@@ -17,7 +17,7 @@
* under the License.
*/
import React from 'react';
-import { t } from '@superset-ui/core';
+import { t, css } from '@superset-ui/core';
Review Comment:
@codyml Thanks for the fixing, there is a simple pattern for wrapping the existing components.
```typescript
const Wrapper = styled.div`
display: flex;
flex-direction: column;
height: 100%;
.ant-tabs {
height: 100%;
}
.ant-tabs-content {
height: 100%;
}
.ant-tabs-tabpane {
display: flex;
flex-direction: column;
}
.table-condensed {
overflow: auto;
}
`;
....
....
return <Wrapper>{resultsPanes[0]}</Wrapper>;
....
....
<Wrapper><Tabs fullWidth={false}> {panes} </Tabs></Wrapper>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codyml commented on a diff in pull request #21282: fix(dashboard): Fix scrolling on "View as table" modal
Posted by GitBox <gi...@apache.org>.
codyml commented on code in PR #21282:
URL: https://github.com/apache/superset/pull/21282#discussion_r962050733
##########
superset-frontend/src/explore/components/DataTablesPane/components/ResultsPaneOnDashboard.tsx:
##########
@@ -17,7 +17,7 @@
* under the License.
*/
import React from 'react';
-import { t } from '@superset-ui/core';
+import { t, css } from '@superset-ui/core';
Review Comment:
Will do, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org