[GitHub] spark pull request #17869: [SPARK-20609][CORE]Run the SortShuffleSuite unit ...

[HyukjinKwon <gi...@git.apache.org>]

Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17869#discussion_r115120038
  
    --- Diff: core/src/test/scala/org/apache/spark/SortShuffleSuite.scala ---
    @@ -39,12 +39,12 @@ class SortShuffleSuite extends ShuffleSuite with BeforeAndAfterAll {
       override def beforeAll() {
         super.beforeAll()
         conf.set("spark.shuffle.manager", "sort")
    +    conf.set("spark.local.dir", Utils.createTempDir().getAbsolutePath)
       }
     
       override def beforeEach(): Unit = {
         super.beforeEach()
         tempDir = Utils.createTempDir()
    -    conf.set("spark.local.dir", tempDir.getAbsolutePath)
    --- End diff --
    
    @heary-cao I am sorry, probably I didn't understand yet. Here it looks we create a temp directory, `tempDir`,  before a test and remove `tempDir` after a test recusively. How come a directory could leave undeleted? 
    
    Or do you mean actually the test is failed because it fails to remove the temp directory as they have exclusive lock only on Windows?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org