You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/11/27 04:25:26 UTC
[GitHub] [pulsar] yuruguo opened a new pull request #12996: [website] Modify admin-api-topic.md document
yuruguo opened a new pull request #12996:
URL: https://github.com/apache/pulsar/pull/12996
### Motivation
There are two parts need to adjust in [admin-api-topic.md](https://pulsar.apache.org/docs/en/next/admin-api-topics/)
1. List partitioned topics should use `list-partitioned-topics` rather than `list` in [manage-partitioned-topics/List](https://pulsar.apache.org/docs/en/next/admin-api-topics/#list-1). It involves `all versions` that support the command.
2. [Get backlog size](https://pulsar.apache.org/docs/en/next/admin-api-topics/#get-backlog-size) should not be placed in part [Manage partitioned topics](https://pulsar.apache.org/docs/en/next/admin-api-topics/#manage-partitioned-topics), because this command applies to all topics included `no-partitioned-topics` and `partitioned-topics`, so it should be placed in [Manage topic resources](https://pulsar.apache.org/docs/en/next/admin-api-topics/#manage-topic-resources). It only involves `master` branch.
### Documentation
- [x] `doc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] BewareMyPower commented on a change in pull request #12996: [website] Modify admin-api-topic.md document
Posted by GitBox <gi...@apache.org>.
BewareMyPower commented on a change in pull request #12996:
URL: https://github.com/apache/pulsar/pull/12996#discussion_r758036220
##########
File path: site2/docs/admin-api-topics.md
##########
@@ -1224,7 +1248,7 @@ persistent://tenant/namespace/topic2
<!--Java-->
```java
-admin.topics().getList(namespace);
+admin.topics().getPartitionedTopicList(namespace);
Review comment:
It's okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet merged pull request #12996: [website] Modify admin-api-topic.md document
Posted by GitBox <gi...@apache.org>.
Anonymitaet merged pull request #12996:
URL: https://github.com/apache/pulsar/pull/12996
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a change in pull request #12996: [website] Modify admin-api-topic.md document
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #12996:
URL: https://github.com/apache/pulsar/pull/12996#discussion_r757998579
##########
File path: site2/docs/admin-api-topics.md
##########
@@ -1224,7 +1248,7 @@ persistent://tenant/namespace/topic2
<!--Java-->
```java
-admin.topics().getList(namespace);
+admin.topics().getPartitionedTopicList(namespace);
Review comment:
@BewareMyPower can you review `line 1237 - line 1251` from the technical perspective? Thanks
##########
File path: site2/docs/admin-api-topics.md
##########
@@ -943,6 +943,30 @@ admin.topics().getLastMessage(topic);
<!--END_DOCUSAURUS_CODE_TABS-->
+### Get backlog size
Review comment:
why move `get backlog size` here?
##########
File path: site2/docs/admin-api-topics.md
##########
@@ -943,6 +943,30 @@ admin.topics().getLastMessage(topic);
<!--END_DOCUSAURUS_CODE_TABS-->
+### Get backlog size
+
+You can get backlog size of a single topic partition or a nonpartitioned topic given a message ID (in bytes).
Review comment:
```suggestion
You can get the backlog size of a single partition topic or a non-partitioned topic with a given message ID (in bytes).
```
do you mean this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on a change in pull request #12996: [website] Modify admin-api-topic.md document
Posted by GitBox <gi...@apache.org>.
yuruguo commented on a change in pull request #12996:
URL: https://github.com/apache/pulsar/pull/12996#discussion_r758339568
##########
File path: site2/docs/admin-api-topics.md
##########
@@ -943,6 +943,30 @@ admin.topics().getLastMessage(topic);
<!--END_DOCUSAURUS_CODE_TABS-->
+### Get backlog size
+
+You can get backlog size of a single topic partition or a nonpartitioned topic given a message ID (in bytes).
Review comment:
Yes
Done, PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo removed a comment on pull request #12996: [website] Modify admin-api-topic.md document
Posted by GitBox <gi...@apache.org>.
yuruguo removed a comment on pull request #12996:
URL: https://github.com/apache/pulsar/pull/12996#issuecomment-980499822
@tuteng @Anonymitaet @Huanli-Meng PTAL, thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a change in pull request #12996: [website] Modify admin-api-topic.md document
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #12996:
URL: https://github.com/apache/pulsar/pull/12996#discussion_r757996972
##########
File path: site2/docs/admin-api-topics.md
##########
@@ -943,6 +943,30 @@ admin.topics().getLastMessage(topic);
<!--END_DOCUSAURUS_CODE_TABS-->
+### Get backlog size
+
+You can get backlog size of a single topic partition or a nonpartitioned topic given a message ID (in bytes).
Review comment:
```suggestion
You can get the backlog size of a single partition topic or a non-partitioned topic with a given message ID (in bytes).
```
do you mean this?
if yes, please check all occurencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] yuruguo commented on pull request #12996: [website] Modify admin-api-topic.md document
Posted by GitBox <gi...@apache.org>.
yuruguo commented on pull request #12996:
URL: https://github.com/apache/pulsar/pull/12996#issuecomment-980499822
@tuteng @Anonymitaet @Huanli-Meng PTAL, thx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org