You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2018/10/09 09:57:34 UTC

[GitHub] zentol edited a comment on issue #6702: [FLINK-10135] The JobManager does not report the cluster-level metrics

zentol edited a comment on issue #6702: [FLINK-10135] The JobManager does not report the cluster-level metrics
URL: https://github.com/apache/flink/pull/6702#issuecomment-428133115
 
 
   This looks a lot better, the majority of my comments are for minor things, but we've now run into a concurrency issue. All `RpcEndpoints` (i.e. DIspatcher, ResourceManager, etc) assume to run in a single thread (the "main-thread"), but metrics are accessed by a separate one. We have to either make sure that all operations are safe in this scenario, or _somehow_ (@tillrohrmann?) defer the access to the main-thread.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services