You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Chia-Ping Tsai <ch...@apache.org> on 2018/09/08 18:27:59 UTC

[VOTE] KIP-367 Introduce close(Duration) to Producer and AdminClient instead of close(long, TimeUnit)

Hi All,

I'd like to put KIP-367 to the vote.

https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=89070496

--
Chia-Ping

Re: [VOTE] KIP-367 Introduce close(Duration) to Producer and AdminClient instead of close(long, TimeUnit)

Posted by Jason Gustafson <ja...@confluent.io>.
+1 Thanks for the KIP

On Fri, Sep 14, 2018 at 10:24 PM, Colin McCabe <cm...@apache.org> wrote:

> +1 (non-binding).
>
> Thanks, Chia-Ping.
>
> best,
>
>
> On Fri, Sep 14, 2018, at 21:01, Chia-Ping Tsai wrote:
> > hi Colin
> >
> > > I like the idea of having a close(Duration) call.  I would rather keep
> the existing close(long, TimeUnit) call to avoid breaking compatibility,
> however.  Does the KIP specify keeping the old overload?  I can't seem to
> access the wiki now.
> >
> > As Ismael said. All existing close(long, TimeUnit) aren't removed but
> > all of them are marked as "deprecated".
> >
> > --
> > Chia-Ping
> >
> > On 2018/09/14 21:06:13, Colin McCabe <cm...@apache.org> wrote:
> > > Hi Chia-Ping,
> > >
> > > I like the idea of having a close(Duration) call.  I would rather keep
> the existing close(long, TimeUnit) call to avoid breaking compatibility,
> however.  Does the KIP specify keeping the old overload?  I can't seem to
> access the wiki now.
> > >
> > > best,
> > > Colin
> > >
> > >
> > > On Sat, Sep 8, 2018, at 11:27, Chia-Ping Tsai wrote:
> > > > Hi All,
> > > >
> > > > I'd like to put KIP-367 to the vote.
> > > >
> > > > https://cwiki.apache.org/confluence/pages/viewpage.
> action?pageId=89070496
> > > >
> > > > --
> > > > Chia-Ping
> > >
>

Re: [VOTE] KIP-367 Introduce close(Duration) to Producer and AdminClient instead of close(long, TimeUnit)

Posted by Colin McCabe <cm...@apache.org>.
+1 (non-binding).

Thanks, Chia-Ping.

best,


On Fri, Sep 14, 2018, at 21:01, Chia-Ping Tsai wrote:
> hi Colin
> 
> > I like the idea of having a close(Duration) call.  I would rather keep the existing close(long, TimeUnit) call to avoid breaking compatibility, however.  Does the KIP specify keeping the old overload?  I can't seem to access the wiki now.
> 
> As Ismael said. All existing close(long, TimeUnit) aren't removed but 
> all of them are marked as "deprecated".
> 
> --
> Chia-Ping
> 
> On 2018/09/14 21:06:13, Colin McCabe <cm...@apache.org> wrote: 
> > Hi Chia-Ping,
> > 
> > I like the idea of having a close(Duration) call.  I would rather keep the existing close(long, TimeUnit) call to avoid breaking compatibility, however.  Does the KIP specify keeping the old overload?  I can't seem to access the wiki now.
> > 
> > best,
> > Colin
> > 
> > 
> > On Sat, Sep 8, 2018, at 11:27, Chia-Ping Tsai wrote:
> > > Hi All,
> > > 
> > > I'd like to put KIP-367 to the vote.
> > > 
> > > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=89070496
> > > 
> > > --
> > > Chia-Ping
> >

Re: [VOTE] KIP-367 Introduce close(Duration) to Producer and AdminClient instead of close(long, TimeUnit)

Posted by Chia-Ping Tsai <ch...@apache.org>.
hi Colin

> I like the idea of having a close(Duration) call.  I would rather keep the existing close(long, TimeUnit) call to avoid breaking compatibility, however.  Does the KIP specify keeping the old overload?  I can't seem to access the wiki now.

As Ismael said. All existing close(long, TimeUnit) aren't removed but all of them are marked as "deprecated".

--
Chia-Ping

On 2018/09/14 21:06:13, Colin McCabe <cm...@apache.org> wrote: 
> Hi Chia-Ping,
> 
> I like the idea of having a close(Duration) call.  I would rather keep the existing close(long, TimeUnit) call to avoid breaking compatibility, however.  Does the KIP specify keeping the old overload?  I can't seem to access the wiki now.
> 
> best,
> Colin
> 
> 
> On Sat, Sep 8, 2018, at 11:27, Chia-Ping Tsai wrote:
> > Hi All,
> > 
> > I'd like to put KIP-367 to the vote.
> > 
> > https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=89070496
> > 
> > --
> > Chia-Ping
>

Re: [VOTE] KIP-367 Introduce close(Duration) to Producer and AdminClient instead of close(long, TimeUnit)

Posted by Ismael Juma <is...@juma.me.uk>.
Yeah, but it suggests deprecating the old method.

Ismael

On Fri, Sep 14, 2018 at 2:06 PM Colin McCabe <cm...@apache.org> wrote:

> Hi Chia-Ping,
>
> I like the idea of having a close(Duration) call.  I would rather keep the
> existing close(long, TimeUnit) call to avoid breaking compatibility,
> however.  Does the KIP specify keeping the old overload?  I can't seem to
> access the wiki now.
>
> best,
> Colin
>
>
> On Sat, Sep 8, 2018, at 11:27, Chia-Ping Tsai wrote:
> > Hi All,
> >
> > I'd like to put KIP-367 to the vote.
> >
> >
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=89070496
> >
> > --
> > Chia-Ping
>

Re: [VOTE] KIP-367 Introduce close(Duration) to Producer and AdminClient instead of close(long, TimeUnit)

Posted by Colin McCabe <cm...@apache.org>.
Hi Chia-Ping,

I like the idea of having a close(Duration) call.  I would rather keep the existing close(long, TimeUnit) call to avoid breaking compatibility, however.  Does the KIP specify keeping the old overload?  I can't seem to access the wiki now.

best,
Colin


On Sat, Sep 8, 2018, at 11:27, Chia-Ping Tsai wrote:
> Hi All,
> 
> I'd like to put KIP-367 to the vote.
> 
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=89070496
> 
> --
> Chia-Ping

Re: [VOTE] KIP-367 Introduce close(Duration) to Producer and AdminClient instead of close(long, TimeUnit)

Posted by Bill Bejeck <bb...@gmail.com>.
+1

-Bill

On Thu, Sep 13, 2018 at 4:44 AM Mickael Maison <mi...@gmail.com>
wrote:

> +1 (non-binding)
> Thanks!
> On Thu, Sep 13, 2018 at 7:05 AM Manikumar <ma...@gmail.com>
> wrote:
> >
> > +1 (non-binding)
> >
> > Thanks for the KIP.
> >
> > On Thu, Sep 13, 2018 at 10:38 AM Harsha <ka...@harsha.io> wrote:
> >
> > > +1 (Binding).
> > > Thanks,
> > > Harsha
> > >
> > > On Wed, Sep 12, 2018, at 9:06 PM, vito jeng wrote:
> > > > +1
> > > >
> > > >
> > > >
> > > > ---
> > > > Vito
> > > >
> > > > On Mon, Sep 10, 2018 at 4:52 PM, Dongjin Lee <do...@apache.org>
> wrote:
> > > >
> > > > > +1. (Non-binding)
> > > > >
> > > > > On Mon, Sep 10, 2018 at 4:13 AM Matthias J. Sax <
> matthias@confluent.io
> > > >
> > > > > wrote:
> > > > >
> > > > > > Thanks a lot for the KIP.
> > > > > >
> > > > > > +1 (binding)
> > > > > >
> > > > > >
> > > > > > -Matthias
> > > > > >
> > > > > >
> > > > > > On 9/8/18 11:27 AM, Chia-Ping Tsai wrote:
> > > > > > > Hi All,
> > > > > > >
> > > > > > > I'd like to put KIP-367 to the vote.
> > > > > > >
> > > > > > >
> > > > > > https://cwiki.apache.org/confluence/pages/viewpage.
> > > > > action?pageId=89070496
> > > > > > >
> > > > > > > --
> > > > > > > Chia-Ping
> > > > > > >
> > > > > >
> > > > > >
> > > > >
> > > > > --
> > > > > *Dongjin Lee*
> > > > >
> > > > > *A hitchhiker in the mathematical world.*
> > > > >
> > > > > *github:  <http://goog_969573159/>github.com/dongjinleekr
> > > > > <http://github.com/dongjinleekr>linkedin:
> > > kr.linkedin.com/in/dongjinleekr
> > > > > <http://kr.linkedin.com/in/dongjinleekr>slideshare:
> > > > > www.slideshare.net/dongjinleekr
> > > > > <http://www.slideshare.net/dongjinleekr>*
> > > > >
> > >
>

Re: [VOTE] KIP-367 Introduce close(Duration) to Producer and AdminClient instead of close(long, TimeUnit)

Posted by Mickael Maison <mi...@gmail.com>.
+1 (non-binding)
Thanks!
On Thu, Sep 13, 2018 at 7:05 AM Manikumar <ma...@gmail.com> wrote:
>
> +1 (non-binding)
>
> Thanks for the KIP.
>
> On Thu, Sep 13, 2018 at 10:38 AM Harsha <ka...@harsha.io> wrote:
>
> > +1 (Binding).
> > Thanks,
> > Harsha
> >
> > On Wed, Sep 12, 2018, at 9:06 PM, vito jeng wrote:
> > > +1
> > >
> > >
> > >
> > > ---
> > > Vito
> > >
> > > On Mon, Sep 10, 2018 at 4:52 PM, Dongjin Lee <do...@apache.org> wrote:
> > >
> > > > +1. (Non-binding)
> > > >
> > > > On Mon, Sep 10, 2018 at 4:13 AM Matthias J. Sax <matthias@confluent.io
> > >
> > > > wrote:
> > > >
> > > > > Thanks a lot for the KIP.
> > > > >
> > > > > +1 (binding)
> > > > >
> > > > >
> > > > > -Matthias
> > > > >
> > > > >
> > > > > On 9/8/18 11:27 AM, Chia-Ping Tsai wrote:
> > > > > > Hi All,
> > > > > >
> > > > > > I'd like to put KIP-367 to the vote.
> > > > > >
> > > > > >
> > > > > https://cwiki.apache.org/confluence/pages/viewpage.
> > > > action?pageId=89070496
> > > > > >
> > > > > > --
> > > > > > Chia-Ping
> > > > > >
> > > > >
> > > > >
> > > >
> > > > --
> > > > *Dongjin Lee*
> > > >
> > > > *A hitchhiker in the mathematical world.*
> > > >
> > > > *github:  <http://goog_969573159/>github.com/dongjinleekr
> > > > <http://github.com/dongjinleekr>linkedin:
> > kr.linkedin.com/in/dongjinleekr
> > > > <http://kr.linkedin.com/in/dongjinleekr>slideshare:
> > > > www.slideshare.net/dongjinleekr
> > > > <http://www.slideshare.net/dongjinleekr>*
> > > >
> >

Re: [VOTE] KIP-367 Introduce close(Duration) to Producer and AdminClient instead of close(long, TimeUnit)

Posted by Manikumar <ma...@gmail.com>.
+1 (non-binding)

Thanks for the KIP.

On Thu, Sep 13, 2018 at 10:38 AM Harsha <ka...@harsha.io> wrote:

> +1 (Binding).
> Thanks,
> Harsha
>
> On Wed, Sep 12, 2018, at 9:06 PM, vito jeng wrote:
> > +1
> >
> >
> >
> > ---
> > Vito
> >
> > On Mon, Sep 10, 2018 at 4:52 PM, Dongjin Lee <do...@apache.org> wrote:
> >
> > > +1. (Non-binding)
> > >
> > > On Mon, Sep 10, 2018 at 4:13 AM Matthias J. Sax <matthias@confluent.io
> >
> > > wrote:
> > >
> > > > Thanks a lot for the KIP.
> > > >
> > > > +1 (binding)
> > > >
> > > >
> > > > -Matthias
> > > >
> > > >
> > > > On 9/8/18 11:27 AM, Chia-Ping Tsai wrote:
> > > > > Hi All,
> > > > >
> > > > > I'd like to put KIP-367 to the vote.
> > > > >
> > > > >
> > > > https://cwiki.apache.org/confluence/pages/viewpage.
> > > action?pageId=89070496
> > > > >
> > > > > --
> > > > > Chia-Ping
> > > > >
> > > >
> > > >
> > >
> > > --
> > > *Dongjin Lee*
> > >
> > > *A hitchhiker in the mathematical world.*
> > >
> > > *github:  <http://goog_969573159/>github.com/dongjinleekr
> > > <http://github.com/dongjinleekr>linkedin:
> kr.linkedin.com/in/dongjinleekr
> > > <http://kr.linkedin.com/in/dongjinleekr>slideshare:
> > > www.slideshare.net/dongjinleekr
> > > <http://www.slideshare.net/dongjinleekr>*
> > >
>

Re: [VOTE] KIP-367 Introduce close(Duration) to Producer and AdminClient instead of close(long, TimeUnit)

Posted by Harsha <ka...@harsha.io>.
+1 (Binding).
Thanks,
Harsha

On Wed, Sep 12, 2018, at 9:06 PM, vito jeng wrote:
> +1
> 
> 
> 
> ---
> Vito
> 
> On Mon, Sep 10, 2018 at 4:52 PM, Dongjin Lee <do...@apache.org> wrote:
> 
> > +1. (Non-binding)
> >
> > On Mon, Sep 10, 2018 at 4:13 AM Matthias J. Sax <ma...@confluent.io>
> > wrote:
> >
> > > Thanks a lot for the KIP.
> > >
> > > +1 (binding)
> > >
> > >
> > > -Matthias
> > >
> > >
> > > On 9/8/18 11:27 AM, Chia-Ping Tsai wrote:
> > > > Hi All,
> > > >
> > > > I'd like to put KIP-367 to the vote.
> > > >
> > > >
> > > https://cwiki.apache.org/confluence/pages/viewpage.
> > action?pageId=89070496
> > > >
> > > > --
> > > > Chia-Ping
> > > >
> > >
> > >
> >
> > --
> > *Dongjin Lee*
> >
> > *A hitchhiker in the mathematical world.*
> >
> > *github:  <http://goog_969573159/>github.com/dongjinleekr
> > <http://github.com/dongjinleekr>linkedin: kr.linkedin.com/in/dongjinleekr
> > <http://kr.linkedin.com/in/dongjinleekr>slideshare:
> > www.slideshare.net/dongjinleekr
> > <http://www.slideshare.net/dongjinleekr>*
> >

Re: [VOTE] KIP-367 Introduce close(Duration) to Producer and AdminClient instead of close(long, TimeUnit)

Posted by vito jeng <vi...@is-land.com.tw>.
+1



---
Vito

On Mon, Sep 10, 2018 at 4:52 PM, Dongjin Lee <do...@apache.org> wrote:

> +1. (Non-binding)
>
> On Mon, Sep 10, 2018 at 4:13 AM Matthias J. Sax <ma...@confluent.io>
> wrote:
>
> > Thanks a lot for the KIP.
> >
> > +1 (binding)
> >
> >
> > -Matthias
> >
> >
> > On 9/8/18 11:27 AM, Chia-Ping Tsai wrote:
> > > Hi All,
> > >
> > > I'd like to put KIP-367 to the vote.
> > >
> > >
> > https://cwiki.apache.org/confluence/pages/viewpage.
> action?pageId=89070496
> > >
> > > --
> > > Chia-Ping
> > >
> >
> >
>
> --
> *Dongjin Lee*
>
> *A hitchhiker in the mathematical world.*
>
> *github:  <http://goog_969573159/>github.com/dongjinleekr
> <http://github.com/dongjinleekr>linkedin: kr.linkedin.com/in/dongjinleekr
> <http://kr.linkedin.com/in/dongjinleekr>slideshare:
> www.slideshare.net/dongjinleekr
> <http://www.slideshare.net/dongjinleekr>*
>

Re: [VOTE] KIP-367 Introduce close(Duration) to Producer and AdminClient instead of close(long, TimeUnit)

Posted by Dongjin Lee <do...@apache.org>.
+1. (Non-binding)

On Mon, Sep 10, 2018 at 4:13 AM Matthias J. Sax <ma...@confluent.io>
wrote:

> Thanks a lot for the KIP.
>
> +1 (binding)
>
>
> -Matthias
>
>
> On 9/8/18 11:27 AM, Chia-Ping Tsai wrote:
> > Hi All,
> >
> > I'd like to put KIP-367 to the vote.
> >
> >
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=89070496
> >
> > --
> > Chia-Ping
> >
>
>

-- 
*Dongjin Lee*

*A hitchhiker in the mathematical world.*

*github:  <http://goog_969573159/>github.com/dongjinleekr
<http://github.com/dongjinleekr>linkedin: kr.linkedin.com/in/dongjinleekr
<http://kr.linkedin.com/in/dongjinleekr>slideshare:
www.slideshare.net/dongjinleekr
<http://www.slideshare.net/dongjinleekr>*

Re: [VOTE] KIP-367 Introduce close(Duration) to Producer and AdminClient instead of close(long, TimeUnit)

Posted by "Matthias J. Sax" <ma...@confluent.io>.
Thanks a lot for the KIP.

+1 (binding)


-Matthias


On 9/8/18 11:27 AM, Chia-Ping Tsai wrote:
> Hi All,
> 
> I'd like to put KIP-367 to the vote.
> 
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=89070496
> 
> --
> Chia-Ping
>

Re: [VOTE] KIP-367 Introduce close(Duration) to Producer and AdminClient instead of close(long, TimeUnit)

Posted by Chia-Ping Tsai <ch...@apache.org>.
Thanks for all votes. KIP-367 has passed!!!

binding votes (3) :
Matthias J. Sax
Harsha
Jason Gustafson

non-binding votes (6):
Dongjin Lee
Manikumar
Mickael Maison
vito jeng
Colin McCabe
Bill Bejeck

Cheers,
Chia-Ping

On 2018/09/08 18:27:59, Chia-Ping Tsai <ch...@apache.org> wrote: 
> Hi All,
> 
> I'd like to put KIP-367 to the vote.
> 
> https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=89070496
> 
> --
> Chia-Ping
>