You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2022/11/05 15:59:00 UTC
[jira] [Commented] (IMPALA-11569) Run finalize.sh in bin/jenkins/all-tests.sh even if dataload fails
[ https://issues.apache.org/jira/browse/IMPALA-11569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17629350#comment-17629350 ]
ASF subversion and git services commented on IMPALA-11569:
----------------------------------------------------------
Commit 08a127958fddcddec649c0b3f65c0183ee6d5a90 in impala's branch refs/heads/master from Joe McDonnell
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=08a127958 ]
IMPALA-11706: Unlimit Pytest failures for precommit
The change for IMPALA-11569 modified all-tests.sh
to run bin/bootstrap_development.sh rather than
sourcing it. That means the environment variables
defined in bin/bootstrap_development.sh no longer
apply to all-tests.sh, and thus precommit. In
particular, MAX_PYTEST_FAILURES is no longer set
to zero, so the default of MAX_PYTEST_FAILURES=10
applies. This is too low.
This sets MAX_PYTEST_FAILURES=0 in all-tests.sh to
allow unlimited pytest failures. This also bumps
the default MAX_PYTEST_FAILURES from 10 to 100.
Change-Id: I38209fa357ab4edb4c8730fc2186a84a8eefda0d
Reviewed-on: http://gerrit.cloudera.org:8080/19208
Reviewed-by: Quanlong Huang <hu...@gmail.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
> Run finalize.sh in bin/jenkins/all-tests.sh even if dataload fails
> ------------------------------------------------------------------
>
> Key: IMPALA-11569
> URL: https://issues.apache.org/jira/browse/IMPALA-11569
> Project: IMPALA
> Issue Type: Improvement
> Components: Infrastructure
> Affects Versions: Impala 4.2.0
> Reporter: Joe McDonnell
> Assignee: Joe McDonnell
> Priority: Major
> Fix For: Impala 4.2.0
>
>
> bin/jenkins/all-tests.sh (used for precommit Jenkins jobs) has "set -oeu pipefail" set, so if a command fails, it will exit. Currently, it sources bin/bootstrap_development.sh, so if that fails it will not run finalize.sh.
> {noformat}
> source bin/bootstrap_development.sh
> ...
> RET_CODE=0
> if ! bin/run-all-tests.sh; then
> RET_CODE=1
> fi
> # Shutdown minicluster at the end
> testdata/bin/kill-all.sh
> bin/jenkins/finalize.sh
> exit $RET_CODE{noformat}
> finalize.sh is useful for resolving minidumps and generating JUnitXML. bootstrap_development.sh runs dataload, so Impala could crash and finalize.sh wouldn't run. We should change it so that finalize.sh runs even if dataload fails.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org