[GitHub] [pulsar] sijie commented on a change in pull request #4381: [Issue 4379] [Java Client] Build auth from class and params in PulsarClientImpl

[GitBox <gi...@apache.org>]

sijie commented on a change in pull request #4381: [Issue 4379] [Java Client] Build auth from class and params in PulsarClientImpl
URL: https://github.com/apache/pulsar/pull/4381#discussion_r287738322
 
 

 ##########
 File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/PulsarClientImpl.java
 ##########
 @@ -142,6 +145,13 @@ public PulsarClientImpl(ClientConfigurationData conf, EventLoopGroup eventLoopGr
         state.set(State.Open);
     }
 
+    private void setAuth(ClientConfigurationData conf) throws PulsarClientException {
+        if (StringUtils.isBlank(conf.getAuthPluginClassName()) || StringUtils.isBlank( conf.getAuthParams()))
 
 Review comment:
   ```suggestion
           if (StringUtils.isBlank(conf.getAuthPluginClassName()) || StringUtils.isBlank( conf.getAuthParams())) {
               return;
           }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services