You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by mj...@apache.org on 2024/01/19 02:00:18 UTC
(kafka) branch trunk updated: KAFKA-16159: MINOR - Correcting logs to debug telemetry reporter (#15228)
This is an automated email from the ASF dual-hosted git repository.
mjsax pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/kafka.git
The following commit(s) were added to refs/heads/trunk by this push:
new 8950ed10a7a KAFKA-16159: MINOR - Correcting logs to debug telemetry reporter (#15228)
8950ed10a7a is described below
commit 8950ed10a7a869488d7f73821f619608caa11819
Author: Apoorv Mittal <am...@confluent.io>
AuthorDate: Fri Jan 19 07:30:09 2024 +0530
KAFKA-16159: MINOR - Correcting logs to debug telemetry reporter (#15228)
Removed debug log as next time to update runs in poll loop and excessive logging happens.
Reviewers: Qichao Chu <qi...@uber.com>, Philip Nee <pn...@confluent.io>, Matthias J. Sax <ma...@confluent.io>
---
.../kafka/common/telemetry/internals/ClientTelemetryReporter.java | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java b/clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java
index 6e249c85637..ae92c539daf 100644
--- a/clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java
+++ b/clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java
@@ -362,7 +362,7 @@ public class ClientTelemetryReporter implements MetricsReporter {
throw new IllegalStateException("Unknown telemetry state: " + localState);
}
- log.debug("For telemetry state {}, returning the value {} ms; {}", localState, timeMs, msg);
+ log.trace("For telemetry state {}, returning the value {} ms; {}", localState, timeMs, msg);
return timeMs;
}
@@ -639,6 +639,7 @@ public class ClientTelemetryReporter implements MetricsReporter {
signal to the broker that we need to have a client instance ID assigned.
*/
Uuid clientInstanceId = (localSubscription != null) ? localSubscription.clientInstanceId() : Uuid.ZERO_UUID;
+ log.debug("Creating telemetry subscription request with client instance id {}", clientInstanceId);
lock.writeLock().lock();
try {
@@ -667,6 +668,7 @@ public class ClientTelemetryReporter implements MetricsReporter {
return Optional.empty();
}
+ log.debug("Creating telemetry push request with client instance id {}", localSubscription.clientInstanceId());
/*
Don't send a push request if we don't have the collector initialized. Re-attempt
the push on the next interval.