You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by ji...@codehaus.org on 2004/06/16 23:44:19 UTC
[jira] Created: (MPJNLP-13) Fix for sigining jars + adding support for property keypass
Message:
A new issue has been created in JIRA.
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPJNLP-13
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPJNLP-13
Summary: Fix for sigining jars + adding support for property keypass
Type: Improvement
Status: Open
Priority: Major
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-jnlp-plugin
Assignee: Emmanuel Venisse
Reporter: Martin van den Bemt
Created: Wed, 16 Jun 2004 5:44 PM
Updated: Wed, 16 Jun 2004 5:44 PM
Description:
I couldn't get much jars signed for my dependencies (about 30).
The resulting jar would end up as .jar instead of the jarname.jar.
Changed lib.final.name to use dep.artifact.
Als added support for the keypass property when generating a store and signing jars. The current ant behaviour is that an empty value is treated as a value and the option is passed to the jarsigner. Since there is the needs for a minimum password of 6 chars, we can safely assume that empty or null is actually meant to be no password.
I overriden the tasks from ant to accomplish this behaviour. It also saves a lot of duplicating, since it is not possible (at least I could not find it) to have conditional attributes.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MPJNLP-13) Fix for sigining jars + adding support for property keypass
Posted by ji...@codehaus.org.
The following issue has been updated:
Updater: Martin van den Bemt (mailto:martin@mvdb.net)
Date: Wed, 16 Jun 2004 5:45 PM
Comment:
If you didn't notice : these files are new :)
Changes:
Attachment changed to MavenSignJarTask.java
---------------------------------------------------------------------
For a full history of the issue, see:
http://jira.codehaus.org/browse/MPJNLP-13?page=history
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPJNLP-13
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPJNLP-13
Summary: Fix for sigining jars + adding support for property keypass
Type: Improvement
Status: Open
Priority: Major
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-jnlp-plugin
Assignee: Emmanuel Venisse
Reporter: Martin van den Bemt
Created: Wed, 16 Jun 2004 5:44 PM
Updated: Wed, 16 Jun 2004 5:45 PM
Description:
I couldn't get much jars signed for my dependencies (about 30).
The resulting jar would end up as .jar instead of the jarname.jar.
Changed lib.final.name to use dep.artifact.
Als added support for the keypass property when generating a store and signing jars. The current ant behaviour is that an empty value is treated as a value and the option is passed to the jarsigner. Since there is the needs for a minimum password of 6 chars, we can safely assume that empty or null is actually meant to be no password.
I overriden the tasks from ant to accomplish this behaviour. It also saves a lot of duplicating, since it is not possible (at least I could not find it) to have conditional attributes.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MPJNLP-13) Fix for sigining jars + adding support for property keypass
Posted by ji...@codehaus.org.
The following issue has been updated:
Updater: Martin van den Bemt (mailto:martin@mvdb.net)
Date: Wed, 16 Jun 2004 5:45 PM
Changes:
Attachment changed to MavenGenerateKeyTask.java
---------------------------------------------------------------------
For a full history of the issue, see:
http://jira.codehaus.org/browse/MPJNLP-13?page=history
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPJNLP-13
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPJNLP-13
Summary: Fix for sigining jars + adding support for property keypass
Type: Improvement
Status: Open
Priority: Major
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-jnlp-plugin
Assignee: Emmanuel Venisse
Reporter: Martin van den Bemt
Created: Wed, 16 Jun 2004 5:44 PM
Updated: Wed, 16 Jun 2004 5:45 PM
Description:
I couldn't get much jars signed for my dependencies (about 30).
The resulting jar would end up as .jar instead of the jarname.jar.
Changed lib.final.name to use dep.artifact.
Als added support for the keypass property when generating a store and signing jars. The current ant behaviour is that an empty value is treated as a value and the option is passed to the jarsigner. Since there is the needs for a minimum password of 6 chars, we can safely assume that empty or null is actually meant to be no password.
I overriden the tasks from ant to accomplish this behaviour. It also saves a lot of duplicating, since it is not possible (at least I could not find it) to have conditional attributes.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPJNLP-13) Fix for sigining jars + adding support for property keypass
Posted by ji...@codehaus.org.
The following comment has been added to this issue:
Author: dion gillard
Created: Sat, 19 Jun 2004 8:28 AM
Body:
It looks the two java files for this problem report only exist to make sure an empty or null value isn't passed through.
This could better be done with <ant:setProperty> surrounded by an <if>.
---------------------------------------------------------------------
View this comment:
http://jira.codehaus.org/browse/MPJNLP-13?page=comments#action_20830
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPJNLP-13
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPJNLP-13
Summary: Fix for sigining jars + adding support for property keypass
Type: Improvement
Status: Closed
Priority: Major
Resolution: WON'T FIX
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-jnlp-plugin
Assignee: Emmanuel Venisse
Reporter: Martin van den Bemt
Created: Wed, 16 Jun 2004 5:44 PM
Updated: Sat, 19 Jun 2004 8:28 AM
Description:
I couldn't get much jars signed for my dependencies (about 30).
The resulting jar would end up as .jar instead of the jarname.jar.
Changed lib.final.name to use dep.artifact.
Als added support for the keypass property when generating a store and signing jars. The current ant behaviour is that an empty value is treated as a value and the option is passed to the jarsigner. Since there is the needs for a minimum password of 6 chars, we can safely assume that empty or null is actually meant to be no password.
I overriden the tasks from ant to accomplish this behaviour. It also saves a lot of duplicating, since it is not possible (at least I could not find it) to have conditional attributes.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPJNLP-13) Fix for sigining jars + adding support for property keypass
Posted by ji...@codehaus.org.
The following comment has been added to this issue:
Author: dion gillard
Created: Sat, 19 Jun 2004 8:20 AM
Body:
what's the reason?
---------------------------------------------------------------------
View this comment:
http://jira.codehaus.org/browse/MPJNLP-13?page=comments#action_20829
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPJNLP-13
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPJNLP-13
Summary: Fix for sigining jars + adding support for property keypass
Type: Improvement
Status: Closed
Priority: Major
Resolution: WON'T FIX
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-jnlp-plugin
Assignee: Emmanuel Venisse
Reporter: Martin van den Bemt
Created: Wed, 16 Jun 2004 5:44 PM
Updated: Sat, 19 Jun 2004 8:20 AM
Description:
I couldn't get much jars signed for my dependencies (about 30).
The resulting jar would end up as .jar instead of the jarname.jar.
Changed lib.final.name to use dep.artifact.
Als added support for the keypass property when generating a store and signing jars. The current ant behaviour is that an empty value is treated as a value and the option is passed to the jarsigner. Since there is the needs for a minimum password of 6 chars, we can safely assume that empty or null is actually meant to be no password.
I overriden the tasks from ant to accomplish this behaviour. It also saves a lot of duplicating, since it is not possible (at least I could not find it) to have conditional attributes.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPJNLP-13) Fix for sigining jars + adding support for property keypass
Posted by ji...@codehaus.org.
The following comment has been added to this issue:
Author: Emmanuel Venisse
Created: Sat, 19 Jun 2004 9:12 AM
Body:
Dion, you can continue your tests now. I fixed it in CVS.
---------------------------------------------------------------------
View this comment:
http://jira.codehaus.org/browse/MPJNLP-13?page=comments#action_20835
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPJNLP-13
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPJNLP-13
Summary: Fix for sigining jars + adding support for property keypass
Type: Improvement
Status: Closed
Priority: Major
Resolution: WON'T FIX
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-jnlp-plugin
Assignee: Emmanuel Venisse
Reporter: Martin van den Bemt
Created: Wed, 16 Jun 2004 5:44 PM
Updated: Sat, 19 Jun 2004 9:12 AM
Description:
I couldn't get much jars signed for my dependencies (about 30).
The resulting jar would end up as .jar instead of the jarname.jar.
Changed lib.final.name to use dep.artifact.
Als added support for the keypass property when generating a store and signing jars. The current ant behaviour is that an empty value is treated as a value and the option is passed to the jarsigner. Since there is the needs for a minimum password of 6 chars, we can safely assume that empty or null is actually meant to be no password.
I overriden the tasks from ant to accomplish this behaviour. It also saves a lot of duplicating, since it is not possible (at least I could not find it) to have conditional attributes.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Updated: (MPJNLP-13) Fix for sigining jars + adding support for property keypass
Posted by ji...@codehaus.org.
The following issue has been updated:
Updater: Martin van den Bemt (mailto:martin@mvdb.net)
Date: Wed, 16 Jun 2004 5:44 PM
Changes:
Attachment changed to jnlp.diff
---------------------------------------------------------------------
For a full history of the issue, see:
http://jira.codehaus.org/browse/MPJNLP-13?page=history
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPJNLP-13
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPJNLP-13
Summary: Fix for sigining jars + adding support for property keypass
Type: Improvement
Status: Open
Priority: Major
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-jnlp-plugin
Assignee: Emmanuel Venisse
Reporter: Martin van den Bemt
Created: Wed, 16 Jun 2004 5:44 PM
Updated: Wed, 16 Jun 2004 5:44 PM
Description:
I couldn't get much jars signed for my dependencies (about 30).
The resulting jar would end up as .jar instead of the jarname.jar.
Changed lib.final.name to use dep.artifact.
Als added support for the keypass property when generating a store and signing jars. The current ant behaviour is that an empty value is treated as a value and the option is passed to the jarsigner. Since there is the needs for a minimum password of 6 chars, we can safely assume that empty or null is actually meant to be no password.
I overriden the tasks from ant to accomplish this behaviour. It also saves a lot of duplicating, since it is not possible (at least I could not find it) to have conditional attributes.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Commented: (MPJNLP-13) Fix for sigining jars + adding support for property keypass
Posted by ji...@codehaus.org.
The following comment has been added to this issue:
Author: dion gillard
Created: Sat, 19 Jun 2004 8:39 AM
Body:
I've got a test project for the jnlp plugin, but it currently fails for me with
" [signjar] Signing Jar : C:\source\maven-plugins\jnlp\src\plugin-test\target\jnlp_temp\test-maven-jnlp-plugin-1.0-SNAPSHOT.jar
[signjar] jarsigner error: java.lang.RuntimeException: keystore load: Invalid keystore format"
If you can help me resolve this, we can work on getting the patch or something like it applied.
---------------------------------------------------------------------
View this comment:
http://jira.codehaus.org/browse/MPJNLP-13?page=comments#action_20831
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPJNLP-13
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPJNLP-13
Summary: Fix for sigining jars + adding support for property keypass
Type: Improvement
Status: Closed
Priority: Major
Resolution: WON'T FIX
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-jnlp-plugin
Assignee: Emmanuel Venisse
Reporter: Martin van den Bemt
Created: Wed, 16 Jun 2004 5:44 PM
Updated: Sat, 19 Jun 2004 8:39 AM
Description:
I couldn't get much jars signed for my dependencies (about 30).
The resulting jar would end up as .jar instead of the jarname.jar.
Changed lib.final.name to use dep.artifact.
Als added support for the keypass property when generating a store and signing jars. The current ant behaviour is that an empty value is treated as a value and the option is passed to the jarsigner. Since there is the needs for a minimum password of 6 chars, we can safely assume that empty or null is actually meant to be no password.
I overriden the tasks from ant to accomplish this behaviour. It also saves a lot of duplicating, since it is not possible (at least I could not find it) to have conditional attributes.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
[jira] Closed: (MPJNLP-13) Fix for sigining jars + adding support for property keypass
Posted by ji...@codehaus.org.
Message:
The following issue has been closed.
Resolver: Martin van den Bemt
Date: Sat, 19 Jun 2004 7:50 AM
You can apply if you want, but I withdraw this patch.
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPJNLP-13
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPJNLP-13
Summary: Fix for sigining jars + adding support for property keypass
Type: Improvement
Status: Closed
Priority: Major
Resolution: WON'T FIX
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven-jnlp-plugin
Assignee: Emmanuel Venisse
Reporter: Martin van den Bemt
Created: Wed, 16 Jun 2004 5:44 PM
Updated: Sat, 19 Jun 2004 7:50 AM
Description:
I couldn't get much jars signed for my dependencies (about 30).
The resulting jar would end up as .jar instead of the jarname.jar.
Changed lib.final.name to use dep.artifact.
Als added support for the keypass property when generating a store and signing jars. The current ant behaviour is that an empty value is treated as a value and the option is passed to the jarsigner. Since there is the needs for a minimum password of 6 chars, we can safely assume that empty or null is actually meant to be no password.
I overriden the tasks from ant to accomplish this behaviour. It also saves a lot of duplicating, since it is not possible (at least I could not find it) to have conditional attributes.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org