You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/02 16:19:06 UTC
[GitHub] [flink] dawidwys commented on a change in pull request #11622:
[FLINK-16913][configuration,
statebackend] Migrated StateBackends to use ReadableConfig instead of
Configuration
dawidwys commented on a change in pull request #11622: [FLINK-16913][configuration, statebackend] Migrated StateBackends to use ReadableConfig instead of Configuration
URL: https://github.com/apache/flink/pull/11622#discussion_r402440578
##########
File path: flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBOptions.java
##########
@@ -47,9 +48,10 @@
* Choice of timer service implementation.
*/
@Documentation.Section(Documentation.Sections.STATE_BACKEND_ROCKSDB)
- public static final ConfigOption<String> TIMER_SERVICE_FACTORY = ConfigOptions
+ public static final ConfigOption<PriorityQueueStateType> TIMER_SERVICE_FACTORY = ConfigOptions
Review comment:
> I would not be too worried, though, because most users probably would not use this in code but rather in the yaml config.
That was also my thinking after looking at it again. The class `RocksDBOptions` has no annotation, so it is not necessarily `Public`. Moreover I think we do not advertise using those options directly. Programatically users should rather use `org.apache.flink.contrib.streaming.state.RocksDBStateBackend#setPriorityQueueStateType`, if I am not mistaken.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services