[GitHub] [incubator-superset] yciabaud edited a comment on issue #7297: [WIP] bugfix: Tables and schemas with slashes break SQL Lab

[GitBox <gi...@apache.org>]

yciabaud edited a comment on issue #7297: [WIP] bugfix: Tables and schemas with slashes break SQL Lab
URL: https://github.com/apache/incubator-superset/pull/7297#issuecomment-483058040
 
 
   Hello I tried your branch using docker but I am still having some issues when selecting a table.
   There is a call on http://localhost:8088/superset/table/2/generator_test/public%252Fdefault/ with a status 500.
   Maybe I did something wrong? 
   ```
   Traceback (most recent call last):
     File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 2309, in __call__
       return self.wsgi_app(environ, start_response)
     File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 2295, in wsgi_app
       response = self.handle_exception(e)
     File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1741, in handle_exception
       reraise(exc_type, exc_value, tb)
     File "/usr/local/lib/python3.6/site-packages/flask/_compat.py", line 35, in reraise
       raise value
     File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 2292, in wsgi_app
       response = self.full_dispatch_request()
     File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1815, in full_dispatch_request
       rv = self.handle_user_exception(e)
     File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1718, in handle_user_exception
       reraise(exc_type, exc_value, tb)
     File "/usr/local/lib/python3.6/site-packages/flask/_compat.py", line 35, in reraise
       raise value
     File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1813, in full_dispatch_request
       rv = self.dispatch_request()
     File "/usr/local/lib/python3.6/site-packages/flask/app.py", line 1799, in dispatch_request
       return self.view_functions[rule.endpoint](**req.view_args)
     File "/usr/local/lib/python3.6/site-packages/flask_appbuilder/security/decorators.py", line 26, in wraps
       return f(self, *args, **kwargs)
     File "/home/superset/superset/models/core.py", line 1163, in wrapper
       value = f(*args, **kwargs)
     File "/home/superset/superset/views/core.py", line 2404, in table
       cols=columns, latest_partition=True),
     File "/home/superset/superset/models/core.py", line 908, in select_star
       schema=schema, source=utils.sources.get('sql_lab', None))
     File "/home/superset/superset/utils/core.py", line 114, in __call__
       value = self.func(*args, **kwargs)
     File "/home/superset/superset/models/core.py", line 828, in get_sqla_engine
       return create_engine(url, **params)
     File "/usr/local/lib/python3.6/site-packages/sqlalchemy/engine/__init__.py", line 423, in create_engine
       return strategy.create(*args, **kwargs)
     File "/usr/local/lib/python3.6/site-packages/sqlalchemy/engine/strategies.py", line 98, in create
       (cargs, cparams) = dialect.create_connect_args(u)
     File "/usr/local/lib/python3.6/site-packages/pyhive/sqlalchemy_presto.py", line 106, in create_connect_args
       raise ValueError("Unexpected database format {}".format(url.database))
   ValueError: Unexpected database format pulsar/public/default
   ```
   
   Here the database is "pulsar" and the schema is "public/default". A working query is `select * from pulsar."public/default".generator_test;`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org