[GitHub] [netbeans] timboudreau commented on issue #1639: FIX: fire a table model event even if there are no children yet.

[GitBox <gi...@apache.org>]

timboudreau commented on issue #1639: FIX: fire a table model event even if there are no children yet.
URL: https://github.com/apache/netbeans/pull/1639#issuecomment-559900698
 
 
   As the author of that code, sounds good to me.  Listener ordering bugs are
   painful to debug (I once spent a couple of days chasing down a bug that
   only occurred when the look and feel had been changed without a restart,
   because UI delegate listeners wind up called before instead of after
   application listeners), so avoiding them is a fine thing.
   
   -Tim
   
   
   On Fri, Nov 29, 2019 at 4:28 PM nishihatapalmer <no...@github.com>
   wrote:
   
   > Thinking about this issue a little more, the whole point of the
   > EventBroadcaster is to translate tree events into table events.
   >
   > If we allow any tree modification during tree events, then the
   > EventBroadcaster should always be the last listener to run for all tree
   > events (not the just the one raised in this issue).
   >
   > The fix above which inserts new listeners at the start of the list works,
   > but it isn't obvious why this needs to be done. It might be better to
   > refactor the code so that the EventBroadcaster is explicitly the last
   > listener to run - so it has a special status, and isn't part of the main
   > list of other registered listeners.
   >
   > I think this would make the intention of the code clearer.
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/netbeans/pull/1639?email_source=notifications&email_token=AAOQE5Z64MEIUGRQB7NPKODQWGCQXA5CNFSM4JOJLZVKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFPSGVA#issuecomment-559883092>,
   > or unsubscribe
   > <https://github.com/notifications/unsubscribe-auth/AAOQE5YEI5AIZBDRIBNSRB3QWGCQXANCNFSM4JOJLZVA>
   > .
   >
   
   
   -- 
   http://timboudreau.com
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists