You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "darrylring (via GitHub)" <gi...@apache.org> on 2026/10/22 16:59:01 UTC
[PR] arch/arm/stm32h5: Clock SBS for OTP word access [nuttx]
darrylring opened a new pull request, #20892:
URL: https://github.com/apache/nuttx/pull/20892
## Summary
OTP flash word accesses require modifying an SBS register bit, but the SBS clock is not enabled by NuttX unless Ethernet or EDATA are enabled. This ensures the SBS is clocked whenever OTP word access is enabled.
https://github.com/apache/nuttx/blob/master/arch/arm/src/stm32h5/stm32h5xx_rcc.c#L616
Possibly it would be better to change that check to just `#if defined(CONFIG_STM32_SBS)` and add a Kconfig menu item to enable/disable SBS support, which is `select`ed by `STM32_ETHMAC`.
## Impact
Fixes an issue present in the OTP word access feature added in https://github.com/apache/nuttx/pull/20434.
## Testing
OTP word accesses were failing before, but do not fail now!
Testable by inspection, `.config` before:
```
#
# STM32H5 OTP Options
#
CONFIG_STM32H5_OTP_WORD=y
CONFIG_STM32H5_OTP_WRITE=y
...
# CONFIG_STM32_EDATA is not set
```
After:
```
#
# STM32H5 OTP Options
#
CONFIG_STM32H5_OTP_WORD=y
CONFIG_STM32H5_OTP_WRITE=y
...
CONFIG_STM32_SBS=y
# CONFIG_STM32_EDATA is not set
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/arm/stm32h5: Clock SBS for OTP word access [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis merged PR #20892:
URL: https://github.com/apache/nuttx/pull/20892
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/arm/stm32h5: Clock SBS for OTP word access [nuttx]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20892:
URL: https://github.com/apache/nuttx/pull/20892#issuecomment-6354138531
<!-- membrowse-pr-comment -->
## <img src="https://membrowse.com/membrowse-logo.svg" height="24" align="top"> MemBrowse Memory Report · [Explore what changed →](https://membrowse.com/public/apache/nuttx?commit_sha=7141fed6d961a783c9b756c23d95dbc090768182)
*No memory changes detected for:*
- [arduino-mega2560](https://membrowse.com/public/apache/nuttx/target/arduino-mega2560/compare?head=7141fed6d961a783c9b756c23d95dbc090768182&base=2ba1898abbd7d438b2975c82413761f8ddaba3a7)
- [esp32-devkitc](https://membrowse.com/public/apache/nuttx/target/esp32-devkitc/compare?head=7141fed6d961a783c9b756c23d95dbc090768182&base=2ba1898abbd7d438b2975c82413761f8ddaba3a7)
- [hifive1-revb](https://membrowse.com/public/apache/nuttx/target/hifive1-revb/compare?head=7141fed6d961a783c9b756c23d95dbc090768182&base=2ba1898abbd7d438b2975c82413761f8ddaba3a7)
- [mirtoo](https://membrowse.com/public/apache/nuttx/target/mirtoo/compare?head=7141fed6d961a783c9b756c23d95dbc090768182&base=2ba1898abbd7d438b2975c82413761f8ddaba3a7)
- [qemu-armv8a](https://membrowse.com/public/apache/nuttx/target/qemu-armv8a/compare?head=7141fed6d961a783c9b756c23d95dbc090768182&base=2ba1898abbd7d438b2975c82413761f8ddaba3a7)
- [qemu-intel64](https://membrowse.com/public/apache/nuttx/target/qemu-intel64/compare?head=7141fed6d961a783c9b756c23d95dbc090768182&base=2ba1898abbd7d438b2975c82413761f8ddaba3a7)
- [rx65n-rsk2mb](https://membrowse.com/public/apache/nuttx/target/rx65n-rsk2mb/compare?head=7141fed6d961a783c9b756c23d95dbc090768182&base=2ba1898abbd7d438b2975c82413761f8ddaba3a7)
- [s698pm-dkit](https://membrowse.com/public/apache/nuttx/target/s698pm-dkit/compare?head=7141fed6d961a783c9b756c23d95dbc090768182&base=2ba1898abbd7d438b2975c82413761f8ddaba3a7)
- [stm32-nucleo-f103rb](https://membrowse.com/public/apache/nuttx/target/stm32-nucleo-f103rb/compare?head=7141fed6d961a783c9b756c23d95dbc090768182&base=2ba1898abbd7d438b2975c82413761f8ddaba3a7)
---
<sub>Catch memory regressions in CI with [MemBrowse](https://membrowse.com). Free for open source.</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org