[GitHub] [incubator-pinot] deemoliu commented on a change in pull request #6874: Init mutableSegmentRecordReader to handle partial upsert record lookup

[GitBox <gi...@apache.org>]

deemoliu commented on a change in pull request #6874:
URL: https://github.com/apache/incubator-pinot/pull/6874#discussion_r625428824



##########
File path: pinot-core/src/main/java/org/apache/pinot/core/indexsegment/mutable/MutableSegmentImpl.java
##########
@@ -160,6 +161,8 @@
   private final ThreadSafeMutableRoaringBitmap _validDocIds;
   private final ValidDocIndexReader _validDocIndex;
 
+  private final PinotSegmentRecordReader _pinotSegmentRecordReader;

Review comment:
       @Jackie-Jiang Got it. I think i am going to use this API in another PR. When lookup the previous record for merge, 
   do you think it's suitable to make recordReader an instance variable of mutableSegment? or should I init recordReader a local variable of PartialUpsert Handler?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org