You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@otava.apache.org by "ligurio (via GitHub)" <gi...@apache.org> on 2025/04/04 09:46:55 UTC
[PR] Documentation fixes [otava]
ligurio opened a new pull request, #48:
URL: https://github.com/apache/otava/pull/48
Closes #47
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@otava.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Documentation fixes [otava]
Posted by "henrikingo (via GitHub)" <gi...@apache.org>.
henrikingo commented on code in PR #48:
URL: https://github.com/apache/otava/pull/48#discussion_r2028663920
##########
docs/INSTALL.md:
##########
@@ -36,3 +36,13 @@ To build the Docker container, run the following command:
```bash
docker build -t otava .
```
+
+> [!NOTE]
+> The Dockerfile contains a `--mount` option that requires BuildKit [^1].
+> The BuildKit can be installed with the following commands:
+>
+> Debian and Ubuntu: `apt install -y docker-buildx`
+>
+> Fedora: `dnf install docker-buildx`
+>
+> [^1]: https://docs.docker.com/go/buildkit/
Review Comment:
Aplogies, I'm following a bit from a distance these past weeks... But wasn't this docker issue resolved by using python ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@otava.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Documentation fixes [otava]
Posted by "ligurio (via GitHub)" <gi...@apache.org>.
ligurio commented on code in PR #48:
URL: https://github.com/apache/otava/pull/48#discussion_r2028689082
##########
docs/INSTALL.md:
##########
@@ -36,3 +36,13 @@ To build the Docker container, run the following command:
```bash
docker build -t otava .
```
+
+> [!NOTE]
+> The Dockerfile contains a `--mount` option that requires BuildKit [^1].
+> The BuildKit can be installed with the following commands:
+>
+> Debian and Ubuntu: `apt install -y docker-buildx`
+>
+> Fedora: `dnf install docker-buildx`
+>
+> [^1]: https://docs.docker.com/go/buildkit/
Review Comment:
`otava`'s installation guide suggest two ways: installation via pipx and installation to the docker container. It is two independent ways of installation. The second way is failed without BuildKit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@otava.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Documentation fixes [otava]
Posted by "ligurio (via GitHub)" <gi...@apache.org>.
ligurio commented on PR #48:
URL: https://github.com/apache/otava/pull/48#issuecomment-2796173949
@Gerrrr Alex, ok to merge? (this PR is actually was requested by you in https://github.com/apache/otava/issues/47#issuecomment-2777355476)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@otava.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Documentation fixes [otava]
Posted by "henrikingo (via GitHub)" <gi...@apache.org>.
henrikingo merged PR #48:
URL: https://github.com/apache/otava/pull/48
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@otava.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Documentation fixes [otava]
Posted by "henrikingo (via GitHub)" <gi...@apache.org>.
henrikingo commented on PR #48:
URL: https://github.com/apache/otava/pull/48#issuecomment-2796706281
Sorry, a bit new situation for me that I am the committer of an apache project :-) Merged now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@otava.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Documentation fixes [otava]
Posted by "henrikingo (via GitHub)" <gi...@apache.org>.
henrikingo commented on code in PR #48:
URL: https://github.com/apache/otava/pull/48#discussion_r2030183277
##########
docs/INSTALL.md:
##########
@@ -36,3 +36,13 @@ To build the Docker container, run the following command:
```bash
docker build -t otava .
```
+
+> [!NOTE]
+> The Dockerfile contains a `--mount` option that requires BuildKit [^1].
+> The BuildKit can be installed with the following commands:
+>
+> Debian and Ubuntu: `apt install -y docker-buildx`
+>
+> Fedora: `dnf install docker-buildx`
+>
+> [^1]: https://docs.docker.com/go/buildkit/
Review Comment:
Yeah ok, in `tox.ini` we also explicitly use `docker buildx`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@otava.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org