[GitHub] spark pull request #16938: [SPARK-19583][SQL]CTAS for data source table with...

[windpiger <gi...@git.apache.org>]

Github user windpiger commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16938#discussion_r103591648
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala ---
    @@ -412,15 +412,28 @@ case class DataSource(
         //  2. Output path must be a legal HDFS style file system path;
         //  3. It's OK that the output path doesn't exist yet;
         val allPaths = paths ++ caseInsensitiveOptions.get("path")
    -    val outputPath = if (allPaths.length == 1) {
    +    val (outputPath, pathExists) = if (allPaths.length == 1) {
           val path = new Path(allPaths.head)
           val fs = path.getFileSystem(sparkSession.sessionState.newHadoopConf())
    -      path.makeQualified(fs.getUri, fs.getWorkingDirectory)
    +      val qualifiedOutputPath = path.makeQualified(fs.getUri, fs.getWorkingDirectory)
    +      (qualifiedOutputPath, fs.exists(qualifiedOutputPath))
         } else {
           throw new IllegalArgumentException("Expected exactly one path to be specified, but " +
             s"got: ${allPaths.mkString(", ")}")
         }
     
    +    if (pathExists) {
    --- End diff --
    
    I think in `InsertIntoHadoopFsRelationCommand `, it just care the overwrite logic,  like `InsertIntoHiveTableCommand` https://github.com/apache/spark/blob/master/sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveTable.scala#L80


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org