You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Konstantin Kolinko <kn...@gmail.com> on 2010/05/18 12:49:12 UTC
Re: [GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk)
failed
2010/5/18 Bill Barker <bi...@apache.org>:
> The current state of this project is 'Failed', with reason 'Build Failed'.
> For reference only, the following projects are affected by this:
> - tomcat-trunk-test : Java Servlet 3.0, Java Server Pages 2.2 & Expression Languag...
>
>
> Full details are available at:
> http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/index.html
>
Bad news are that TestCoyoteAdaptor is still failing.
Good news are that all the other tests completed successfully.
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/gump_file/TEST-org.apache.catalina.connector.TestCoyoteAdaptor.txt.html
Testcase: testPathParams took 3.626 sec
FAILED
expected:<1234> but was:<none>
junit.framework.ComparisonFailure: expected:<1234> but was:<none>
at org.apache.catalina.connector.TestCoyoteAdaptor.testPath(TestCoyoteAdaptor.java:58)
at org.apache.catalina.connector.TestCoyoteAdaptor.testPathParams(TestCoyoteAdaptor.java:49)
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk)
failed
Posted by Mark Thomas <ma...@apache.org>.
On 20/05/2010 03:00, Konstantin Kolinko wrote:
> The problem is that the request for /foo servlet on Gump is not
> served, but is redirected to /foo/, and that redirection loses the
> "jsessionid" parameter.
>
> // Must have a real docBase - just use temp
> Context ctx =
> tomcat.addContext("/", System.getProperty("java.io.tmpdir"));
>
> Finally, now I am _able_ to reproduce the issue. It happens if I
> create a subdirectory "foo" in the system temporary directory.
>
> Losing jsessionid on a redirection is a bug.
Fantastic. I'm gald we cracked this one. I can reproduce it too.
Working on a fix now...
On reflection, unless anyone objects, I am going to leave the debug code
in CoyoteAdapter. The overhead is minimal and it has proved very useful.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk)
failed
Posted by Konstantin Kolinko <kn...@gmail.com>.
2010/5/19 Konstantin Kolinko <kn...@gmail.com>:
>
1. I fixed the issues with tests failing because of non-default value
of ${tomcat.output}.
All tests on a VM running Linux are now completing successfully for me.
2. Gump run has happened. The failures in TestCoyoteAdapter were observed.
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/gump_file/TEST-org.apache.catalina.connector.TestCoyoteAdapter.txt.html
Looking at the log file from Gump:
Gump log:
-----------------------
INFO: Starting Coyote HTTP/1.1 on http-8002
May 19, 2010 10:26:09 AM org.apache.catalina.connector.CoyoteAdapter
parsePathParameters
FINE: The variable [uriBC] has value [/foo]
May 19, 2010 10:26:09 AM org.apache.catalina.connector.CoyoteAdapter
parsePathParameters
FINE: The variable [semicolon] has value [-1]
May 19, 2010 10:26:09 AM org.apache.catalina.connector.CoyoteAdapter
parsePathParameters
FINE: The variable [enc] has value [ISO-8859-1]
May 19, 2010 10:26:09 AM org.apache.catalina.connector.CoyoteAdapter
parsePathParameters
FINE: The variable [uriBC] has value [/foo/]
May 19, 2010 10:26:09 AM org.apache.catalina.connector.CoyoteAdapter
parsePathParameters
FINE: The variable [semicolon] has value [-1]
May 19, 2010 10:26:09 AM org.apache.catalina.connector.CoyoteAdapter
parsePathParameters
FINE: The variable [enc] has value [ISO-8859-1]
May 19, 2010 10:26:09 AM org.apache.coyote.http11.AbstractHttp11Protocol pause
INFO: Pausing Coyote HTTP/1.1 on http-8002
-----------------------
Gump log:
-----------------------
INFO: Starting Coyote HTTP/1.1 on http-8004
May 19, 2010 10:26:11 AM org.apache.catalina.connector.CoyoteAdapter
parsePathParameters
FINE: The variable [uriBC] has value [/foo;jsessionid=1234]
May 19, 2010 10:26:11 AM org.apache.catalina.connector.CoyoteAdapter
parsePathParameters
FINE: The variable [semicolon] has value [4]
May 19, 2010 10:26:11 AM org.apache.catalina.connector.CoyoteAdapter
parsePathParameters
FINE: The variable [enc] has value [ISO-8859-1]
May 19, 2010 10:26:11 AM org.apache.catalina.connector.CoyoteAdapter
parsePathParameters
FINE: The variable [pathParamStart] has value [5]
May 19, 2010 10:26:11 AM org.apache.catalina.connector.CoyoteAdapter
parsePathParameters
FINE: The variable [pathParamEnd] has value [-1]
May 19, 2010 10:26:11 AM org.apache.catalina.connector.CoyoteAdapter
parsePathParameters
FINE: The variable [pv] has value [jsessionid=1234]
May 19, 2010 10:26:11 AM org.apache.catalina.connector.CoyoteAdapter
parsePathParameters
FINE: The variable [equals] has value [10]
May 19, 2010 10:26:11 AM org.apache.catalina.connector.CoyoteAdapter
parsePathParameters
FINE: The variable [name] has value [jsessionid]
May 19, 2010 10:26:11 AM org.apache.catalina.connector.CoyoteAdapter
parsePathParameters
FINE: The variable [value] has value [1234]
May 19, 2010 10:26:11 AM org.apache.catalina.connector.CoyoteAdapter
parsePathParameters
FINE: The variable [uriBC] has value [/foo/]
May 19, 2010 10:26:11 AM org.apache.catalina.connector.CoyoteAdapter
parsePathParameters
FINE: The variable [semicolon] has value [-1]
May 19, 2010 10:26:11 AM org.apache.catalina.connector.CoyoteAdapter
parsePathParameters
FINE: The variable [enc] has value [ISO-8859-1]
May 19, 2010 10:26:11 AM org.apache.coyote.http11.AbstractHttp11Protocol pause
INFO: Pausing Coyote HTTP/1.1 on http-8004
-----------------------
The above log excerpts are for testPathParmsFooNone and
testPathParmsFooSessionOnly respectively.
In my environment the second request, "The variable [uriBC] has value
[/foo/]" and all that follows it does not happen.
The problem is that the request for /foo servlet on Gump is not
served, but is redirected to /foo/, and that redirection loses the
"jsessionid" parameter.
// Must have a real docBase - just use temp
Context ctx =
tomcat.addContext("/", System.getProperty("java.io.tmpdir"));
Finally, now I am _able_ to reproduce the issue. It happens if I
create a subdirectory "foo" in the system temporary directory.
Losing jsessionid on a redirection is a bug.
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk)
failed
Posted by Konstantin Kolinko <kn...@gmail.com>.
2010/5/19 Mark Thomas <ma...@apache.org>:
> On 19/05/2010 12:25, Konstantin Kolinko wrote:
>> In the meanwhile,
>> As of now (at revision 946127),
>> org.apache.catalina.mbeans.TestRegistration fails for me:
>>
>> Testcase: testMBeanDeregistration took 1,907 sec
>> FAILED
>> Not enough Tomcat MBeans
>> junit.framework.AssertionFailedError: Not enough Tomcat MBeans
>> at org.apache.catalina.mbeans.TestRegistration.testMBeanDeregistration(TestRegistration.java:59)
>>
>> The log file contains an exception
>>
>> 19.05.2010 15:16:56 org.apache.catalina.core.StandardContext resourcesStart
>> SEVERE: Error starting static Resources
>> java.lang.IllegalArgumentException: Document base
>> <skipped>\output\webappFoo does not exist or is not a readable
>> directory
>> at org.apache.naming.resources.FileDirContext.setDocBase(FileDirContext.java:140)
>> at org.apache.catalina.core.StandardContext.resourcesStart(StandardContext.java:4397)
>> at org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:4547)
>> at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:137)
>
> This works for me via Ant and Eclipse.
>
Thank you for letting me know.
I am building with ${tomcat.output} property defined to point to a
separate directory outside of my Eclipse project. It might be related
with that.
I am now looking at TestContextConfigAnnotation that fails for me with
redefined ${tomcat.output} because of how
TestContextConfigAnnotation#paramClassResource(..) method is
implemented. I hope to fix it soon.
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk)
failed
Posted by Mark Thomas <ma...@apache.org>.
On 19/05/2010 12:25, Konstantin Kolinko wrote:
> In the meanwhile,
> As of now (at revision 946127),
> org.apache.catalina.mbeans.TestRegistration fails for me:
>
> Testcase: testMBeanDeregistration took 1,907 sec
> FAILED
> Not enough Tomcat MBeans
> junit.framework.AssertionFailedError: Not enough Tomcat MBeans
> at org.apache.catalina.mbeans.TestRegistration.testMBeanDeregistration(TestRegistration.java:59)
>
> The log file contains an exception
>
> 19.05.2010 15:16:56 org.apache.catalina.core.StandardContext resourcesStart
> SEVERE: Error starting static Resources
> java.lang.IllegalArgumentException: Document base
> <skipped>\output\webappFoo does not exist or is not a readable
> directory
> at org.apache.naming.resources.FileDirContext.setDocBase(FileDirContext.java:140)
> at org.apache.catalina.core.StandardContext.resourcesStart(StandardContext.java:4397)
> at org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:4547)
> at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:137)
This works for me via Ant and Eclipse.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: [GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk)
failed
Posted by Konstantin Kolinko <kn...@gmail.com>.
2010/5/18 Konstantin Kolinko <kn...@gmail.com>:
> 2010/5/18 Bill Barker <bi...@apache.org>:
>> The current state of this project is 'Failed', with reason 'Build Failed'.
>> For reference only, the following projects are affected by this:
>> - tomcat-trunk-test : Java Servlet 3.0, Java Server Pages 2.2 & Expression Languag...
>>
>>
>> Full details are available at:
>> http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/index.html
>>
>
> Bad news are that TestCoyoteAdaptor is still failing.
The next Gump run already happened.
(Though I see no message from it on dev@)
In TestCoyoteAdaptor of 8 tests there are 5 failures.
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test/gump_file/TEST-org.apache.catalina.connector.TestCoyoteAdaptor.txt.html
The above happened before I added back the old all-in-one testcase (r946011),
so the next time it will run 9 tests.
Testsuite: org.apache.catalina.connector.TestCoyoteAdaptor
Tests run: 8, Failures: 5, Errors: 0, Time elapsed: 16.548 sec
------------- Standard Error -----------------
(...)
------------- ---------------- ---------------
Testcase: testPathParmsRootNone took 6.158 sec
Testcase: testPathParmsFooNone took 1.145 sec
Testcase: testPathParmsRootSessionOnly took 1.228 sec
Testcase: testPathParmsFooSessionOnly took 1.147 sec
FAILED
expected:<1234> but was:<none>
junit.framework.ComparisonFailure: expected:<1234> but was:<none>
at org.apache.catalina.connector.TestCoyoteAdaptor.pathParamTest(TestCoyoteAdaptor.java:81)
at org.apache.catalina.connector.TestCoyoteAdaptor.testPathParmsFooSessionOnly(TestCoyoteAdaptor.java:47)
Testcase: testPathParmsFooSessionDummy took 1.183 sec
FAILED
expected:<1234> but was:<none>
junit.framework.ComparisonFailure: expected:<1234> but was:<none>
at org.apache.catalina.connector.TestCoyoteAdaptor.pathParamTest(TestCoyoteAdaptor.java:81)
at org.apache.catalina.connector.TestCoyoteAdaptor.testPathParmsFooSessionDummy(TestCoyoteAdaptor.java:51)
Testcase: testPathParmsFooSessionDummyValue took 1.078 sec
FAILED
expected:<1234> but was:<none>
junit.framework.ComparisonFailure: expected:<1234> but was:<none>
at org.apache.catalina.connector.TestCoyoteAdaptor.pathParamTest(TestCoyoteAdaptor.java:81)
at org.apache.catalina.connector.TestCoyoteAdaptor.testPathParmsFooSessionDummyValue(TestCoyoteAdaptor.java:55)
Testcase: testPathParmsFooSessionValue took 1.094 sec
FAILED
expected:<1234> but was:<none>
junit.framework.ComparisonFailure: expected:<1234> but was:<none>
at org.apache.catalina.connector.TestCoyoteAdaptor.pathParamTest(TestCoyoteAdaptor.java:81)
at org.apache.catalina.connector.TestCoyoteAdaptor.testPathParmsFooSessionValue(TestCoyoteAdaptor.java:59)
Testcase: testPathParmsFooSessionBar took 3.492 sec
FAILED
expected:<1234> but was:<none>
junit.framework.ComparisonFailure: expected:<1234> but was:<none>
at org.apache.catalina.connector.TestCoyoteAdaptor.pathParamTest(TestCoyoteAdaptor.java:81)
at org.apache.catalina.connector.TestCoyoteAdaptor.testPathParmsFooSessionBar(TestCoyoteAdaptor.java:63)
The failures mean that all requests to
"http://localhost:<port>/foo;jsessionid=1234"
failed to pass the jsessionid value,
though request to
"http://localhost:<port>/;jsessionid=1234"
succeeded.
I still do not observe those errors in my environment.
In the meanwhile,
As of now (at revision 946127),
org.apache.catalina.mbeans.TestRegistration fails for me:
Testcase: testMBeanDeregistration took 1,907 sec
FAILED
Not enough Tomcat MBeans
junit.framework.AssertionFailedError: Not enough Tomcat MBeans
at org.apache.catalina.mbeans.TestRegistration.testMBeanDeregistration(TestRegistration.java:59)
The log file contains an exception
19.05.2010 15:16:56 org.apache.catalina.core.StandardContext resourcesStart
SEVERE: Error starting static Resources
java.lang.IllegalArgumentException: Document base
<skipped>\output\webappFoo does not exist or is not a readable
directory
at org.apache.naming.resources.FileDirContext.setDocBase(FileDirContext.java:140)
at org.apache.catalina.core.StandardContext.resourcesStart(StandardContext.java:4397)
at org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:4547)
at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:137)
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org