You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by ag...@apache.org on 2013/09/23 10:21:51 UTC

[1/2] android commit: [CB-4892] Fix create script only escaping the first space instead of all spaces.

Updated Branches:
  refs/heads/3.1.x 4441215e4 -> 5592765f0
  refs/heads/master a51edd357 -> 2d88a726b


[CB-4892] Fix create script only escaping the first space instead of all spaces.


Project: http://git-wip-us.apache.org/repos/asf/cordova-android/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-android/commit/2d88a726
Tree: http://git-wip-us.apache.org/repos/asf/cordova-android/tree/2d88a726
Diff: http://git-wip-us.apache.org/repos/asf/cordova-android/diff/2d88a726

Branch: refs/heads/master
Commit: 2d88a726b7bc541a1d8f65332318ec67462aae05
Parents: a51edd3
Author: Andrew Grieve <ag...@chromium.org>
Authored: Mon Sep 23 10:16:58 2013 +0200
Committer: Andrew Grieve <ag...@chromium.org>
Committed: Mon Sep 23 10:16:58 2013 +0200

----------------------------------------------------------------------
 bin/lib/create.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-android/blob/2d88a726/bin/lib/create.js
----------------------------------------------------------------------
diff --git a/bin/lib/create.js b/bin/lib/create.js
index 8d597ea..9c6e86c 100755
--- a/bin/lib/create.js
+++ b/bin/lib/create.js
@@ -123,7 +123,7 @@ exports.createProject = function(project_path, package_name, project_name, proje
                            project_template_dir : 
                            path.join(ROOT, 'bin', 'templates', 'project');
 
-    var safe_activity_name = project_name.replace(/\W/, '');
+    var safe_activity_name = project_name.replace(/\W/g, '');
     var package_as_path = package_name.replace(/\./g, path.sep);
     var activity_dir    = path.join(project_path, 'src', package_as_path);
     var activity_path   = path.join(activity_dir, safe_activity_name + '.java');


[2/2] android commit: [CB-4892] Fix create script only escaping the first space instead of all spaces. (cherry picked from commit 2d88a726b7bc541a1d8f65332318ec67462aae05)

Posted by ag...@apache.org.
[CB-4892] Fix create script only escaping the first space instead of all spaces.
(cherry picked from commit 2d88a726b7bc541a1d8f65332318ec67462aae05)


Project: http://git-wip-us.apache.org/repos/asf/cordova-android/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-android/commit/5592765f
Tree: http://git-wip-us.apache.org/repos/asf/cordova-android/tree/5592765f
Diff: http://git-wip-us.apache.org/repos/asf/cordova-android/diff/5592765f

Branch: refs/heads/3.1.x
Commit: 5592765f04cda49ae1112cce183c01835d2789d9
Parents: 4441215
Author: Andrew Grieve <ag...@chromium.org>
Authored: Mon Sep 23 10:16:58 2013 +0200
Committer: Andrew Grieve <ag...@chromium.org>
Committed: Mon Sep 23 10:17:14 2013 +0200

----------------------------------------------------------------------
 bin/lib/create.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cordova-android/blob/5592765f/bin/lib/create.js
----------------------------------------------------------------------
diff --git a/bin/lib/create.js b/bin/lib/create.js
index 8d597ea..9c6e86c 100755
--- a/bin/lib/create.js
+++ b/bin/lib/create.js
@@ -123,7 +123,7 @@ exports.createProject = function(project_path, package_name, project_name, proje
                            project_template_dir : 
                            path.join(ROOT, 'bin', 'templates', 'project');
 
-    var safe_activity_name = project_name.replace(/\W/, '');
+    var safe_activity_name = project_name.replace(/\W/g, '');
     var package_as_path = package_name.replace(/\./g, path.sep);
     var activity_dir    = path.join(project_path, 'src', package_as_path);
     var activity_path   = path.join(activity_dir, safe_activity_name + '.java');