You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/11/22 02:23:45 UTC
[GitHub] [ozone] DaveTeng0 opened a new pull request, #3987: HDDS-7472. EC: Fix the NSSummaryEndpoint#getDiskUsage should be fixed for EC keys
DaveTeng0 opened a new pull request, #3987:
URL: https://github.com/apache/ozone/pull/3987
## What changes were proposed in this pull request?
EC: Fix the NSSummaryEndpoint#getDiskUsage should be fixed for EC keys
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-7472
## How was this patch tested?
CI's unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] aswinshakil commented on pull request #3987: HDDS-7472. EC: Fix NSSummaryEndpoint#getDiskUsage for EC keys
Posted by GitBox <gi...@apache.org>.
aswinshakil commented on PR #3987:
URL: https://github.com/apache/ozone/pull/3987#issuecomment-1336011710
FYI, You can mark the conversation as resolved if the comments have been addressed. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] DaveTeng0 commented on pull request #3987: HDDS-7472. EC: Fix the NSSummaryEndpoint#getDiskUsage should be fixed for EC keys
Posted by GitBox <gi...@apache.org>.
DaveTeng0 commented on PR #3987:
URL: https://github.com/apache/ozone/pull/3987#issuecomment-1322929991
cc. @jojochuang @umamaheswararao
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] aswinshakil commented on a diff in pull request #3987: HDDS-7472. EC: Fix NSSummaryEndpoint#getDiskUsage for EC keys
Posted by GitBox <gi...@apache.org>.
aswinshakil commented on code in PR #3987:
URL: https://github.com/apache/ozone/pull/3987#discussion_r1038662720
##########
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestNSSummaryEndpointWithFSO.java:
##########
@@ -218,37 +223,47 @@ public class TestNSSummaryEndpointWithFSO {
+ CONTAINER_TWO_REPLICA_COUNT * BLOCK_TWO_LENGTH
+ CONTAINER_THREE_REPLICA_COUNT * BLOCK_THREE_LENGTH;
- private static final long MULTI_BLOCK_KEY_SIZE_WITH_REPLICA
- = LOCATION_INFO_GROUP_ONE_SIZE;
private static final long LOCATION_INFO_GROUP_TWO_SIZE
= CONTAINER_FOUR_REPLICA_COUNT * BLOCK_FOUR_LENGTH
+ CONTAINER_FIVE_REPLICA_COUNT * BLOCK_FIVE_LENGTH
+ CONTAINER_SIX_REPLICA_COUNT * BLOCK_SIX_LENGTH;
private static final long FILE1_SIZE_WITH_REPLICA =
- LOCATION_INFO_GROUP_ONE_SIZE;
+ getReplicatedSize(KEY_ONE_SIZE,
Review Comment:
Thanks for the explanation. Didn't catch it initially.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] aswinshakil commented on a diff in pull request #3987: HDDS-7472. EC: Fix NSSummaryEndpoint#getDiskUsage for EC keys
Posted by GitBox <gi...@apache.org>.
aswinshakil commented on code in PR #3987:
URL: https://github.com/apache/ozone/pull/3987#discussion_r1038661475
##########
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestNSSummaryEndpointWithFSO.java:
##########
@@ -218,37 +223,47 @@ public class TestNSSummaryEndpointWithFSO {
+ CONTAINER_TWO_REPLICA_COUNT * BLOCK_TWO_LENGTH
+ CONTAINER_THREE_REPLICA_COUNT * BLOCK_THREE_LENGTH;
- private static final long MULTI_BLOCK_KEY_SIZE_WITH_REPLICA
- = LOCATION_INFO_GROUP_ONE_SIZE;
private static final long LOCATION_INFO_GROUP_TWO_SIZE
= CONTAINER_FOUR_REPLICA_COUNT * BLOCK_FOUR_LENGTH
+ CONTAINER_FIVE_REPLICA_COUNT * BLOCK_FIVE_LENGTH
+ CONTAINER_SIX_REPLICA_COUNT * BLOCK_SIX_LENGTH;
private static final long FILE1_SIZE_WITH_REPLICA =
- LOCATION_INFO_GROUP_ONE_SIZE;
+ getReplicatedSize(KEY_ONE_SIZE,
Review Comment:
Are we only considering file size with single replica?
##########
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestNSSummaryEndpointWithFSO.java:
##########
@@ -218,37 +223,47 @@ public class TestNSSummaryEndpointWithFSO {
+ CONTAINER_TWO_REPLICA_COUNT * BLOCK_TWO_LENGTH
+ CONTAINER_THREE_REPLICA_COUNT * BLOCK_THREE_LENGTH;
- private static final long MULTI_BLOCK_KEY_SIZE_WITH_REPLICA
- = LOCATION_INFO_GROUP_ONE_SIZE;
private static final long LOCATION_INFO_GROUP_TWO_SIZE
Review Comment:
If this is no longer being referenced, Can we remove it? Same for `LOCATION_INFO_GROUP_ONE_SIZE`
##########
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestNSSummaryEndpointWithLegacy.java:
##########
@@ -222,37 +227,48 @@ public class TestNSSummaryEndpointWithLegacy {
+ CONTAINER_TWO_REPLICA_COUNT * BLOCK_TWO_LENGTH
+ CONTAINER_THREE_REPLICA_COUNT * BLOCK_THREE_LENGTH;
- private static final long MULTI_BLOCK_KEY_SIZE_WITH_REPLICA
- = LOCATION_INFO_GROUP_ONE_SIZE;
private static final long LOCATION_INFO_GROUP_TWO_SIZE
Review Comment:
Same as the above comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] DaveTeng0 commented on a diff in pull request #3987: HDDS-7472. EC: Fix NSSummaryEndpoint#getDiskUsage for EC keys
Posted by GitBox <gi...@apache.org>.
DaveTeng0 commented on code in PR #3987:
URL: https://github.com/apache/ozone/pull/3987#discussion_r1038662627
##########
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestNSSummaryEndpointWithFSO.java:
##########
@@ -218,37 +223,47 @@ public class TestNSSummaryEndpointWithFSO {
+ CONTAINER_TWO_REPLICA_COUNT * BLOCK_TWO_LENGTH
+ CONTAINER_THREE_REPLICA_COUNT * BLOCK_THREE_LENGTH;
- private static final long MULTI_BLOCK_KEY_SIZE_WITH_REPLICA
- = LOCATION_INFO_GROUP_ONE_SIZE;
private static final long LOCATION_INFO_GROUP_TWO_SIZE
Review Comment:
yes, no longer referenced (LOCATION_INFO_GROUP_ONE_SIZE, LOCATION_INFO_GROUP_TWO_SIZE), could be removed from FSO/Legacy test!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] DaveTeng0 commented on a diff in pull request #3987: HDDS-7472. EC: Fix NSSummaryEndpoint#getDiskUsage for EC keys
Posted by GitBox <gi...@apache.org>.
DaveTeng0 commented on code in PR #3987:
URL: https://github.com/apache/ozone/pull/3987#discussion_r1038662627
##########
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestNSSummaryEndpointWithFSO.java:
##########
@@ -218,37 +223,47 @@ public class TestNSSummaryEndpointWithFSO {
+ CONTAINER_TWO_REPLICA_COUNT * BLOCK_TWO_LENGTH
+ CONTAINER_THREE_REPLICA_COUNT * BLOCK_THREE_LENGTH;
- private static final long MULTI_BLOCK_KEY_SIZE_WITH_REPLICA
- = LOCATION_INFO_GROUP_ONE_SIZE;
private static final long LOCATION_INFO_GROUP_TWO_SIZE
Review Comment:
yes, no longer referenced, could be removed!
##########
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestNSSummaryEndpointWithLegacy.java:
##########
@@ -222,37 +227,48 @@ public class TestNSSummaryEndpointWithLegacy {
+ CONTAINER_TWO_REPLICA_COUNT * BLOCK_TWO_LENGTH
+ CONTAINER_THREE_REPLICA_COUNT * BLOCK_THREE_LENGTH;
- private static final long MULTI_BLOCK_KEY_SIZE_WITH_REPLICA
- = LOCATION_INFO_GROUP_ONE_SIZE;
private static final long LOCATION_INFO_GROUP_TWO_SIZE
Review Comment:
yes, no longer referenced, could be removed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] aswinshakil commented on a diff in pull request #3987: HDDS-7472. EC: Fix NSSummaryEndpoint#getDiskUsage for EC keys
Posted by GitBox <gi...@apache.org>.
aswinshakil commented on code in PR #3987:
URL: https://github.com/apache/ozone/pull/3987#discussion_r1038661475
##########
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestNSSummaryEndpointWithFSO.java:
##########
@@ -218,37 +223,47 @@ public class TestNSSummaryEndpointWithFSO {
+ CONTAINER_TWO_REPLICA_COUNT * BLOCK_TWO_LENGTH
+ CONTAINER_THREE_REPLICA_COUNT * BLOCK_THREE_LENGTH;
- private static final long MULTI_BLOCK_KEY_SIZE_WITH_REPLICA
- = LOCATION_INFO_GROUP_ONE_SIZE;
private static final long LOCATION_INFO_GROUP_TWO_SIZE
= CONTAINER_FOUR_REPLICA_COUNT * BLOCK_FOUR_LENGTH
+ CONTAINER_FIVE_REPLICA_COUNT * BLOCK_FIVE_LENGTH
+ CONTAINER_SIX_REPLICA_COUNT * BLOCK_SIX_LENGTH;
private static final long FILE1_SIZE_WITH_REPLICA =
- LOCATION_INFO_GROUP_ONE_SIZE;
+ getReplicatedSize(KEY_ONE_SIZE,
Review Comment:
Are we only considering file size with a single replica? I don't understand this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] DaveTeng0 commented on a diff in pull request #3987: HDDS-7472. EC: Fix NSSummaryEndpoint#getDiskUsage for EC keys
Posted by GitBox <gi...@apache.org>.
DaveTeng0 commented on code in PR #3987:
URL: https://github.com/apache/ozone/pull/3987#discussion_r1038662639
##########
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestNSSummaryEndpointWithLegacy.java:
##########
@@ -222,37 +227,48 @@ public class TestNSSummaryEndpointWithLegacy {
+ CONTAINER_TWO_REPLICA_COUNT * BLOCK_TWO_LENGTH
+ CONTAINER_THREE_REPLICA_COUNT * BLOCK_THREE_LENGTH;
- private static final long MULTI_BLOCK_KEY_SIZE_WITH_REPLICA
- = LOCATION_INFO_GROUP_ONE_SIZE;
private static final long LOCATION_INFO_GROUP_TWO_SIZE
Review Comment:
oh! sorry I found there's still one UT using it in each Legacy/FSO test!
(FSO: https://github.com/apache/ozone/blob/master/hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestNSSummaryEndpointWithFSO.java#L568
Legacy: https://github.com/apache/ozone/blob/master/hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestNSSummaryEndpointWithLegacy.java#L569
)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] DaveTeng0 commented on a diff in pull request #3987: HDDS-7472. EC: Fix NSSummaryEndpoint#getDiskUsage for EC keys
Posted by GitBox <gi...@apache.org>.
DaveTeng0 commented on code in PR #3987:
URL: https://github.com/apache/ozone/pull/3987#discussion_r1038662558
##########
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestNSSummaryEndpointWithFSO.java:
##########
@@ -218,37 +223,47 @@ public class TestNSSummaryEndpointWithFSO {
+ CONTAINER_TWO_REPLICA_COUNT * BLOCK_TWO_LENGTH
+ CONTAINER_THREE_REPLICA_COUNT * BLOCK_THREE_LENGTH;
- private static final long MULTI_BLOCK_KEY_SIZE_WITH_REPLICA
- = LOCATION_INFO_GROUP_ONE_SIZE;
private static final long LOCATION_INFO_GROUP_TWO_SIZE
= CONTAINER_FOUR_REPLICA_COUNT * BLOCK_FOUR_LENGTH
+ CONTAINER_FIVE_REPLICA_COUNT * BLOCK_FIVE_LENGTH
+ CONTAINER_SIX_REPLICA_COUNT * BLOCK_SIX_LENGTH;
private static final long FILE1_SIZE_WITH_REPLICA =
- LOCATION_INFO_GROUP_ONE_SIZE;
+ getReplicatedSize(KEY_ONE_SIZE,
Review Comment:
ohh yes! From the original testing setting it set up these files with the single replica!
(https://github.com/apache/ozone/blob/master/hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/OMMetadataManagerTestUtils.java#L218)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] jojochuang commented on pull request #3987: HDDS-7472. EC: Fix NSSummaryEndpoint#getDiskUsage for EC keys
Posted by GitBox <gi...@apache.org>.
jojochuang commented on PR #3987:
URL: https://github.com/apache/ozone/pull/3987#issuecomment-1338069963
Merged Thanks @DaveTeng0 @aswinshakil
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] aswinshakil commented on a diff in pull request #3987: HDDS-7472. EC: Fix NSSummaryEndpoint#getDiskUsage for EC keys
Posted by GitBox <gi...@apache.org>.
aswinshakil commented on code in PR #3987:
URL: https://github.com/apache/ozone/pull/3987#discussion_r1030840769
##########
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestNSSummaryEndpointWithFSO.java:
##########
@@ -943,7 +943,7 @@ private void setUpMultiBlockKey() throws IOException {
BUCKET_ONE_OBJECT_ID,
VOL_OBJECT_ID,
Collections.singletonList(locationInfoGroup),
- getBucketLayout());
+ getBucketLayout(), FILE7_SIZE_WITH_REPLICA);
Review Comment:
Should this be the actual data size instead of the size with replicas? Same for other changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] DaveTeng0 commented on a diff in pull request #3987: HDDS-7472. EC: Fix NSSummaryEndpoint#getDiskUsage for EC keys
Posted by GitBox <gi...@apache.org>.
DaveTeng0 commented on code in PR #3987:
URL: https://github.com/apache/ozone/pull/3987#discussion_r1038662639
##########
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestNSSummaryEndpointWithLegacy.java:
##########
@@ -222,37 +227,48 @@ public class TestNSSummaryEndpointWithLegacy {
+ CONTAINER_TWO_REPLICA_COUNT * BLOCK_TWO_LENGTH
+ CONTAINER_THREE_REPLICA_COUNT * BLOCK_THREE_LENGTH;
- private static final long MULTI_BLOCK_KEY_SIZE_WITH_REPLICA
- = LOCATION_INFO_GROUP_ONE_SIZE;
private static final long LOCATION_INFO_GROUP_TWO_SIZE
Review Comment:
oh! sorry I found there's still one UT using MULTI_BLOCK_KEY_SIZE_WITH_REPLICA in each Legacy/FSO test!
(FSO: https://github.com/apache/ozone/blob/master/hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestNSSummaryEndpointWithFSO.java#L568
Legacy: https://github.com/apache/ozone/blob/master/hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestNSSummaryEndpointWithLegacy.java#L569
)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] DaveTeng0 commented on a diff in pull request #3987: HDDS-7472. EC: Fix NSSummaryEndpoint#getDiskUsage for EC keys
Posted by GitBox <gi...@apache.org>.
DaveTeng0 commented on code in PR #3987:
URL: https://github.com/apache/ozone/pull/3987#discussion_r1036354916
##########
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/OMMetadataManagerTestUtils.java:
##########
@@ -233,7 +234,7 @@ public static void writeKeyToOm(OMMetadataManager omMetadataManager,
long bucketObjectId,
long volumeObjectId,
List<OmKeyLocationInfoGroup> locationVersions,
- BucketLayout bucketLayout)
+ BucketLayout bucketLayout, long dataSize)
Review Comment:
sure, updated!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] DaveTeng0 commented on a diff in pull request #3987: HDDS-7472. EC: Fix NSSummaryEndpoint#getDiskUsage for EC keys
Posted by GitBox <gi...@apache.org>.
DaveTeng0 commented on code in PR #3987:
URL: https://github.com/apache/ozone/pull/3987#discussion_r1035416034
##########
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestNSSummaryEndpointWithFSO.java:
##########
@@ -943,7 +943,7 @@ private void setUpMultiBlockKey() throws IOException {
BUCKET_ONE_OBJECT_ID,
VOL_OBJECT_ID,
Collections.singletonList(locationInfoGroup),
- getBucketLayout());
+ getBucketLayout(), FILE7_SIZE_WITH_REPLICA);
Review Comment:
Yes! Thanks for the good-catch!! I found I have to update some of the key-size calculation in those test files to make the test result be able to align with the expectation values. updated!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] DaveTeng0 commented on a diff in pull request #3987: HDDS-7472. EC: Fix NSSummaryEndpoint#getDiskUsage for EC keys
Posted by GitBox <gi...@apache.org>.
DaveTeng0 commented on code in PR #3987:
URL: https://github.com/apache/ozone/pull/3987#discussion_r1038665089
##########
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/api/TestNSSummaryEndpointWithFSO.java:
##########
@@ -943,7 +943,7 @@ private void setUpMultiBlockKey() throws IOException {
BUCKET_ONE_OBJECT_ID,
VOL_OBJECT_ID,
Collections.singletonList(locationInfoGroup),
- getBucketLayout());
+ getBucketLayout(), FILE7_SIZE_WITH_REPLICA);
Review Comment:
The original key-size calculation in these tests didn't consider the replication type of the key, which didn't reflect the actual size of key with replica. Thus, updated the way to calculate the key size in these tests!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] jojochuang commented on a diff in pull request #3987: HDDS-7472. EC: Fix NSSummaryEndpoint#getDiskUsage for EC keys
Posted by GitBox <gi...@apache.org>.
jojochuang commented on code in PR #3987:
URL: https://github.com/apache/ozone/pull/3987#discussion_r1030534020
##########
hadoop-ozone/recon/src/test/java/org/apache/hadoop/ozone/recon/OMMetadataManagerTestUtils.java:
##########
@@ -233,7 +234,7 @@ public static void writeKeyToOm(OMMetadataManager omMetadataManager,
long bucketObjectId,
long volumeObjectId,
List<OmKeyLocationInfoGroup> locationVersions,
- BucketLayout bucketLayout)
+ BucketLayout bucketLayout, long dataSize)
Review Comment:
let's keep it consistent, and move it to the next line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] jojochuang merged pull request #3987: HDDS-7472. EC: Fix NSSummaryEndpoint#getDiskUsage for EC keys
Posted by GitBox <gi...@apache.org>.
jojochuang merged PR #3987:
URL: https://github.com/apache/ozone/pull/3987
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org