[GitHub] [superset] ktmud edited a comment on issue #16553: [Proposal] Superset Frontend Style Guidelines

[GitBox <gi...@apache.org>]

ktmud edited a comment on issue #16553:
URL: https://github.com/apache/superset/issues/16553#issuecomment-910615443


   This is a great starting point! I like `If there’s not a linting rule, we don’t have a rule!`, but I think some places would still benefit from more specific rules? For example:
   
   - React props should go with the component itself, and not in a `types.ts` file
   - Don't put multiple components in a React file (should be capturable by eslint)
   - Use `type ...` for React props and `interface ...` for all other places
   - Prefer TypeScript string literals type over Enums and const variables
   - How to use variables in Emotion
   
   These are hard to capture in linter and formatter but could still help code maintainability, readability and performance.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org